[v2] Couple of fixes and impl for virDomainSetIOThreadParams

[libvirt] [PATCH v2 0/2] Couple of fixes and impl for virDomainSetIOThreadParams

John Ferlan posted 2 patches 5 years, 5 months ago

Diff against v1
Download series mbox

Failed in applying to current master (apply log)

generator.py             |  1 +
libvirt-override-api.xml |  8 +++++
libvirt-override.c       | 67 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 76 insertions(+)

Expand all Fold all

[libvirt] [PATCH v2 0/2] Couple of fixes and impl for virDomainSetIOThreadParams

Posted by John Ferlan 5 years, 5 months ago

v1: https://www.redhat.com/archives/libvir-list/2018-November/msg00772.html

Changes since v1:

 - Pushed the first two patches w/ R-By

 - Add/Insert a patch to handle when PyDict_Check fails

 - Modify libvirt_virDomainSetIOThreadParams from code review for
   the @args on the same line (not sure why I did that) and to add
   the else for PyDict_Check failure with error message.

 - Change the "IOThread performance parameters" to "IOThread polling
   parameters" since that more closely describes them.

John Ferlan (2):
  Add check for params, nparams being a dictionary
  Implement API binding for virDomainSetIOThreadParams

 generator.py             |  1 +
 libvirt-override-api.xml |  8 +++++
 libvirt-override.c       | 67 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 76 insertions(+)

-- 
2.17.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/2] Couple of fixes and impl for virDomainSetIOThreadParams

Posted by Pavel Hrdina 5 years, 5 months ago

On Tue, Nov 20, 2018 at 12:13:02PM -0500, John Ferlan wrote:
> v1: https://www.redhat.com/archives/libvir-list/2018-November/msg00772.html
> 
> Changes since v1:
> 
>  - Pushed the first two patches w/ R-By
> 
>  - Add/Insert a patch to handle when PyDict_Check fails
> 
>  - Modify libvirt_virDomainSetIOThreadParams from code review for
>    the @args on the same line (not sure why I did that) and to add
>    the else for PyDict_Check failure with error message.
> 
>  - Change the "IOThread performance parameters" to "IOThread polling
>    parameters" since that more closely describes them.
> 
> John Ferlan (2):
>   Add check for params, nparams being a dictionary
>   Implement API binding for virDomainSetIOThreadParams

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list