1. Patchew
  2. Libvirt
  3. View series

[libvirt] [jenkins-ci PATCH] Don't run libvirt-dbus-syntax-check on FreeBSD

Andrea Bolognani posted 1 patch 5 years, 5 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
guests/playbooks/build/projects/libvirt-dbus.yml | 4 +---
projects/libvirt-dbus.yaml                       | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
[libvirt] [jenkins-ci PATCH] Don't run libvirt-dbus-syntax-check on FreeBSD
Posted by Andrea Bolognani 5 years, 5 months ago 
flake8 wants 'pyflakes<1.7.0,>=1.5.0', but all FreeBSD
releases ship pyflakes 2.0.0 these days.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/playbooks/build/projects/libvirt-dbus.yml | 4 +---
 projects/libvirt-dbus.yaml                       | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/guests/playbooks/build/projects/libvirt-dbus.yml b/guests/playbooks/build/projects/libvirt-dbus.yml
index 1d4ecbd..61ece63 100644
--- a/guests/playbooks/build/projects/libvirt-dbus.yml
+++ b/guests/playbooks/build/projects/libvirt-dbus.yml
@@ -22,15 +22,13 @@
 - include: '{{ playbook_base }}/jobs/autotools-syntax-check-job.yml'
   vars:
     # CentOS 7 doesn't include Python 3 and the version of pyflakes
-    # in FreeBSD CURRENT is too new to be used by flake8
+    # in FreeBSD is too new to be used by flake8
     machines:
       - libvirt-debian-9
       - libvirt-debian-sid
       - libvirt-fedora-28
       - libvirt-fedora-29
       - libvirt-fedora-rawhide
-      - libvirt-freebsd-10
-      - libvirt-freebsd-11
       - libvirt-ubuntu-16
       - libvirt-ubuntu-18
 - include: '{{ playbook_base }}/jobs/autotools-check-job.yml'
diff --git a/projects/libvirt-dbus.yaml b/projects/libvirt-dbus.yaml
index 48bbdaa..49f5366 100644
--- a/projects/libvirt-dbus.yaml
+++ b/projects/libvirt-dbus.yaml
@@ -19,14 +19,12 @@
       - autotools-syntax-check-job:
           parent_jobs: 'libvirt-dbus-build'
           # CentOS 7 doesn't include Python 3 and the version of pyflakes
-          # in FreeBSD CURRENT is too new to be used by flake8
+          # in FreeBSD is too new to be used by flake8
           machines:
             - libvirt-debian-9
             - libvirt-fedora-28
             - libvirt-fedora-29
             - libvirt-fedora-rawhide
-            - libvirt-freebsd-10
-            - libvirt-freebsd-11
       - autotools-check-job:
           parent_jobs: 'libvirt-dbus-syntax-check'
           # CentOS 7 doesn't include Python 3 and the version in Ubuntu
-- 
2.19.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] Don't run libvirt-dbus-syntax-check on FreeBSD
Posted by Daniel P. Berrangé 5 years, 5 months ago 
On Wed, Nov 14, 2018 at 01:43:10PM +0100, Andrea Bolognani wrote:
> flake8 wants 'pyflakes<1.7.0,>=1.5.0', but all FreeBSD
> releases ship pyflakes 2.0.0 these days.

This rationale doesn't make sense given that I see Fedora has
flake8 which is happily using pyflakes 2.0.0

   # rpm -q python3-flake8 python3-pyflakes
   python3-flake8-3.5.0-6.fc29.noarch
   python3-pyflakes-2.0.0-7.fc29.noarch

Something else must be happening on FreeBSD.

> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/playbooks/build/projects/libvirt-dbus.yml | 4 +---
>  projects/libvirt-dbus.yaml                       | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/guests/playbooks/build/projects/libvirt-dbus.yml b/guests/playbooks/build/projects/libvirt-dbus.yml
> index 1d4ecbd..61ece63 100644
> --- a/guests/playbooks/build/projects/libvirt-dbus.yml
> +++ b/guests/playbooks/build/projects/libvirt-dbus.yml
> @@ -22,15 +22,13 @@
>  - include: '{{ playbook_base }}/jobs/autotools-syntax-check-job.yml'
>    vars:
>      # CentOS 7 doesn't include Python 3 and the version of pyflakes
> -    # in FreeBSD CURRENT is too new to be used by flake8
> +    # in FreeBSD is too new to be used by flake8
>      machines:
>        - libvirt-debian-9
>        - libvirt-debian-sid
>        - libvirt-fedora-28
>        - libvirt-fedora-29
>        - libvirt-fedora-rawhide
> -      - libvirt-freebsd-10
> -      - libvirt-freebsd-11
>        - libvirt-ubuntu-16
>        - libvirt-ubuntu-18
>  - include: '{{ playbook_base }}/jobs/autotools-check-job.yml'
> diff --git a/projects/libvirt-dbus.yaml b/projects/libvirt-dbus.yaml
> index 48bbdaa..49f5366 100644
> --- a/projects/libvirt-dbus.yaml
> +++ b/projects/libvirt-dbus.yaml
> @@ -19,14 +19,12 @@
>        - autotools-syntax-check-job:
>            parent_jobs: 'libvirt-dbus-build'
>            # CentOS 7 doesn't include Python 3 and the version of pyflakes
> -          # in FreeBSD CURRENT is too new to be used by flake8
> +          # in FreeBSD is too new to be used by flake8
>            machines:
>              - libvirt-debian-9
>              - libvirt-fedora-28
>              - libvirt-fedora-29
>              - libvirt-fedora-rawhide
> -            - libvirt-freebsd-10
> -            - libvirt-freebsd-11
>        - autotools-check-job:
>            parent_jobs: 'libvirt-dbus-syntax-check'
>            # CentOS 7 doesn't include Python 3 and the version in Ubuntu
> -- 
> 2.19.1
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] Don't run libvirt-dbus-syntax-check on FreeBSD
Posted by Andrea Bolognani 5 years, 5 months ago 
On Wed, 2018-11-14 at 13:12 +0000, Daniel P. Berrangé wrote:
> On Wed, Nov 14, 2018 at 01:43:10PM +0100, Andrea Bolognani wrote:
> > flake8 wants 'pyflakes<1.7.0,>=1.5.0', but all FreeBSD
> > releases ship pyflakes 2.0.0 these days.
> 
> This rationale doesn't make sense given that I see Fedora has
> flake8 which is happily using pyflakes 2.0.0
> 
>    # rpm -q python3-flake8 python3-pyflakes
>    python3-flake8-3.5.0-6.fc29.noarch
>    python3-pyflakes-2.0.0-7.fc29.noarch
> 
> Something else must be happening on FreeBSD.

Looks like Fedora is carrying a patch[1] that introduces pyflakes
2.0.0 compatibility, which has been backported from flake8 3.6.0.
I don't expect FreeBSD will backport the patch, they're probably
going to jump straight to the newer upstream release instead.

So we can either merge this patch to make the failures go away for
the time being and re-introduce the job once flake8 3.6.0 is
available in FreeBSD, or endure the failure a bit longer and just
wait for it to go away on its own. In the latter case, re-adding
FreeBSD -CURRENT as a target for the job would make as well.

Let me know which one of the two solutions you prefer.


[1] https://src.fedoraproject.org/rpms/python-flake8/blob/f29/f/python-flake8-3.5.0-pyflakes-2.0.0.patch
-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] Don't run libvirt-dbus-syntax-check on FreeBSD
Posted by Daniel P. Berrangé 5 years, 5 months ago 
On Wed, Nov 14, 2018 at 03:12:19PM +0100, Andrea Bolognani wrote:
> On Wed, 2018-11-14 at 13:12 +0000, Daniel P. Berrangé wrote:
> > On Wed, Nov 14, 2018 at 01:43:10PM +0100, Andrea Bolognani wrote:
> > > flake8 wants 'pyflakes<1.7.0,>=1.5.0', but all FreeBSD
> > > releases ship pyflakes 2.0.0 these days.
> > 
> > This rationale doesn't make sense given that I see Fedora has
> > flake8 which is happily using pyflakes 2.0.0
> > 
> >    # rpm -q python3-flake8 python3-pyflakes
> >    python3-flake8-3.5.0-6.fc29.noarch
> >    python3-pyflakes-2.0.0-7.fc29.noarch
> > 
> > Something else must be happening on FreeBSD.
> 
> Looks like Fedora is carrying a patch[1] that introduces pyflakes
> 2.0.0 compatibility, which has been backported from flake8 3.6.0.
> I don't expect FreeBSD will backport the patch, they're probably
> going to jump straight to the newer upstream release instead.
> 
> So we can either merge this patch to make the failures go away for
> the time being and re-introduce the job once flake8 3.6.0 is
> available in FreeBSD, or endure the failure a bit longer and just
> wait for it to go away on its own. In the latter case, re-adding
> FreeBSD -CURRENT as a target for the job would make as well.
> 
> Let me know which one of the two solutions you prefer.

I'm fine taking this patch for now, if you just clarify the
commit message a little about the problem being flake8
<= 3.5.0

> 
> 
> [1] https://src.fedoraproject.org/rpms/python-flake8/blob/f29/f/python-flake8-3.5.0-pyflakes-2.0.0.patch

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] Don't run libvirt-dbus-syntax-check on FreeBSD
Posted by Andrea Bolognani 5 years, 5 months ago 
On Wed, 2018-11-14 at 14:25 +0000, Daniel P. Berrangé wrote:
> On Wed, Nov 14, 2018 at 03:12:19PM +0100, Andrea Bolognani wrote:
> > So we can either merge this patch to make the failures go away for
> > the time being and re-introduce the job once flake8 3.6.0 is
> > available in FreeBSD, or endure the failure a bit longer and just
> > wait for it to go away on its own. In the latter case, re-adding
> > FreeBSD -CURRENT as a target for the job would make as well.
> > 
> > Let me know which one of the two solutions you prefer.
> 
> I'm fine taking this patch for now, if you just clarify the
> commit message a little about the problem being flake8
> <= 3.5.0

Fair enough. v2 here:

  https://www.redhat.com/archives/libvir-list/2018-November/msg00553.html

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.