flake8 3.5.0 doesn't work with pyflakes 2.0.0, and since those
are the versions available through ports there's currently no
way to successfully run flake8 on FreeBSD.

We will be able to revert this once flake8 3.6.0 is available
through ports.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/playbooks/build/projects/libvirt-dbus.yml | 7 +++----
 projects/libvirt-dbus.yaml                       | 7 +++----
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/guests/playbooks/build/projects/libvirt-dbus.yml b/guests/playbooks/build/projects/libvirt-dbus.yml
index 1d4ecbd..41e670c 100644
--- a/guests/playbooks/build/projects/libvirt-dbus.yml
+++ b/guests/playbooks/build/projects/libvirt-dbus.yml
@@ -21,16 +21,15 @@
 - include: '{{ playbook_base }}/jobs/autotools-build-job.yml'
 - include: '{{ playbook_base }}/jobs/autotools-syntax-check-job.yml'
   vars:
-    # CentOS 7 doesn't include Python 3 and the version of pyflakes
-    # in FreeBSD CURRENT is too new to be used by flake8
+    # CentOS 7 doesn't include Python 3, while the versions of flake8
+    # and pyflakes currently available on FreeBSD (3.5.0 and 2.0.0
+    # respectively) are not compatible
     machines:
       - libvirt-debian-9
       - libvirt-debian-sid
       - libvirt-fedora-28
       - libvirt-fedora-29
       - libvirt-fedora-rawhide
-      - libvirt-freebsd-10
-      - libvirt-freebsd-11
       - libvirt-ubuntu-16
       - libvirt-ubuntu-18
 - include: '{{ playbook_base }}/jobs/autotools-check-job.yml'
diff --git a/projects/libvirt-dbus.yaml b/projects/libvirt-dbus.yaml
index 48bbdaa..3d1ed9c 100644
--- a/projects/libvirt-dbus.yaml
+++ b/projects/libvirt-dbus.yaml
@@ -18,15 +18,14 @@
           parent_jobs: 'libvirt-glib-build'
       - autotools-syntax-check-job:
           parent_jobs: 'libvirt-dbus-build'
-          # CentOS 7 doesn't include Python 3 and the version of pyflakes
-          # in FreeBSD CURRENT is too new to be used by flake8
+          # CentOS 7 doesn't include Python 3, while the versions of flake8
+          # and pyflakes currently available on FreeBSD (3.5.0 and 2.0.0
+          # respectively) are not compatible
           machines:
             - libvirt-debian-9
             - libvirt-fedora-28
             - libvirt-fedora-29
             - libvirt-fedora-rawhide
-            - libvirt-freebsd-10
-            - libvirt-freebsd-11
       - autotools-check-job:
           parent_jobs: 'libvirt-dbus-syntax-check'
           # CentOS 7 doesn't include Python 3 and the version in Ubuntu
-- 
2.19.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, Nov 14, 2018 at 03:48:16PM +0100, Andrea Bolognani wrote:
> flake8 3.5.0 doesn't work with pyflakes 2.0.0, and since those
> are the versions available through ports there's currently no
> way to successfully run flake8 on FreeBSD.
> 
> We will be able to revert this once flake8 3.6.0 is available
> through ports.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/playbooks/build/projects/libvirt-dbus.yml | 7 +++----
>  projects/libvirt-dbus.yaml                       | 7 +++----
>  2 files changed, 6 insertions(+), 8 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list