[libvirt] [dbus PATCH 00/15] Build system fixes, cleanups and tweaks

Andrea Bolognani posted 15 patches 5 years, 10 months ago
Failed in applying to current master (apply log)
.gitignore           | 15 ++++++++--
Makefile.am          | 12 ++++++--
configure.ac         |  3 +-
data/Makefile.am     | 40 +++++++++++++++++--------
docs/Makefile.am     | 16 +++++++---
libvirt-dbus.spec.in |  2 +-
src/Makefile.am      | 70 ++++++++++++++++++++++++++------------------
tests/Makefile.am    | 36 ++++++++++++++++-------
8 files changed, 130 insertions(+), 64 deletions(-)
[libvirt] [dbus PATCH 00/15] Build system fixes, cleanups and tweaks
Posted by Andrea Bolognani 5 years, 10 months ago
It all started when I got

  tests/Makefile.am:17: warning: source file '$(top_srcdir)/src/util.c' is in a subdirectory,
  tests/Makefile.am:17: but option 'subdir-objects' is disabled
  automake: warning: possible forward-incompatibility.
  automake: At least a source file is in a subdirectory, but the 'subdir-objects'
  automake: automake option hasn't been enabled.  For now, the corresponding output
  automake: object file(s) will be placed in the top-level directory.  However,
  automake: this behaviour will change in future Automake versions: they will
  automake: unconditionally cause object files to be placed in the same subdirectory
  automake: of the corresponding sources.
  automake: You are advised to start using 'subdir-objects' option throughout your
  automake: project, to avoid future incompatibilities.

when running autogen.sh and decided to investigate; before
I realized it, I was already deep down the rabbit hole and
falling towards Wonderland at an increasingly concerning
speed.

Andrea Bolognani (15):
  gitignore: Fix man page pattern
  gitignore: Fix aclocal.m4 pattern
  tests: Don't distribute compiled binaries
  src: Fix typo in PIE_LDFLAGS
  src: Remove empty CLEANFILES
  src: Don't list source files in EXTRA_DIST
  tests: Move includes to AM_CPPFLAGS
  src: Make CFLAGS and LDFLAGS global
  configure: Enable libtool
  src: Build libutil.la separately
  configure: Enable subdir-objects
  configure: Enable -Wno-obsolete and tar-pax
  configure: Use xz for release archives
  data: Rename some variables to *_in_files
  autotools: Use consistent style

 .gitignore           | 15 ++++++++--
 Makefile.am          | 12 ++++++--
 configure.ac         |  3 +-
 data/Makefile.am     | 40 +++++++++++++++++--------
 docs/Makefile.am     | 16 +++++++---
 libvirt-dbus.spec.in |  2 +-
 src/Makefile.am      | 70 ++++++++++++++++++++++++++------------------
 tests/Makefile.am    | 36 ++++++++++++++++-------
 8 files changed, 130 insertions(+), 64 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH 00/15] Build system fixes, cleanups and tweaks
Posted by Pavel Hrdina 5 years, 9 months ago
On Fri, Jun 29, 2018 at 06:01:07PM +0200, Andrea Bolognani wrote:
> It all started when I got
> 
>   tests/Makefile.am:17: warning: source file '$(top_srcdir)/src/util.c' is in a subdirectory,
>   tests/Makefile.am:17: but option 'subdir-objects' is disabled
>   automake: warning: possible forward-incompatibility.
>   automake: At least a source file is in a subdirectory, but the 'subdir-objects'
>   automake: automake option hasn't been enabled.  For now, the corresponding output
>   automake: object file(s) will be placed in the top-level directory.  However,
>   automake: this behaviour will change in future Automake versions: they will
>   automake: unconditionally cause object files to be placed in the same subdirectory
>   automake: of the corresponding sources.
>   automake: You are advised to start using 'subdir-objects' option throughout your
>   automake: project, to avoid future incompatibilities.
> 
> when running autogen.sh and decided to investigate; before
> I realized it, I was already deep down the rabbit hole and
> falling towards Wonderland at an increasingly concerning
> speed.
> 
> Andrea Bolognani (15):
>   gitignore: Fix man page pattern
>   gitignore: Fix aclocal.m4 pattern
>   tests: Don't distribute compiled binaries
>   src: Fix typo in PIE_LDFLAGS
>   src: Remove empty CLEANFILES
>   src: Don't list source files in EXTRA_DIST
>   tests: Move includes to AM_CPPFLAGS
>   src: Make CFLAGS and LDFLAGS global
>   configure: Enable libtool
>   src: Build libutil.la separately
>   configure: Enable subdir-objects
>   configure: Enable -Wno-obsolete and tar-pax
>   configure: Use xz for release archives
>   data: Rename some variables to *_in_files
>   autotools: Use consistent style

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list