From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530288155950204.15945031699982; Fri, 29 Jun 2018 09:02:35 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 878531A9E3C; Fri, 29 Jun 2018 16:02:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 343C592A6E; Fri, 29 Jun 2018 16:02:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8FEEF4BB78; Fri, 29 Jun 2018 16:02:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1Rxq010041 for ; Fri, 29 Jun 2018 12:01:28 -0400 Received: by smtp.corp.redhat.com (Postfix) id D79882026D6A; Fri, 29 Jun 2018 16:01:27 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7BE3C2026D68 for ; Fri, 29 Jun 2018 16:01:27 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:08 +0200 Message-Id: <20180629160122.19827-2-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 01/15] gitignore: Fix man page pattern X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 29 Jun 2018 16:02:35 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The man page for libvirt-dbus is in section 8, not 1. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index c5e16a9..28a7c57 100644 --- a/.gitignore +++ b/.gitignore @@ -30,7 +30,7 @@ vgcore.* /data/system/libvirt-dbus.rules /data/system/org.libvirt.conf =20 -/docs/*.1 +/docs/*.8 =20 /src/libvirt-dbus /src/org.libvirt.service --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15302881430596.955417172613579; Fri, 29 Jun 2018 09:02:23 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D1958C04AC5D; Fri, 29 Jun 2018 16:02:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 18DAF8D0B6; Fri, 29 Jun 2018 16:02:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 492BD18037ED; Fri, 29 Jun 2018 16:02:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1S1a010047 for ; Fri, 29 Jun 2018 12:01:28 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7AF6A2026D6A; Fri, 29 Jun 2018 16:01:28 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FCBE2026D68 for ; Fri, 29 Jun 2018 16:01:27 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:09 +0200 Message-Id: <20180629160122.19827-3-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 02/15] gitignore: Fix aclocal.m4 pattern X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 29 Jun 2018 16:02:22 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Ignore patterns are shell globs, so '.' doesn't need escaping. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 28a7c57..b792bac 100644 --- a/.gitignore +++ b/.gitignore @@ -21,7 +21,7 @@ vgcore.* /configure /libvirt-dbus-*.tar.gz /libvirt-dbus.spec -/m4/aclocal\.m4 +/m4/aclocal.m4 /run /stamp-h1 =20 --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530288502111154.56258331492597; Fri, 29 Jun 2018 09:08:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A97F27CDF4; Fri, 29 Jun 2018 16:08:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 312CD2010D9E; Fri, 29 Jun 2018 16:08:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C73581800C9C; Fri, 29 Jun 2018 16:08:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1TvZ010055 for ; Fri, 29 Jun 2018 12:01:29 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1E3BF2026D6A; Fri, 29 Jun 2018 16:01:29 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B6FE22026D68 for ; Fri, 29 Jun 2018 16:01:28 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:10 +0200 Message-Id: <20180629160122.19827-4-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 03/15] tests: Don't distribute compiled binaries X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 29 Jun 2018 16:08:21 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" test_programs is included in EXTRA_DIST, so we need to make sure compiled binaries don't end in there or they will be included in release archives. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- tests/Makefile.am | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 1fc240b..bf2dbbc 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -4,7 +4,6 @@ test_helpers =3D \ conftest.py =20 test_programs =3D \ - $(check_PROGRAMS) \ test_connect.py \ test_domain.py \ test_network.py \ @@ -35,7 +34,10 @@ EXTRA_DIST =3D \ $(test_programs) \ travis-run =20 -TESTS =3D $(test_programs) +TESTS =3D \ + $(check_PROGRAMS) \ + $(test_programs) \ + $(NULL) =20 AM_TESTS_ENVIRONMENT =3D \ export abs_top_builddir=3D"$(abs_top_builddir)"; \ --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530288506903590.0511946183783; Fri, 29 Jun 2018 09:08:26 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E04FD3078AC4; Fri, 29 Jun 2018 16:08:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE6ED2010D9E; Fri, 29 Jun 2018 16:08:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6370A1800C99; Fri, 29 Jun 2018 16:08:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1TiA010060 for ; Fri, 29 Jun 2018 12:01:30 -0400 Received: by smtp.corp.redhat.com (Postfix) id B55A32026D6A; Fri, 29 Jun 2018 16:01:29 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A25D2026D68 for ; Fri, 29 Jun 2018 16:01:29 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:11 +0200 Message-Id: <20180629160122.19827-5-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 04/15] src: Fix typo in PIE_LDFLAGS X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 29 Jun 2018 16:08:26 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 3ef3472..de30df1 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -40,7 +40,7 @@ libvirt_dbus_LDFLAGS =3D \ $(LIBVIRT_LDFLAGS) \ $(LIBVIRT_GLIB_LDFLAGS) \ $(RELRO_LDFLAGS) \ - $(PID_LDFLAGS) \ + $(PIE_LDFLAGS) \ $(NULL) =20 libvirt_dbus_LDADD =3D \ --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530288163519995.4028509401655; Fri, 29 Jun 2018 09:02:43 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6E08A3078ACE; Fri, 29 Jun 2018 16:02:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31D1D79582; Fri, 29 Jun 2018 16:02:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CB90218037EF; Fri, 29 Jun 2018 16:02:41 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1U8j010070 for ; Fri, 29 Jun 2018 12:01:30 -0400 Received: by smtp.corp.redhat.com (Postfix) id 58AAA2026D6A; Fri, 29 Jun 2018 16:01:30 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F19412026D68 for ; Fri, 29 Jun 2018 16:01:29 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:12 +0200 Message-Id: <20180629160122.19827-6-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 05/15] src: Remove empty CLEANFILES X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 29 Jun 2018 16:02:43 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" No point in declaring it if we're not going to use it. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- src/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index de30df1..4662348 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -19,7 +19,6 @@ DAEMON_SOURCES =3D \ =20 EXTRA_DIST =3D \ $(DAEMON_SOURCES) -CLEANFILES =3D =20 bin_PROGRAMS =3D libvirt-dbus =20 --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530288512871434.8587422297793; Fri, 29 Jun 2018 09:08:32 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 953A930C10E4; Fri, 29 Jun 2018 16:08:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 441778308C; Fri, 29 Jun 2018 16:08:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D7C061800B68; Fri, 29 Jun 2018 16:08:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1VVu010075 for ; Fri, 29 Jun 2018 12:01:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id F09452026D6A; Fri, 29 Jun 2018 16:01:30 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 94DF72026D68 for ; Fri, 29 Jun 2018 16:01:30 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:13 +0200 Message-Id: <20180629160122.19827-7-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 06/15] src: Don't list source files in EXTRA_DIST X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 29 Jun 2018 16:08:32 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" All files listed in a *_SOURCE directive are automatically distributed, so listing them explicitly is pointless. This makes DAEMON_SOURCES unnecessary, so we can drop it and list source files in libvirt_dbus_SOURCES directly instead. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- src/Makefile.am | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 4662348..688dfb5 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -2,7 +2,9 @@ AM_CPPFLAGS =3D \ -I$(top_srcdir)/src \ -DVIRT_DBUS_INTERFACES_DIR=3D\"$(DBUS_INTERFACES_DIR)\" =20 -DAEMON_SOURCES =3D \ +bin_PROGRAMS =3D libvirt-dbus + +libvirt_dbus_SOURCES =3D \ main.c \ connect.c connect.h \ util.c util.h \ @@ -17,13 +19,6 @@ DAEMON_SOURCES =3D \ storagevol.c storagevol.h \ $(NULL) =20 -EXTRA_DIST =3D \ - $(DAEMON_SOURCES) - -bin_PROGRAMS =3D libvirt-dbus - -libvirt_dbus_SOURCES =3D $(DAEMON_SOURCES) - libvirt_dbus_CFLAGS =3D \ $(GIO2_CFLAGS) \ $(GLIB2_CFLAGS) \ --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530288162391837.3070459454614; Fri, 29 Jun 2018 09:02:42 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C0A653002C9E; Fri, 29 Jun 2018 16:02:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 857D579599; Fri, 29 Jun 2018 16:02:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3A24218037F1; Fri, 29 Jun 2018 16:02:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1V03010083 for ; Fri, 29 Jun 2018 12:01:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 939012026D6A; Fri, 29 Jun 2018 16:01:31 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 38AF22026D68 for ; Fri, 29 Jun 2018 16:01:31 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:14 +0200 Message-Id: <20180629160122.19827-8-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 07/15] tests: Move includes to AM_CPPFLAGS X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 29 Jun 2018 16:02:42 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Includes should be part of *_CPPFLAGS, not *_CFLAGS; since we have to move the include around anyway, might as well make it global instead of limiting it to the single test binary we're building at the moment. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- tests/Makefile.am | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index bf2dbbc..03d51aa 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,3 +1,7 @@ +AM_CPPFLAGS =3D \ + -I$(top_srcdir)/src \ + $(NULL) + test_helpers =3D \ xmldata.py \ libvirttest.py \ @@ -16,7 +20,6 @@ check_PROGRAMS =3D \ test_util_SOURCES =3D \ test_util.c $(top_srcdir)/src/util.c test_util_CFLAGS =3D \ - -I$(top_srcdir)/src \ $(GIO2_CFLAGS) \ $(GLIB2_CFLAGS) \ $(LIBVIRT_CFLAGS) --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530288168869658.6101085720146; Fri, 29 Jun 2018 09:02:48 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 89AEB3078ACB; Fri, 29 Jun 2018 16:02:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4FAC87959A; Fri, 29 Jun 2018 16:02:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DEA744A463; Fri, 29 Jun 2018 16:02:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1WxX010088 for ; Fri, 29 Jun 2018 12:01:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id 383B42026D6A; Fri, 29 Jun 2018 16:01:32 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D0B2C2026D68 for ; Fri, 29 Jun 2018 16:01:31 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:15 +0200 Message-Id: <20180629160122.19827-9-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 08/15] src: Make CFLAGS and LDFLAGS global X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 29 Jun 2018 16:02:48 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" There's nothing target-specific about either. This is going to be useful later on. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- src/Makefile.am | 35 ++++++++++++++++------------------- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 688dfb5..1b73c8d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,6 +1,22 @@ AM_CPPFLAGS =3D \ -I$(top_srcdir)/src \ -DVIRT_DBUS_INTERFACES_DIR=3D\"$(DBUS_INTERFACES_DIR)\" +AM_CFLAGS =3D \ + $(GIO2_CFLAGS) \ + $(GLIB2_CFLAGS) \ + $(LIBVIRT_CFLAGS) \ + $(LIBVIRT_GLIB_CFLAGS) \ + $(WARN_CFLAGS) \ + $(PIE_CFLAGS) \ + $(NULL) +AM_LDFLAGS =3D \ + $(GIO2_LDFLAGS) \ + $(GLIB2_LDFLAGS) \ + $(LIBVIRT_LDFLAGS) \ + $(LIBVIRT_GLIB_LDFLAGS) \ + $(RELRO_LDFLAGS) \ + $(PID_LDFLAGS) \ + $(NULL) =20 bin_PROGRAMS =3D libvirt-dbus =20 @@ -18,25 +34,6 @@ libvirt_dbus_SOURCES =3D \ storagepool.c storagepool.h \ storagevol.c storagevol.h \ $(NULL) - -libvirt_dbus_CFLAGS =3D \ - $(GIO2_CFLAGS) \ - $(GLIB2_CFLAGS) \ - $(LIBVIRT_CFLAGS) \ - $(LIBVIRT_GLIB_CFLAGS) \ - $(WARN_CFLAGS) \ - $(PIE_CFLAGS) \ - $(NULL) - -libvirt_dbus_LDFLAGS =3D \ - $(GIO2_LDFLAGS) \ - $(GLIB2_LDFLAGS) \ - $(LIBVIRT_LDFLAGS) \ - $(LIBVIRT_GLIB_LDFLAGS) \ - $(RELRO_LDFLAGS) \ - $(PIE_LDFLAGS) \ - $(NULL) - libvirt_dbus_LDADD =3D \ $(GIO2_LIBS) \ $(GLIB2_LIBS) \ --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530288174264124.02916343470122; Fri, 29 Jun 2018 09:02:54 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F1206307CF45; Fri, 29 Jun 2018 16:02:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BDEB575ACB; Fri, 29 Jun 2018 16:02:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 741204A460; Fri, 29 Jun 2018 16:02:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1WJ1010096 for ; Fri, 29 Jun 2018 12:01:33 -0400 Received: by smtp.corp.redhat.com (Postfix) id CE7212026D6A; Fri, 29 Jun 2018 16:01:32 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 738D22026D68 for ; Fri, 29 Jun 2018 16:01:32 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:16 +0200 Message-Id: <20180629160122.19827-10-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 09/15] configure: Enable libtool X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 29 Jun 2018 16:02:53 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" We're going to start using libtool convenience libraries in a second. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- .gitignore | 9 +++++++++ configure.ac | 1 + 2 files changed, 10 insertions(+) diff --git a/.gitignore b/.gitignore index b792bac..48e0411 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,5 @@ +*.la +*.lo *.log *.o *.pyc @@ -6,6 +8,7 @@ *Makefile.in *~ .deps +.libs __pycache__ vgcore.* =20 @@ -19,9 +22,15 @@ vgcore.* /config.log /config.status /configure +/libtool /libvirt-dbus-*.tar.gz /libvirt-dbus.spec /m4/aclocal.m4 +/m4/libtool.m4 +/m4/ltoptions.m4 +/m4/ltsugar.m4 +/m4/ltversion.m4 +/m4/lt~obsolete.m4 /run /stamp-h1 =20 diff --git a/configure.ac b/configure.ac index d7820dd..eef0834 100644 --- a/configure.ac +++ b/configure.ac @@ -35,6 +35,7 @@ AC_PROG_CC AC_PROG_MKDIR_P AM_PROG_CC_C_O AC_PROG_CC_STDC +AC_PROG_LIBTOOL =20 PKG_CHECK_MODULES(GIO2, gio-unix-2.0 >=3D GLIB2_REQUIRED) PKG_CHECK_MODULES(GLIB2, glib-2.0 >=3D GLIB2_REQUIRED) --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530288167306691.553236545835; Fri, 29 Jun 2018 09:02:47 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2DE487F6CF; Fri, 29 Jun 2018 16:02:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E970E89F0B; Fri, 29 Jun 2018 16:02:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9738F18037F5; Fri, 29 Jun 2018 16:02:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1XiC010101 for ; Fri, 29 Jun 2018 12:01:33 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7147F2026D6A; Fri, 29 Jun 2018 16:01:33 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 165FB2026D68 for ; Fri, 29 Jun 2018 16:01:32 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:17 +0200 Message-Id: <20180629160122.19827-11-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 10/15] src: Build libutil.la separately X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 29 Jun 2018 16:02:46 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" We use these utility functions both in the daemon and for test programs, so create a new convenience library that we can compile once and include in both places. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- src/Makefile.am | 11 ++++++++++- tests/Makefile.am | 4 +++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 1b73c8d..493cf81 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -18,12 +18,20 @@ AM_LDFLAGS =3D \ $(PID_LDFLAGS) \ $(NULL) =20 +noinst_LTLIBRARIES =3D \ + libutil.la \ + $(NULL) + +libutil_la_SOURCES =3D \ + util.c \ + util.h \ + $(NULL) + bin_PROGRAMS =3D libvirt-dbus =20 libvirt_dbus_SOURCES =3D \ main.c \ connect.c connect.h \ - util.c util.h \ domain.c domain.h \ events.c events.h \ gdbus.c gdbus.h \ @@ -35,6 +43,7 @@ libvirt_dbus_SOURCES =3D \ storagevol.c storagevol.h \ $(NULL) libvirt_dbus_LDADD =3D \ + libutil.la \ $(GIO2_LIBS) \ $(GLIB2_LIBS) \ $(LIBVIRT_LIBS) \ diff --git a/tests/Makefile.am b/tests/Makefile.am index 03d51aa..2991689 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -18,7 +18,8 @@ check_PROGRAMS =3D \ test_util =20 test_util_SOURCES =3D \ - test_util.c $(top_srcdir)/src/util.c + test_util.c \ + $(NULL) test_util_CFLAGS =3D \ $(GIO2_CFLAGS) \ $(GLIB2_CFLAGS) \ @@ -28,6 +29,7 @@ test_util_LDFLAGS =3D \ $(GLIB2_LDFLAGS) \ $(LIBVIRT_LDFLAGS) test_util_LDADD =3D \ + $(top_builddir)/src/libutil.la \ $(GIO2_LIBS) \ $(GLIB2_LIBS) \ $(LIBVIRT_LIBS) --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530288518438187.86463199334435; Fri, 29 Jun 2018 09:08:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C289D1A9E35; Fri, 29 Jun 2018 16:08:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A0D375AD7; Fri, 29 Jun 2018 16:08:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3CF7A4A463; Fri, 29 Jun 2018 16:08:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1YFi010115 for ; Fri, 29 Jun 2018 12:01:34 -0400 Received: by smtp.corp.redhat.com (Postfix) id 13F4F2026D6A; Fri, 29 Jun 2018 16:01:34 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AD35C2026D68 for ; Fri, 29 Jun 2018 16:01:33 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:18 +0200 Message-Id: <20180629160122.19827-12-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 11/15] configure: Enable subdir-objects X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 29 Jun 2018 16:08:37 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This is the recommended mode of operation. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index eef0834..b6261a0 100644 --- a/configure.ac +++ b/configure.ac @@ -5,7 +5,7 @@ AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) AC_CONFIG_MACRO_DIR([m4]) dnl Make automake keep quiet about wildcards & other GNUmake-isms -AM_INIT_AUTOMAKE([foreign -Wno-portability]) +AM_INIT_AUTOMAKE([foreign -Wno-portability subdir-objects]) AC_CANONICAL_HOST AC_USE_SYSTEM_EXTENSIONS =20 --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530288173385642.627536346727; Fri, 29 Jun 2018 09:02:53 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 50BCD30B9E1F; Fri, 29 Jun 2018 16:02:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1238C183B7; Fri, 29 Jun 2018 16:02:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A7B1818037F1; Fri, 29 Jun 2018 16:02:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1YfA010120 for ; Fri, 29 Jun 2018 12:01:34 -0400 Received: by smtp.corp.redhat.com (Postfix) id AB2DF2026D6A; Fri, 29 Jun 2018 16:01:34 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 504542026D68 for ; Fri, 29 Jun 2018 16:01:34 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:19 +0200 Message-Id: <20180629160122.19827-13-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 12/15] configure: Enable -Wno-obsolete and tar-pax X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 29 Jun 2018 16:02:52 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" libvirt already use both options and libvirt-dbus only targets a subset of the platforms, so we can safely enable them. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index b6261a0..fff237a 100644 --- a/configure.ac +++ b/configure.ac @@ -5,7 +5,7 @@ AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) AC_CONFIG_MACRO_DIR([m4]) dnl Make automake keep quiet about wildcards & other GNUmake-isms -AM_INIT_AUTOMAKE([foreign -Wno-portability subdir-objects]) +AM_INIT_AUTOMAKE([foreign -Wno-portability -Wno-obsolete subdir-objects ta= r-pax]) AC_CANONICAL_HOST AC_USE_SYSTEM_EXTENSIONS =20 --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 153028852411415.348896619663833; Fri, 29 Jun 2018 09:08:44 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B7ADC3082283; Fri, 29 Jun 2018 16:08:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 599D579599; Fri, 29 Jun 2018 16:08:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 04FE21800B6D; Fri, 29 Jun 2018 16:08:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1ZKO010130 for ; Fri, 29 Jun 2018 12:01:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4ED722026D6A; Fri, 29 Jun 2018 16:01:35 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E78D12026D68 for ; Fri, 29 Jun 2018 16:01:34 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:20 +0200 Message-Id: <20180629160122.19827-14-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 13/15] configure: Use xz for release archives X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 29 Jun 2018 16:08:43 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" libvirt already uses xz compression, so we can safely follow suit. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- .gitignore | 2 +- configure.ac | 2 +- libvirt-dbus.spec.in | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 48e0411..052b1ff 100644 --- a/.gitignore +++ b/.gitignore @@ -23,7 +23,7 @@ vgcore.* /config.status /configure /libtool -/libvirt-dbus-*.tar.gz +/libvirt-dbus-*.tar.* /libvirt-dbus.spec /m4/aclocal.m4 /m4/libtool.m4 diff --git a/configure.ac b/configure.ac index fff237a..493cd11 100644 --- a/configure.ac +++ b/configure.ac @@ -5,7 +5,7 @@ AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) AC_CONFIG_MACRO_DIR([m4]) dnl Make automake keep quiet about wildcards & other GNUmake-isms -AM_INIT_AUTOMAKE([foreign -Wno-portability -Wno-obsolete subdir-objects ta= r-pax]) +AM_INIT_AUTOMAKE([foreign -Wno-portability -Wno-obsolete subdir-objects ta= r-pax no-dist-gzip dist-xz]) AC_CANONICAL_HOST AC_USE_SYSTEM_EXTENSIONS =20 diff --git a/libvirt-dbus.spec.in b/libvirt-dbus.spec.in index 319fd59..285eec0 100644 --- a/libvirt-dbus.spec.in +++ b/libvirt-dbus.spec.in @@ -11,7 +11,7 @@ Release: 1%{?dist} Summary: libvirt D-Bus API binding License: LGPLv2+ URL: https://libvirt.org/ -Source0: https://libvirt.org/sources/dbus/%{name}-%{version}.tar.gz +Source0: https://libvirt.org/sources/dbus/%{name}-%{version}.tar.xz =20 BuildRequires: gcc BuildRequires: glib2-devel >=3D %{glib2_version} --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530288529963803.6372914442519; Fri, 29 Jun 2018 09:08:49 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9618C3082288; Fri, 29 Jun 2018 16:08:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5631492A6E; Fri, 29 Jun 2018 16:08:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 028441800B68; Fri, 29 Jun 2018 16:08:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1aOK010135 for ; Fri, 29 Jun 2018 12:01:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id E7C4C2026D6A; Fri, 29 Jun 2018 16:01:35 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8CB5C2026D68 for ; Fri, 29 Jun 2018 16:01:35 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:21 +0200 Message-Id: <20180629160122.19827-15-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 14/15] data: Rename some variables to *_in_files X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 29 Jun 2018 16:08:49 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Some of the variables that contain lists of files that will undergo pre-processing follow the *_in_files naming convention to highlight the fact; let's be consistent about it. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- data/Makefile.am | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/data/Makefile.am b/data/Makefile.am index 8c5a8d2..f1e9dfd 100644 --- a/data/Makefile.am +++ b/data/Makefile.am @@ -8,15 +8,15 @@ system_service_in_files =3D \ system_servicedir =3D $(DBUS_SYSTEM_SERVICES_DIR) system_service_DATA =3D $(system_service_in_files:.service.in=3D.service) =20 -system_policy_files =3D \ +system_policy_in_files =3D \ system/org.libvirt.conf.in system_policydir =3D $(DBUS_SYSTEM_POLICIES_DIR) -system_policy_DATA =3D $(system_policy_files:.conf.in=3D.conf) +system_policy_DATA =3D $(system_policy_in_files:.conf.in=3D.conf) =20 -polkit_files =3D \ +polkit_in_files =3D \ system/libvirt-dbus.rules.in polkitdir =3D $(POLKIT_RULES_DIR) -polkit_DATA =3D $(polkit_files:.rules.in=3D.rules) +polkit_DATA =3D $(polkit_in_files:.rules.in=3D.rules) =20 interfaces_files =3D \ org.libvirt.Connect.xml \ @@ -34,8 +34,8 @@ interfaces_DATA =3D $(interfaces_files) EXTRA_DIST =3D \ $(service_in_files) \ $(system_service_in_files) \ - $(system_policy_files) \ - $(polkit_files) \ + $(system_policy_in_files) \ + $(polkit_in_files) \ $(interfaces_files) \ $(NULL) =20 --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat May 11 22:48:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530288177862757.1636046310427; Fri, 29 Jun 2018 09:02:57 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C280F307CF40; Fri, 29 Jun 2018 16:02:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6FB571001918; Fri, 29 Jun 2018 16:02:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DD7EB4A46E; Fri, 29 Jun 2018 16:02:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5TG1axg010145 for ; Fri, 29 Jun 2018 12:01:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8AF7C2026D6A; Fri, 29 Jun 2018 16:01:36 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FF1E2026D68 for ; Fri, 29 Jun 2018 16:01:36 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 29 Jun 2018 18:01:22 +0200 Message-Id: <20180629160122.19827-16-abologna@redhat.com> In-Reply-To: <20180629160122.19827-1-abologna@redhat.com> References: <20180629160122.19827-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 15/15] autotools: Use consistent style X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 29 Jun 2018 16:02:57 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Sticking to one item per line will ensure future diffs are minimal and easily understandable. More in general, being consistent is good :) Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- Makefile.am | 12 +++++++++--- data/Makefile.am | 32 +++++++++++++++++++++++--------- docs/Makefile.am | 16 ++++++++++++---- src/Makefile.am | 40 +++++++++++++++++++++++++++------------- tests/Makefile.am | 21 ++++++++++++++------- 5 files changed, 85 insertions(+), 36 deletions(-) diff --git a/Makefile.am b/Makefile.am index bb5ff5c..93941c6 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,5 +1,9 @@ - -SUBDIRS =3D data docs src tests +SUBDIRS =3D \ + data \ + docs \ + src \ + tests \ + $(NULL) =20 ACLOCAL_AMFLAGS =3D -I m4 =20 @@ -11,7 +15,9 @@ EXTRA_DIST =3D \ README.md \ $(NULL) =20 -DISTCLEAN_FILES =3D $(PACKAGE).spec +DISTCLEAN_FILES =3D \ + $(PACKAGE).spec \ + $(NULL) =20 rpm: clean @(unset CDPATH ; $(MAKE) dist && rpmbuild -ta $(distdir).tar.gz) diff --git a/data/Makefile.am b/data/Makefile.am index f1e9dfd..7b523da 100644 --- a/data/Makefile.am +++ b/data/Makefile.am @@ -1,22 +1,34 @@ service_in_files =3D \ - session/org.libvirt.service.in + session/org.libvirt.service.in \ + $(NULL) servicedir =3D $(DBUS_SERVICES_DIR) -service_DATA =3D $(service_in_files:.service.in=3D.service) +service_DATA =3D \ + $(service_in_files:.service.in=3D.service) \ + $(NULL) =20 system_service_in_files =3D \ - system/org.libvirt.service.in + system/org.libvirt.service.in \ + $(NULL) system_servicedir =3D $(DBUS_SYSTEM_SERVICES_DIR) -system_service_DATA =3D $(system_service_in_files:.service.in=3D.service) +system_service_DATA =3D \ + $(system_service_in_files:.service.in=3D.service) \ + $(NULL) =20 system_policy_in_files =3D \ - system/org.libvirt.conf.in + system/org.libvirt.conf.in \ + $(NULL) system_policydir =3D $(DBUS_SYSTEM_POLICIES_DIR) -system_policy_DATA =3D $(system_policy_in_files:.conf.in=3D.conf) +system_policy_DATA =3D \ + $(system_policy_in_files:.conf.in=3D.conf) \ + $(NULL) =20 polkit_in_files =3D \ - system/libvirt-dbus.rules.in + system/libvirt-dbus.rules.in \ + $(NULL) polkitdir =3D $(POLKIT_RULES_DIR) -polkit_DATA =3D $(polkit_in_files:.rules.in=3D.rules) +polkit_DATA =3D \ + $(polkit_in_files:.rules.in=3D.rules) \ + $(NULL) =20 interfaces_files =3D \ org.libvirt.Connect.xml \ @@ -29,7 +41,9 @@ interfaces_files =3D \ org.libvirt.StorageVol.xml \ $(NULL) interfacesdir =3D $(DBUS_INTERFACES_DIR) -interfaces_DATA =3D $(interfaces_files) +interfaces_DATA =3D \ + $(interfaces_files) \ + $(NULL) =20 EXTRA_DIST =3D \ $(service_in_files) \ diff --git a/docs/Makefile.am b/docs/Makefile.am index c41ffae..fe8ca1c 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -1,13 +1,21 @@ POD2MAN =3D pod2man -c "Virtualization Support" -r "$(PACKAGE)-$(VERSION)" =20 -PODFILES =3D libvirt-dbus.pod +PODFILES =3D \ + libvirt-dbus.pod \ + $(NULL) =20 %.8: %.pod $(AM_V_GEN)$(POD2MAN) -s 8 $< $@ \ && if grep 'POD ERROR' $@; then rm $@; exit 1; fi =20 -man8_MANS =3D libvirt-dbus.8 +man8_MANS =3D \ + libvirt-dbus.8 \ + $(NULL) =20 -EXTRA_DIST =3D $(PODFILES) +EXTRA_DIST =3D \ + $(PODFILES) \ + $(NULL) =20 -CLEANFILES =3D $(man8_MANS) +CLEANFILES =3D \ + $(man8_MANS) \ + $(NULL) diff --git a/src/Makefile.am b/src/Makefile.am index 493cf81..2fb1820 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,6 +1,7 @@ AM_CPPFLAGS =3D \ -I$(top_srcdir)/src \ - -DVIRT_DBUS_INTERFACES_DIR=3D\"$(DBUS_INTERFACES_DIR)\" + -DVIRT_DBUS_INTERFACES_DIR=3D\"$(DBUS_INTERFACES_DIR)\" \ + $(NULL) AM_CFLAGS =3D \ $(GIO2_CFLAGS) \ $(GLIB2_CFLAGS) \ @@ -27,24 +28,37 @@ libutil_la_SOURCES =3D \ util.h \ $(NULL) =20 -bin_PROGRAMS =3D libvirt-dbus +bin_PROGRAMS =3D \ + libvirt-dbus \ + $(NULL) =20 libvirt_dbus_SOURCES =3D \ + connect.c \ + connect.h \ + domain.c \ + domain.h \ + events.c \ + events.h \ + gdbus.c \ + gdbus.h \ main.c \ - connect.c connect.h \ - domain.c domain.h \ - events.c events.h \ - gdbus.c gdbus.h \ - network.c network.h \ - nodedev.c nodedev.h \ - nwfilter.c nwfilter.h \ - secret.c secret.h \ - storagepool.c storagepool.h \ - storagevol.c storagevol.h \ + network.c \ + network.h \ + nodedev.c \ + nodedev.h \ + nwfilter.c \ + nwfilter.h \ + secret.c \ + secret.h \ + storagepool.c \ + storagepool.h \ + storagevol.c \ + storagevol.h \ $(NULL) libvirt_dbus_LDADD =3D \ libutil.la \ $(GIO2_LIBS) \ $(GLIB2_LIBS) \ $(LIBVIRT_LIBS) \ - $(LIBVIRT_GLIB_LIBS) + $(LIBVIRT_GLIB_LIBS) \ + $(NULL) diff --git a/tests/Makefile.am b/tests/Makefile.am index 2991689..09c3e2e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -5,17 +5,20 @@ AM_CPPFLAGS =3D \ test_helpers =3D \ xmldata.py \ libvirttest.py \ - conftest.py + conftest.py \ + $(NULL) =20 test_programs =3D \ test_connect.py \ test_domain.py \ test_network.py \ test_nodedev.py \ - test_storage.py + test_storage.py \ + $(NULL) =20 check_PROGRAMS =3D \ - test_util + test_util \ + $(NULL) =20 test_util_SOURCES =3D \ test_util.c \ @@ -23,21 +26,25 @@ test_util_SOURCES =3D \ test_util_CFLAGS =3D \ $(GIO2_CFLAGS) \ $(GLIB2_CFLAGS) \ - $(LIBVIRT_CFLAGS) + $(LIBVIRT_CFLAGS) \ + $(NULL) test_util_LDFLAGS =3D \ $(GIO2_LDFLAGS) \ $(GLIB2_LDFLAGS) \ - $(LIBVIRT_LDFLAGS) + $(LIBVIRT_LDFLAGS) \ + $(NULL) test_util_LDADD =3D \ $(top_builddir)/src/libutil.la \ $(GIO2_LIBS) \ $(GLIB2_LIBS) \ - $(LIBVIRT_LIBS) + $(LIBVIRT_LIBS) \ + $(NULL) =20 EXTRA_DIST =3D \ $(test_helpers) \ $(test_programs) \ - travis-run + travis-run \ + $(NULL) =20 TESTS =3D \ $(check_PROGRAMS) \ --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list