[v1] Clean up the nwfilter mess I created

[libvirt] [PATCH 0/2] Clean up the nwfilter mess I created

John Ferlan posted 2 patches 6 years, 6 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170928192649.10704-1-jferlan@redhat.com

There is a newer version of this series

src/conf/nwfilter_ipaddrmap.c       | 9 +--------
src/nwfilter/nwfilter_learnipaddr.c | 5 ++++-
2 files changed, 5 insertions(+), 9 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] Clean up the nwfilter mess I created

Posted by John Ferlan 6 years, 6 months ago

Silly me - touching the nwfilter code... Turns out the reverted patch
in 1/2 doesn't cover it as virNWFilterVarValueCreateSimple actually
steals @addr, so freeing it on successful return ends up being a very
bad thing as I found out with the nwfilter avocado-vt tests.

So revert that and just go with the only free on failure logic in patch2

John Ferlan (2):
  Revert "nwfilter: Fix possible segfault on sometimes consumed
    variable"
  nwfilter: Only free inetaddr on virNWFilterIPAddrMapAddIPAddr failure

 src/conf/nwfilter_ipaddrmap.c       | 9 +--------
 src/nwfilter/nwfilter_learnipaddr.c | 5 ++++-
 2 files changed, 5 insertions(+), 9 deletions(-)

-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list