[v2] Clean up the nwfilter mess I created

[libvirt] [PATCH v2 0/2] Clean up the nwfilter mess I created

John Ferlan posted 2 patches 6 years, 6 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170929200250.19184-1-jferlan@redhat.com

src/conf/nwfilter_ipaddrmap.c     | 16 +++++++++-------
src/nwfilter/nwfilter_dhcpsnoop.c |  3 ---
2 files changed, 9 insertions(+), 10 deletions(-)

Expand all Fold all

[libvirt] [PATCH v2 0/2] Clean up the nwfilter mess I created

Posted by John Ferlan 6 years, 6 months ago

v1: https://www.redhat.com/archives/libvir-list/2017-September/msg01072.html

Changes:

 * Patch1: No change, ACK'd, but not safe to push yet either..

 * Patch2: Rather than have virNWFilterIPAddrMapAddIPAddr consume
           the input @addr, let's make a copy of the input parameter
           and manage it within that code so that it wouldn't be
           consumed on virNWFilterHashTablePut failure after
           virNWFilterVarValueCreateSimple success.

John Ferlan (2):
  Revert "nwfilter: Fix possible segfault on sometimes consumed
    variable"
  nwfilter: Don't have virNWFilterIPAddrMapAddIPAddr consume input

 src/conf/nwfilter_ipaddrmap.c     | 16 +++++++++-------
 src/nwfilter/nwfilter_dhcpsnoop.c |  3 ---
 2 files changed, 9 insertions(+), 10 deletions(-)

-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/2] Clean up the nwfilter mess I created

Posted by Ján Tomko 6 years, 6 months ago

On Fri, Sep 29, 2017 at 04:02:48PM -0400, John Ferlan wrote:
>v1: https://www.redhat.com/archives/libvir-list/2017-September/msg01072.html
>
>Changes:
>
> * Patch1: No change, ACK'd, but not safe to push yet either..
>
> * Patch2: Rather than have virNWFilterIPAddrMapAddIPAddr consume
>           the input @addr, let's make a copy of the input parameter
>           and manage it within that code so that it wouldn't be
>           consumed on virNWFilterHashTablePut failure after
>           virNWFilterVarValueCreateSimple success.
>
>John Ferlan (2):
>  Revert "nwfilter: Fix possible segfault on sometimes consumed
>    variable"
>  nwfilter: Don't have virNWFilterIPAddrMapAddIPAddr consume input
>
> src/conf/nwfilter_ipaddrmap.c     | 16 +++++++++-------
> src/nwfilter/nwfilter_dhcpsnoop.c |  3 ---
> 2 files changed, 9 insertions(+), 10 deletions(-)

ACK series

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list