[PATCH] qemu: Fix proper ordering of 'virtlockd' shutdown

Peter Krempa via Devel posted 1 patch 6 days, 18 hours ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1c3543d04910dd9a729d86d3d9c026635cb316cc.1787040787.git.pkrempa@redhat.com
src/qemu/virtqemud.service.extra.in | 2 +-
src/remote/libvirtd.service.in      | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[PATCH] qemu: Fix proper ordering of 'virtlockd' shutdown
Posted by Peter Krempa via Devel 6 days, 18 hours ago
From: Peter Krempa <pkrempa@redhat.com>

In commit aa1bf13b9caa4ef893cd4fdbaa111d5da73aa120 I attempted to fix
the ordering of virtlockd and virtlogd during shutdown but I made a typo
in the name of 'virtlockd.service' (missing 'd').

Fixes: aa1bf13b9caa4ef893cd4fdbaa111d5da73aa120
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/virtqemud.service.extra.in | 2 +-
 src/remote/libvirtd.service.in      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/virtqemud.service.extra.in b/src/qemu/virtqemud.service.extra.in
index 3cc2edcfd0..df36890704 100644
--- a/src/qemu/virtqemud.service.extra.in
+++ b/src/qemu/virtqemud.service.extra.in
@@ -9,7 +9,7 @@ After=virtlockd.socket
 # To ensure that our helper daemons are not shut down before the main daemon
 # shuts down we need also explicit ordering with the .service unit
 After=virtlogd.service
-After=virtlock.service
+After=virtlockd.service
 Wants=systemd-machined.service
 After=systemd-machined.service
 After=remote-fs.target
diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in
index f26494d646..ccdb8379f3 100644
--- a/src/remote/libvirtd.service.in
+++ b/src/remote/libvirtd.service.in
@@ -18,7 +18,7 @@ After=virtlockd.socket
 # To ensure that our helper daemons are not shut down before the main daemon
 # shuts down we need also explicit ordering with the .service unit
 After=virtlogd.service
-After=virtlock.service
+After=virtlockd.service
 Wants=systemd-machined.service
 After=network.target
 After=dbus.service
-- 
2.55.0
Re: [PATCH] qemu: Fix proper ordering of 'virtlockd' shutdown
Posted by Martin Kletzander via Devel 6 days, 17 hours ago
On Tue, Aug 18, 2026 at 10:13:07AM +0200, Peter Krempa via Devel wrote:
>From: Peter Krempa <pkrempa@redhat.com>
>
>In commit aa1bf13b9caa4ef893cd4fdbaa111d5da73aa120 I attempted to fix
>the ordering of virtlockd and virtlogd during shutdown but I made a typo
>in the name of 'virtlockd.service' (missing 'd').
>
>Fixes: aa1bf13b9caa4ef893cd4fdbaa111d5da73aa120
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>---
> src/qemu/virtqemud.service.extra.in | 2 +-
> src/remote/libvirtd.service.in      | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/qemu/virtqemud.service.extra.in b/src/qemu/virtqemud.service.extra.in
>index 3cc2edcfd0..df36890704 100644
>--- a/src/qemu/virtqemud.service.extra.in
>+++ b/src/qemu/virtqemud.service.extra.in
>@@ -9,7 +9,7 @@ After=virtlockd.socket
> # To ensure that our helper daemons are not shut down before the main daemon
> # shuts down we need also explicit ordering with the .service unit
> After=virtlogd.service
>-After=virtlock.service
>+After=virtlockd.service
> Wants=systemd-machined.service
> After=systemd-machined.service
> After=remote-fs.target
>diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in
>index f26494d646..ccdb8379f3 100644
>--- a/src/remote/libvirtd.service.in
>+++ b/src/remote/libvirtd.service.in
>@@ -18,7 +18,7 @@ After=virtlockd.socket
> # To ensure that our helper daemons are not shut down before the main daemon
> # shuts down we need also explicit ordering with the .service unit
> After=virtlogd.service
>-After=virtlock.service
>+After=virtlockd.service
> Wants=systemd-machined.service
> After=network.target
> After=dbus.service
>-- 
>2.55.0
>
Re: [PATCH] qemu: Fix proper ordering of 'virtlockd' shutdown
Posted by Pavel Hrdina via Devel 6 days, 18 hours ago
On Tue, Aug 18, 2026 at 10:13:07AM +0200, Peter Krempa via Devel wrote:
> From: Peter Krempa <pkrempa@redhat.com>
> 
> In commit aa1bf13b9caa4ef893cd4fdbaa111d5da73aa120 I attempted to fix
> the ordering of virtlockd and virtlogd during shutdown but I made a typo
> in the name of 'virtlockd.service' (missing 'd').
> 
> Fixes: aa1bf13b9caa4ef893cd4fdbaa111d5da73aa120
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/qemu/virtqemud.service.extra.in | 2 +-
>  src/remote/libvirtd.service.in      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>