From nobody Tue Aug 25 02:51:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1787040853; cv=none; d=zohomail.com; s=zohoarc; b=F+D1mWXbWEiW2IDqOnrukpsgBskcJUPCc47j//68EuEfdfeJzM/9XLkz2nb/PxTXDtZIUZJpSeETlK22veQ+geQ6A1pEyOYR4aKlV1W0ocj2jCG/rwPMdULfPvhZnKp3TaElksV15f2onEkoTG0krcImyOb1uurTH37wlsEhZiI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787040853; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=EG267yheOu2tSkbJxa4TmhdayEAG7gC7xKGH2YTPTco=; b=WYVZONBzrc1k/CKOrJGHR5c1G18sxmzpq3Y2fyOdpHiydA8wG8DmKV9yfLKffRg7o66vp2XAUyPY1Tn6Wh1RrQZA4EfvrtVJuJ+M+CHNkbbXMQXQNG41bccUsQxh+iyuFmwaij7i6RWaauw+mW8bIzWPoBuLTNCUqQhEh3ZpmHY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1787040853230358.61859638594944; Tue, 18 Aug 2026 01:14:13 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id B2E4441833; Tue, 18 Aug 2026 04:14:11 -0400 (EDT) Received: from [172.19.199.13] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 3E50A3FAF9 for ; Tue, 18 Aug 2026 04:13:22 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id E09CC3F8ED; Tue, 18 Aug 2026 04:13:13 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 557EF3F96D for ; Tue, 18 Aug 2026 04:13:12 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-578-L32LKFUoNYamUdZJNCIntg-1; Tue, 18 Aug 2026 04:13:10 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8DB801956040 for ; Tue, 18 Aug 2026 08:13:09 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.24.9]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DB081180034F for ; Tue, 18 Aug 2026 08:13:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787040791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EG267yheOu2tSkbJxa4TmhdayEAG7gC7xKGH2YTPTco=; b=HOdDMgNQtR8U7kKgGtvvJaBNHBJMd9yRdk57gHVzSpedxW9OhSnDYz4CXPzjq5Tz5YkAO+ M3iJ86AjbregpplWe7RZi63R7Akwahh64/cNn+BFFGh/miW2PdLeJXuVoiufdyQiMjAtU7 ZtGt8FsCCnnJkjX1tQVgmL/rro1tTnI= X-MC-Unique: L32LKFUoNYamUdZJNCIntg-1 X-Mimecast-MFC-AGG-ID: L32LKFUoNYamUdZJNCIntg_1787040789 To: devel@lists.libvirt.org Subject: [PATCH] qemu: Fix proper ordering of 'virtlockd' shutdown Date: Tue, 18 Aug 2026 10:13:07 +0200 Message-ID: <1c3543d04910dd9a729d86d3d9c026635cb316cc.1787040787.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LvDQQs0BF2Ifkpf5Lep_GBO0oRzvOYJpLZpVguJSrA8_1787040789 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 5IJGDC5APAPO5LNPNJGD6MMB665FQZVX X-Message-ID-Hash: 5IJGDC5APAPO5LNPNJGD6MMB665FQZVX X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1787040853788158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa In commit aa1bf13b9caa4ef893cd4fdbaa111d5da73aa120 I attempted to fix the ordering of virtlockd and virtlogd during shutdown but I made a typo in the name of 'virtlockd.service' (missing 'd'). Fixes: aa1bf13b9caa4ef893cd4fdbaa111d5da73aa120 Signed-off-by: Peter Krempa Reviewed-by: Martin Kletzander Reviewed-by: Pavel Hrdina --- src/qemu/virtqemud.service.extra.in | 2 +- src/remote/libvirtd.service.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/virtqemud.service.extra.in b/src/qemu/virtqemud.servi= ce.extra.in index 3cc2edcfd0..df36890704 100644 --- a/src/qemu/virtqemud.service.extra.in +++ b/src/qemu/virtqemud.service.extra.in @@ -9,7 +9,7 @@ After=3Dvirtlockd.socket # To ensure that our helper daemons are not shut down before the main daem= on # shuts down we need also explicit ordering with the .service unit After=3Dvirtlogd.service -After=3Dvirtlock.service +After=3Dvirtlockd.service Wants=3Dsystemd-machined.service After=3Dsystemd-machined.service After=3Dremote-fs.target diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in index f26494d646..ccdb8379f3 100644 --- a/src/remote/libvirtd.service.in +++ b/src/remote/libvirtd.service.in @@ -18,7 +18,7 @@ After=3Dvirtlockd.socket # To ensure that our helper daemons are not shut down before the main daem= on # shuts down we need also explicit ordering with the .service unit After=3Dvirtlogd.service -After=3Dvirtlock.service +After=3Dvirtlockd.service Wants=3Dsystemd-machined.service After=3Dnetwork.target After=3Ddbus.service --=20 2.55.0