[v2] Add support for PCI IO using Qword resources

[edk2-devel] [PATCH v2 0/2] Add support for PCI IO using Qword resources

Posted by Jeff Brasen via groups.io 7 months, 1 week ago

Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit 
addresses can be used to generate I/O packets over the PCIe bus.

Changes:
v2 - Rebased and set transferEncoding = 8bit

Vidya Sagar (2):
  DynamicTablesPkg: AML Code generation for I/O ranges
  DynamicTablesPkg: AcpiSsdtPcieLibArm: Use QWord todescribe I/O range

 .../Include/Library/AmlLib/AmlLib.h           | 67 ++++++++++++++
 .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c    |  2 +-
 .../AmlLib/CodeGen/AmlResourceDataCodeGen.c   | 90 +++++++++++++++++++
 3 files changed, 158 insertions(+), 1 deletion(-)

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108969): https://edk2.groups.io/g/devel/message/108969
Mute This Topic: https://groups.io/mt/101508452/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/2] Add support for PCI IO using Qword resources

Posted by Sami Mujawar 7 months, 1 week ago

Hi Jeff,

Thank out for this patch series.

These changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


On 21/09/2023 09:10 pm, Jeff Brasen wrote:
> Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
> AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit
> addresses can be used to generate I/O packets over the PCIe bus.
>
> Changes:
> v2 - Rebased and set transferEncoding = 8bit
>
> Vidya Sagar (2):
>    DynamicTablesPkg: AML Code generation for I/O ranges
>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Use QWord todescribe I/O range
>
>   .../Include/Library/AmlLib/AmlLib.h           | 67 ++++++++++++++
>   .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c    |  2 +-
>   .../AmlLib/CodeGen/AmlResourceDataCodeGen.c   | 90 +++++++++++++++++++
>   3 files changed, 158 insertions(+), 1 deletion(-)
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108990): https://edk2.groups.io/g/devel/message/108990
Mute This Topic: https://groups.io/mt/101508452/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/2] Add support for PCI IO using Qword resources

Posted by PierreGondois 7 months, 1 week ago

Hi Jeff,

On 9/21/23 22:10, Jeff Brasen wrote:
> Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
> AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit
> addresses can be used to generate I/O packets over the PCIe bus.
> 
> Changes:
> v2 - Rebased and set transferEncoding = 8bit

The patches applied cleanly, thanks!

Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>

> 
> Vidya Sagar (2):
>    DynamicTablesPkg: AML Code generation for I/O ranges
>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Use QWord todescribe I/O range
> 
>   .../Include/Library/AmlLib/AmlLib.h           | 67 ++++++++++++++
>   .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c    |  2 +-
>   .../AmlLib/CodeGen/AmlResourceDataCodeGen.c   | 90 +++++++++++++++++++
>   3 files changed, 158 insertions(+), 1 deletion(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108987): https://edk2.groups.io/g/devel/message/108987
Mute This Topic: https://groups.io/mt/101508452/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-