From nobody Thu May 16 10:00:09 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108970+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1695327028953128.04119463026757; Thu, 21 Sep 2023 13:10:28 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=RSgYx3zUNduMeuJr50RkLZBe3JT4Mi/e0kpULDvFtXw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1695327028; v=1; b=NFrWfLUCJFJ6eriBfkFF2ZNV5lSCQ0/cbLfwUuqsOG/mJ3XeMekIdLtxFnP3wADBzyR8lcqY 4nZhqyeffca9tqvTf6bl1wHkKXeGhEE+HrX5k/BDoBo9FP/6T95cg70FBMR038E/D1GImXVqw8l v0kcvrtqFCtyB5avrCeYjXuk= X-Received: by 127.0.0.2 with SMTP id xJKVYY1788612xqb3RfH9fyY; Thu, 21 Sep 2023 13:10:28 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.53]) by mx.groups.io with SMTP id smtpd.web11.6002.1695327027864244081 for ; Thu, 21 Sep 2023 13:10:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JePHWILdsGB3RLy4n/oEUPeRHn61KfG99UFCvmiuE+hBkRx5omZ8QhxmWqgdNMLKToqyoAhzLSzVbIjuCDQGaT+Ek0gZubNri56vvmsbJpsS39cjOzcPJrWJbqIxXB18jFgK+3ASIFbRcmjuAOVR1+JK4qUHZLWeKrlv4PZ24B/qn/Z0uSqEe6CeaSZ7Vr12gtZGUQBvF5g5PBHtSyaww4E4p/ygb+mTQghZNoTeFLT6f70sFO5T8JaF8SQrDpzkb3e2W4rrth+desyjQqTvS0GRL3jJ/61/KNmBG3kZDwQYhBq5/t5KRhiJjle+ptS1X7zgA7Y8VxlKX5f3Jmtl4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TjXehPHFt1Ip+6lyhHb5SF5Qww3mKD1YeQO83+1pElQ=; b=dvyVGICbWXdsbl9iln9u3tTo5RWfG/OTwE8FveEbkpBZ5iBst7ABaRbCn1F3EZjLSKtXrEK79xP0qOm0smeFwXYg57KcO6F6lM9Ph97V1fzIrXdr8KS044axGtp7Mg+HWCX4m/5JnbShL5Y3usyiiNNyxyTW+vlKQ4bTHZe+K9Fs8fqZEp4xng3ZHEdHfsYu8JQ9jvyeAsoOejcq4yTLMty4xE88DVWktsHAHgMIPxosCz7YVKPu5UN+wgW8MA9CFycSBBCxtNKOMDU9ZiS9CXukh/VRF2HQ30TMgMFmietBLUY7Lt3mOnxBEmFYA4Z7bAwuP/vz71bb90/aHJf2PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from CH2PR08CA0015.namprd08.prod.outlook.com (2603:10b6:610:5a::25) by SN7PR12MB7021.namprd12.prod.outlook.com (2603:10b6:806:262::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.19; Thu, 21 Sep 2023 20:10:24 +0000 X-Received: from DS3PEPF000099D8.namprd04.prod.outlook.com (2603:10b6:610:5a:cafe::f) by CH2PR08CA0015.outlook.office365.com (2603:10b6:610:5a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.31 via Frontend Transport; Thu, 21 Sep 2023 20:10:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108970+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.160) by DS3PEPF000099D8.mail.protection.outlook.com (10.167.17.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.20 via Frontend Transport; Thu, 21 Sep 2023 20:10:24 +0000 X-Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 21 Sep 2023 13:10:09 -0700 X-Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 21 Sep 2023 13:10:09 -0700 X-Received: from a91351b90548.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.986.41 via Frontend Transport; Thu, 21 Sep 2023 13:10:08 -0700 From: "Jeff Brasen via groups.io" To: CC: , , , , Vidya Sagar , Jeff Brasen Subject: [edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: AML Code generation for I/O ranges Date: Thu, 21 Sep 2023 20:10:04 +0000 Message-ID: <3d2ed45691dc73aff43de1351ebb965694c3c51f.1695326850.git.jbrasen@nvidia.com> In-Reply-To: References: MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099D8:EE_|SN7PR12MB7021:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ffa674d-d27d-47fb-f556-08dbbadeca71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: yz2grSPI5RKQMFNYTyejXbM16EnEMhHyFE76yw6CbSyWuXM5fTmHnKuSNWn6aG/Q85PotLIIgeljHRmneItdTOAO9EugWCrPbB3+K7v3hWu1hDmvYo3j6+P0tyC465PsTvJj3lTOU1FFOgupbIDs0GcN1AlG3RNfiAe4jRoPydUUutBEWUdwZTBkgPTTTqNSX1RxfdvQ7nIjXBcOvZ3apSslZCHHCChZfnyRyUS/bKENRU3OhqMTZxwK56n1vC1A6JXr34md08xS1bvqE87bMpV/DHaxxhfxr3wlea9+SOkcndT/m5CYKaeULPhmQ5XiyNwna36KIC0NlijgA+//IaMlkFD2l2/MpoXgjprgV3hlWRhnklpWXbuDSz6xo6YHFQqrU93/6AgBsqCqGMMtWc7VSP879WlbvjHYJUyD4QW6yCXmQn4sF/cYWSuCCFL9akRLP8rK6ERRe9KBCueYxKLfRvb9mlbdXpHxkYhMuEmRLxoyg82oNY5seZLYeE2Z9MYDcRWnqltfhevl7S1mHozjuYtzEKDG3UgZhJrCFS3lr5VEmYaAljpv9yfeNbPH3zNFNYJRLqTFynsbCu2XV4kcnXAGXzBZQ1MqLg7D60B7MVspFytUdMpFlLKoUkkr/WbeA85XLlQMSNpETMCc7UUZSy6kh0FKW2qjkZl4d9y7+stXghdxHTrJx3M7AngAISnOrzyzMAsJ0mud9/KDxGT1o52SZHdLxwmJNyPiQlQ/UcB4StkVjwZq1OLx0i9/IA0Sq9AdcaqVewh2AP+Abg== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 20:10:24.3466 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7ffa674d-d27d-47fb-f556-08dbbadeca71 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099D8.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7021 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jbrasen@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Wxw0LyIuTCI8taNC3XR7Cv7wx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1695327029891100001 Content-Type: text/plain; charset="utf-8" From: Vidya Sagar Add helper functions to generate AML Resource Data describing I/O ranges of four words long. API AmlCodeGenRdQWordIo () is exposed. Signed-off-by: Jeff Brasen Reviewed-by: Pierre Gondois Reviewed-by: Sami Mujawar --- .../Include/Library/AmlLib/AmlLib.h | 67 ++++++++++++++ .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 90 +++++++++++++++++++ 2 files changed, 157 insertions(+) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index 9210c5091548..8e24cecdd77b 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -683,6 +683,73 @@ AmlCodeGenRdWordBusNumber ( OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL ); =20 +/** Code generation for the "QWordIO ()" ASL function. + + The Resource Data effectively created is a QWord Address Space Resource + Data. Cf ACPI 6.4: + - s6.4.3.5.1 "QWord Address Space Descriptor". + - s19.6.109 "QWordIO". + + The created resource data node can be: + - appended to the list of resource data elements of the NameOpNode. + In such case NameOpNode must be defined by a the "Name ()" ASL statem= ent + and initially contain a "ResourceTemplate ()". + - returned through the NewRdNode parameter. + + See ACPI 6.4 spec, s19.6.109 for more. + + @param [in] IsResourceConsumer ResourceUsage parameter. + @param [in] IsMinFixed Minimum address is fixed. + @param [in] IsMaxFixed Maximum address is fixed. + @param [in] IsPosDecode Decode parameter + @param [in] IsaRanges Possible values are: + 0-Reserved + 1-NonISAOnly + 2-ISAOnly + 3-EntireRange + @param [in] AddressGranularity Address granularity. + @param [in] AddressMinimum Minimum address. + @param [in] AddressMaximum Maximum address. + @param [in] AddressTranslation Address translation. + @param [in] RangeLength Range length. + @param [in] ResourceSourceIndex Resource Source index. + Unused. Must be 0. + @param [in] ResourceSource Resource Source. + Unused. Must be NULL. + @param [in] IsDenseTranslation TranslationDensity parameter. + @param [in] IsTypeStatic TranslationType parameter. + @param [in] NameOpNode NameOp object node defining a named ob= ject. + If provided, append the new resource d= ata + node to the list of resource data elem= ents + of this node. + @param [out] NewRdNode If provided and success, + contain the created node. + + @retval EFI_SUCCESS The function completed successfully. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Could not allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenRdQWordIo ( + IN BOOLEAN IsResourceConsumer, + IN BOOLEAN IsMinFixed, + IN BOOLEAN IsMaxFixed, + IN BOOLEAN IsPosDecode, + IN UINT8 IsaRanges, + IN UINT64 AddressGranularity, + IN UINT64 AddressMinimum, + IN UINT64 AddressMaximum, + IN UINT64 AddressTranslation, + IN UINT64 RangeLength, + IN UINT8 ResourceSourceIndex, + IN CONST CHAR8 *ResourceSource, + IN BOOLEAN IsDenseTranslation, + IN BOOLEAN IsTypeStatic, + IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL + OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL + ); + /** Code generation for the "QWordMemory ()" ASL function. =20 The Resource Data effectively created is a QWord Address Space Resource diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceData= CodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC= odeGen.c index 4ca63ccd2396..9c6700b9e08c 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c @@ -1012,6 +1012,96 @@ AmlCodeGenRdQWordSpace ( return LinkRdNode (RdNode, NameOpNode, NewRdNode); } =20 +/** Code generation for the "QWordIO ()" ASL function. + + The Resource Data effectively created is a QWord Address Space Resource + Data. Cf ACPI 6.4: + - s6.4.3.5.1 "QWord Address Space Descriptor". + - s19.6.109 "QWordIO". + + The created resource data node can be: + - appended to the list of resource data elements of the NameOpNode. + In such case NameOpNode must be defined by a the "Name ()" ASL statem= ent + and initially contain a "ResourceTemplate ()". + - returned through the NewRdNode parameter. + + See ACPI 6.4 spec, s19.6.109 for more. + + @param [in] IsResourceConsumer ResourceUsage parameter. + @param [in] IsMinFixed Minimum address is fixed. + @param [in] IsMaxFixed Maximum address is fixed. + @param [in] IsPosDecode Decode parameter + @param [in] IsaRanges Possible values are: + 0-Reserved + 1-NonISAOnly + 2-ISAOnly + 3-EntireRange + @param [in] AddressGranularity Address granularity. + @param [in] AddressMinimum Minimum address. + @param [in] AddressMaximum Maximum address. + @param [in] AddressTranslation Address translation. + @param [in] RangeLength Range length. + @param [in] ResourceSourceIndex Resource Source index. + Unused. Must be 0. + @param [in] ResourceSource Resource Source. + Unused. Must be NULL. + @param [in] IsDenseTranslation TranslationDensity parameter. + @param [in] IsTypeStatic TranslationType parameter. + @param [in] NameOpNode NameOp object node defining a named ob= ject. + If provided, append the new resource d= ata + node to the list of resource data elem= ents + of this node. + @param [out] NewRdNode If provided and success, + contain the created node. + + @retval EFI_SUCCESS The function completed successfully. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Could not allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenRdQWordIo ( + IN BOOLEAN IsResourceConsumer, + IN BOOLEAN IsMinFixed, + IN BOOLEAN IsMaxFixed, + IN BOOLEAN IsPosDecode, + IN UINT8 IsaRanges, + IN UINT64 AddressGranularity, + IN UINT64 AddressMinimum, + IN UINT64 AddressMaximum, + IN UINT64 AddressTranslation, + IN UINT64 RangeLength, + IN UINT8 ResourceSourceIndex, + IN CONST CHAR8 *ResourceSource, + IN BOOLEAN IsDenseTranslation, + IN BOOLEAN IsTypeStatic, + IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL + OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL + ) +{ + return AmlCodeGenRdQWordSpace ( + ACPI_ADDRESS_SPACE_TYPE_IO, + IsResourceConsumer, + IsPosDecode, + IsMinFixed, + IsMaxFixed, + RdIoRangeSpecificFlags ( + IsaRanges, + IsDenseTranslation, + IsTypeStatic + ), + AddressGranularity, + AddressMinimum, + AddressMaximum, + AddressTranslation, + RangeLength, + ResourceSourceIndex, + ResourceSource, + NameOpNode, + NewRdNode + ); +} + /** Code generation for the "QWordMemory ()" ASL function. =20 The Resource Data effectively created is a QWord Address Space Resource --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108970): https://edk2.groups.io/g/devel/message/108970 Mute This Topic: https://groups.io/mt/101508458/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 16 10:00:09 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108971+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1695327029891113.80707719903398; Thu, 21 Sep 2023 13:10:29 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=inADTQZHFc9Ekfys7k/Gq3r25JM4+T2ehPqf69I7ocU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1695327029; v=1; b=i6ii0HQkUppZtW/HZdfIbJwU+Cvs+kcCkYeCJVn1wwqgU2tojX+lcfvPMMhJ9Anrh8wKE9cV tCjJxPRUAQCXJyhr8toaTIbqrC/UKXpEw+QogSxOvrXfP8gLNJBz/J3DTaQ/274CW7CK69BiwKs e8Dau4mpLPeDTZGF7f/S/aN4= X-Received: by 127.0.0.2 with SMTP id 8Z24YY1788612xvA4tcukkj1; Thu, 21 Sep 2023 13:10:29 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.71]) by mx.groups.io with SMTP id smtpd.web10.5867.1695327028470885307 for ; Thu, 21 Sep 2023 13:10:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=crwuwOyp5c3S8TeKep7OWK7bEuwg4HvsiCbKobYoPgAAHejkVKGV4qvpE8rbG7Zu6re4QYxIIUnLiw6CMzbPw9IByOK+o6TSWt0yFx8JyuABnizZnzNcybLN3SzjxGq3wDaKGBJuvGa0AmHuNKk9jwiHYYhSdODnZM+QMOVpn9X1OaUFWDHmkCdLx3D6v7pOSB+xINgtkK2v4Keqiz2epPxh1pqi4c3NAPCupf8Gxjn3MnCh2WXIRPzxYXjW6vkbGN7v9X1aFtNGaW1qVV2LMHLMo8doO7M7gQ4CC3ra+7k0tSDl5GewbZ9R/Q4qRx8ax6b/bHhq4HMUg9Sj3RW6Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lD8iD+rsnqdDvJ97LA26MWumA7a32S9EBQ7klrCIDwc=; b=Gyv12uHOvOZ58Zdw3aTwyooKmxckakzovSgBA+8ztqj8L3WU2T5ynf+swMFYbGNlHK/Ed664rnBJ9nrfaVRGu0TCGhtlRViUe0cypHYlv/lmV3OHXgBtwMMjcVoZqwy+SU6cu/6ZayyX201mtOTPCnP/8LPqchmN3I1VWmpG5AYQ5LeVqiPkX9xvIerdHks0lh07svvgsAE2Z5mVbH2yS20+UiCxA/45Ukyyu0XSfUk5sl78vex2IqNbvnzhTwx9ctQwGWfdMYaYJhDUbUUS2/1eFLFfXPAg6XLhKYGzMLTrNOM1AIgXwD3IZYPNsptc01Es7vWhPIzgI4E9RXOUgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from DM6PR02CA0154.namprd02.prod.outlook.com (2603:10b6:5:332::21) by DS0PR12MB6390.namprd12.prod.outlook.com (2603:10b6:8:ce::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.26; Thu, 21 Sep 2023 20:10:26 +0000 X-Received: from DS3PEPF000099D4.namprd04.prod.outlook.com (2603:10b6:5:332:cafe::80) by DM6PR02CA0154.outlook.office365.com (2603:10b6:5:332::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.31 via Frontend Transport; Thu, 21 Sep 2023 20:10:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108971+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.160) by DS3PEPF000099D4.mail.protection.outlook.com (10.167.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.20 via Frontend Transport; Thu, 21 Sep 2023 20:10:25 +0000 X-Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 21 Sep 2023 13:10:10 -0700 X-Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 21 Sep 2023 13:10:10 -0700 X-Received: from a91351b90548.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.986.41 via Frontend Transport; Thu, 21 Sep 2023 13:10:09 -0700 From: "Jeff Brasen via groups.io" To: CC: , , , , Vidya Sagar , Jeff Brasen Subject: [edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: AcpiSsdtPcieLibArm: Use QWord todescribe I/O range Date: Thu, 21 Sep 2023 20:10:05 +0000 Message-ID: <86f4a2e47b2988276db70c6a9a11f1414baf7efd.1695326850.git.jbrasen@nvidia.com> In-Reply-To: References: MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099D4:EE_|DS0PR12MB6390:EE_ X-MS-Office365-Filtering-Correlation-Id: 979f7460-bd19-4bb3-9d1a-08dbbadecb60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 5F3KW4AcWTXfWMtstGJvo3R2pJkQa6h7H2p0CIU7J5/ggvN0gLZl865EZOZtCUuaLSeBjv4seorcEgtiCAJx/gq1jg2QXhWgwgWh/7Bul2PwehsWgybL9RCL6sf5Qucl3OpypZ7rVM6Khus/bLwKfjL4+SN/ZTtFINhKK32uWfR/06i8j+H5jyAa2vICYQrM8xXr4LfQuftTBjV5e4VarN9cjYgRWbcqlnkB0hPCwvl+dh75TVFCQDPRV4pOeCVBGLQO/N0jqhwrtrbFYpbmG/g/72WpNZ6Uidti/AqCLtlbRs/kVVWldm9Z+UM4ckDW7/f6soRpL9z+CduBRAAJZt7kvVtaIeibROBXnGOkEHqelNinJts2C160CBbkD5Ah5rWVR/GWu6QnmzZ4B5+icNegXOmDKmEaVFh5oV1bdYwaPjAm12BcqolTmYxIJlhhyztO2UMRwQKWJQRVROD84zjEmafTqFaW88e5i7kl6eDjUYvROkw1O3PpeK8h2m2OIoxmQ8SKN5sZBL5eZNEBGmPYCY1W0OO4tEKnNezbS3DRkTU3NUu1rFul9vp8gfZiKWqT3hmJzso/FlkV8vx/71PTHcvYJImFgVr2vbiodaSUEFrve5tmX65xEh3o1zm6NTJ77ByzlOYNC50wNyvLm33lBc3Qhebj+eNPrY/fXnNMOXMhhJJapmGDGDkEdm9w2SpY8tO3QY3tUmbtlGFJtl7t6Dqb5PXTo6jz6kp7TDhHP9AqPyT2uU/vEWdzAPmmOr+vCZSurj/cfVs9vxN/1dDdbKf9L9AmrKA4hGRfNQCC+HFWyaaX+3G9SFYRCwn6 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 20:10:25.9263 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 979f7460-bd19-4bb3-9d1a-08dbbadecb60 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099D4.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6390 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jbrasen@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NZ3vVcg553J5MvWHw5ZvjqICx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1695327030740100005 Content-Type: text/plain; charset="utf-8" From: Vidya Sagar Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit addresses can be used to generate I/O packets over the PCIe bus. Signed-off-by: Jeff Brasen Reviewed-by: Pierre Gondois Reviewed-by: Sami Mujawar --- .../Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieG= enerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieG= enerator.c index c54ae6f551f6..9ddaddc198fa 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerato= r.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerato= r.c @@ -540,7 +540,7 @@ GeneratePciCrs ( =20 switch (AddrMapInfo->SpaceCode) { case PCI_SS_IO: - Status =3D AmlCodeGenRdDWordIo ( + Status =3D AmlCodeGenRdQWordIo ( FALSE, TRUE, TRUE, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108971): https://edk2.groups.io/g/devel/message/108971 Mute This Topic: https://groups.io/mt/101508459/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-