From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>

Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.

Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 Maintainers.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 747191366070..bb8ab643e090 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
 M: Ard Biesheuvel <ardb+tianocore@kernel.org>
 M: Leif Lindholm <quic_llindhol@quicinc.com>
 
+AMD Platform
+F: Platform/AMD/BoardPkg
+F: Platform/AMD/PlatformPkg
+M: Abner Chang <abner.chang@amd.com>
+M: Abdul Lateef Attar <abdattar@amd.com>
+
 Ampere Computing
 F: Platform/Ampere
 F: Silicon/Ampere
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101312): https://edk2.groups.io/g/devel/message/101312
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> 
> Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> 
> Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 747191366070..bb8ab643e090 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
>  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
>  M: Leif Lindholm <quic_llindhol@quicinc.com>
>  
> +AMD Platform

Annoyingly, I'm now going to ask the question I have been avoiding up
until now. What does "AMD Platform" mean?
I mean, you've placed this straight after the entry for the Seattle
platforms.
I think the name, and package names, are too generic.

/
    Leif

> +F: Platform/AMD/BoardPkg
> +F: Platform/AMD/PlatformPkg
> +M: Abner Chang <abner.chang@amd.com>
> +M: Abdul Lateef Attar <abdattar@amd.com>
> +
>  Ampere Computing
>  F: Platform/Ampere
>  F: Silicon/Ampere
> -- 
> 2.25.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101355): https://edk2.groups.io/g/devel/message/101355
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[AMD Official Use Only - General]

Hi Leif,
How about adding a separate entry?
Currently its generic to adapt the MinPlatformPkg, later will add more specific platforms.

AMD board and platform
F: Platform/AMD/BoardPkg
F: Platform/AMD/PlatformPkg
M: maintainer1
M: maintainer2

AMD Seattle
F: Platform/AMD/OverdriveBoard/
F: Platform/LeMaker/CelloBoard/
F: Platform/SoftIron/
F: Silicon/AMD/Styx/
M: Ard Biesheuvel <ardb+tianocore@kernel.org>
M: Leif Lindholm <quic_llindhol@quicinc.com>

Thanks
AbduL

-----Original Message-----
From: Leif Lindholm <quic_llindhol@quicinc.com>
Sent: 17 March 2023 21:39
To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>; Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
>
> Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
>
> Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt index
> 747191366070..bb8ab643e090 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
>  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
>  M: Leif Lindholm <quic_llindhol@quicinc.com>
>
> +AMD Platform

Annoyingly, I'm now going to ask the question I have been avoiding up until now. What does "AMD Platform" mean?
I mean, you've placed this straight after the entry for the Seattle platforms.
I think the name, and package names, are too generic.

/
    Leif

> +F: Platform/AMD/BoardPkg
> +F: Platform/AMD/PlatformPkg
> +M: Abner Chang <abner.chang@amd.com>
> +M: Abdul Lateef Attar <abdattar@amd.com>
> +
>  Ampere Computing
>  F: Platform/Ampere
>  F: Silicon/Ampere
> --
> 2.25.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101455): https://edk2.groups.io/g/devel/message/101455
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[AMD Official Use Only - General]

BTW Leif,
I don't see any modules under OverdriveBoard, is this package still in use? Do you still remember where is FDF and DSC come from (as there is AMD copyright 2014-2016) back to the moment when you was introduced this package?

Thanks
Abner

> -----Original Message-----
> From: Leif Lindholm <quic_llindhol@quicinc.com>
> Sent: Saturday, March 18, 2023 12:09 AM
> To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
> <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>;
> Michael D Kinney <michael.d.kinney@intel.com>
> Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg
> and AMD/PlatformPkg maintainers
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> >
> > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> >
> > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >  Maintainers.txt | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt index
> > 747191366070..bb8ab643e090 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
> >  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> >  M: Leif Lindholm <quic_llindhol@quicinc.com>
> >
> > +AMD Platform
> 
> Annoyingly, I'm now going to ask the question I have been avoiding up until
> now. What does "AMD Platform" mean?
> I mean, you've placed this straight after the entry for the Seattle platforms.
> I think the name, and package names, are too generic.
> 
> /
>     Leif
> 
> > +F: Platform/AMD/BoardPkg
> > +F: Platform/AMD/PlatformPkg
> > +M: Abner Chang <abner.chang@amd.com>
> > +M: Abdul Lateef Attar <abdattar@amd.com>
> > +
> >  Ampere Computing
> >  F: Platform/Ampere
> >  F: Silicon/Ampere
> > --
> > 2.25.1
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101361): https://edk2.groups.io/g/devel/message/101361
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Abner,

On Sat, Mar 18, 2023 at 09:16:17 +0000, Chang, Abner via groups.io wrote:
> I don't see any modules under OverdriveBoard, is this package still

The code is split between Platform/AMD and Silicon/AMD/Styx, the
latter also being used by SoftIron/Overdrive1000 and LeMaker Cello
(although that one is pretty much defunct and should probably be
dropped).

> in use? Do you still remember where is FDF and DSC come from (as
> there is AMD copyright 2014-2016) back to the moment when you was
> introduced this package?

As the git history tells you:
---
commit f4d38e50c0f24eb78eb003a94f583025621c63db
Author: Leif Lindholm <leif.lindholm@linaro.org>
Date:   Thu Aug 3 12:24:22 2017 +0100

    Platform,Silicon: import AMD Styx SoC support and platforms

    Common files for AMD Overdrive, SoftIron Overdrive 1000
    and LeMaker Cello, as well as actual platform support.
    Imported from commit efd798c1eb of
    https://git.linaro.org/uefi/OpenPlatformPkg.git
---

and the initial commit of the platform in that repository is:
---
From: Leo Duran <leo.duran@amd.com>
Date: Thu, 20 Aug 2015 13:30:24 -0500

    Subject: Platforms/AMD: add support for AMD Overdrive and Lemaker Cello

    This adds support for the AMD Seattle based Overdrive and Husky
    platforms,
    and the Lemaker Cello which is derived from it.

    This code was tested with upstream EDK2 commit 758ea94651.

    The binaries in this branch are based on SeattleFDK 1.0.0.2
    (Linaro SeattleFDK commit 4b419f2ef2)
---

Regards,

Leif

> 
> Thanks
> Abner
> 
> > -----Original Message-----
> > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > Sent: Saturday, March 18, 2023 12:09 AM
> > To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
> > <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> > <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>;
> > Michael D Kinney <michael.d.kinney@intel.com>
> > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg
> > and AMD/PlatformPkg maintainers
> > 
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> > 
> > 
> > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > >
> > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> > >
> > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > ---
> > >  Maintainers.txt | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Maintainers.txt b/Maintainers.txt index
> > > 747191366070..bb8ab643e090 100644
> > > --- a/Maintainers.txt
> > > +++ b/Maintainers.txt
> > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
> > >  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > >  M: Leif Lindholm <quic_llindhol@quicinc.com>
> > >
> > > +AMD Platform
> > 
> > Annoyingly, I'm now going to ask the question I have been avoiding up until
> > now. What does "AMD Platform" mean?
> > I mean, you've placed this straight after the entry for the Seattle platforms.
> > I think the name, and package names, are too generic.
> > 
> > /
> >     Leif
> > 
> > > +F: Platform/AMD/BoardPkg
> > > +F: Platform/AMD/PlatformPkg
> > > +M: Abner Chang <abner.chang@amd.com>
> > > +M: Abdul Lateef Attar <abdattar@amd.com>
> > > +
> > >  Ampere Computing
> > >  F: Platform/Ampere
> > >  F: Silicon/Ampere
> > > --
> > > 2.25.1
> > >
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101435): https://edk2.groups.io/g/devel/message/101435
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[Public]

Hi Leif,

AMD/BoardPkg will contains the modules/drivers to support MinPlatformPkg framework.
   BoardPkg will be generic across all AMD boards which are based on MinPlatformPkg framework.
   It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg".
   We will gradually add modules and libraries to it.

AMD/PlatformPkg will contain the modules/drivers which are generic to future AMD platform.
   Currently we don't have complete platform, we can drop PlatformPkg for now till we have complete(reasonable modules) solution.

It's better to not touch existing AMD/OverdriveBoard, restructuring requires changes to .dsc and .fdf files, might break backward compatibility.

How about having just BoardPkg like below?

AMD board package
F: Platform/AMD/BoardPkg
M: Maintainer1
M: Maintainer2

Please let me know your thoughts.

Thanks
AbduL




-----Original Message-----
From: Leif Lindholm <quic_llindhol@quicinc.com>
Sent: 20 March 2023 18:35
To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


Hi Abner,

On Sat, Mar 18, 2023 at 09:16:17 +0000, Chang, Abner via groups.io wrote:
> I don't see any modules under OverdriveBoard, is this package still

The code is split between Platform/AMD and Silicon/AMD/Styx, the latter also being used by SoftIron/Overdrive1000 and LeMaker Cello (although that one is pretty much defunct and should probably be dropped).

> in use? Do you still remember where is FDF and DSC come from (as there
> is AMD copyright 2014-2016) back to the moment when you was introduced
> this package?

As the git history tells you:
---
commit f4d38e50c0f24eb78eb003a94f583025621c63db
Author: Leif Lindholm <leif.lindholm@linaro.org>
Date:   Thu Aug 3 12:24:22 2017 +0100

    Platform,Silicon: import AMD Styx SoC support and platforms

    Common files for AMD Overdrive, SoftIron Overdrive 1000
    and LeMaker Cello, as well as actual platform support.
    Imported from commit efd798c1eb of
    https://git.linaro.org/uefi/OpenPlatformPkg.git
---

and the initial commit of the platform in that repository is:
---
From: Leo Duran <leo.duran@amd.com>
Date: Thu, 20 Aug 2015 13:30:24 -0500

    Subject: Platforms/AMD: add support for AMD Overdrive and Lemaker Cello

    This adds support for the AMD Seattle based Overdrive and Husky
    platforms,
    and the Lemaker Cello which is derived from it.

    This code was tested with upstream EDK2 commit 758ea94651.

    The binaries in this branch are based on SeattleFDK 1.0.0.2
    (Linaro SeattleFDK commit 4b419f2ef2)
---

Regards,

Leif

>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > Sent: Saturday, March 18, 2023 12:09 AM
> > To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
> > <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> > <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>;
> > Michael D Kinney <michael.d.kinney@intel.com>
> > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> > AMD/BoardPkg and AMD/PlatformPkg maintainers
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > >
> > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> > >
> > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > ---
> > >  Maintainers.txt | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Maintainers.txt b/Maintainers.txt index
> > > 747191366070..bb8ab643e090 100644
> > > --- a/Maintainers.txt
> > > +++ b/Maintainers.txt
> > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
> > >  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > >  M: Leif Lindholm <quic_llindhol@quicinc.com>
> > >
> > > +AMD Platform
> >
> > Annoyingly, I'm now going to ask the question I have been avoiding
> > up until now. What does "AMD Platform" mean?
> > I mean, you've placed this straight after the entry for the Seattle platforms.
> > I think the name, and package names, are too generic.
> >
> > /
> >     Leif
> >
> > > +F: Platform/AMD/BoardPkg
> > > +F: Platform/AMD/PlatformPkg
> > > +M: Abner Chang <abner.chang@amd.com>
> > > +M: Abdul Lateef Attar <abdattar@amd.com>
> > > +
> > >  Ampere Computing
> > >  F: Platform/Ampere
> > >  F: Silicon/Ampere
> > > --
> > > 2.25.1
> > >
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101456): https://edk2.groups.io/g/devel/message/101456
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Abdul,

On Mon, Mar 20, 2023 at 14:09:11 +0000, Attar, AbdulLateef (Abdul Lateef) wrote:
> AMD/BoardPkg will contains the modules/drivers to support MinPlatformPkg framework.
>    BoardPkg will be generic across all AMD boards which are based on MinPlatformPkg framework.
>    It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg".
>    We will gradually add modules and libraries to it.

So, if the purpose is exclusively to support MinPlatformPkg platforms,
I think that should be part of the name.
Like Platform/AMD/AmdMinPlatformPkg (for example).

> AMD/PlatformPkg will contain the modules/drivers which are generic to future AMD platform.
>    Currently we don't have complete platform, we can drop
>    PlatformPkg for now till we have complete(reasonable modules)
>    solution.

It will certainly be easier to reason about what the preferred
naming/layout should be once there is code to look at for examples.
It may be that parts of it would live more naturally under
Silicon/AMD, for example.

> It's better to not touch existing AMD/OverdriveBoard, restructuring
> requires changes to .dsc and .fdf files, might break backward
> compatibility.

No problem. Config files occasionally need to be revamped, but that's
simply a mechanical exercise.

> How about having just BoardPkg like below?

That, too, is a completely generic name that conveys no information
about *what* boards one can expect to find in there.

Regards,

Leif

> AMD board package
> F: Platform/AMD/BoardPkg
> M: Maintainer1
> M: Maintainer2
> 
> Please let me know your thoughts.
> 
> Thanks
> AbduL
> 
> 
> 
> 
> -----Original Message-----
> From: Leif Lindholm <quic_llindhol@quicinc.com>
> Sent: 20 March 2023 18:35
> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
> Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers
> 
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Abner,
> 
> On Sat, Mar 18, 2023 at 09:16:17 +0000, Chang, Abner via groups.io wrote:
> > I don't see any modules under OverdriveBoard, is this package still
> 
> The code is split between Platform/AMD and Silicon/AMD/Styx, the latter also being used by SoftIron/Overdrive1000 and LeMaker Cello (although that one is pretty much defunct and should probably be dropped).
> 
> > in use? Do you still remember where is FDF and DSC come from (as there
> > is AMD copyright 2014-2016) back to the moment when you was introduced
> > this package?
> 
> As the git history tells you:
> ---
> commit f4d38e50c0f24eb78eb003a94f583025621c63db
> Author: Leif Lindholm <leif.lindholm@linaro.org>
> Date:   Thu Aug 3 12:24:22 2017 +0100
> 
>     Platform,Silicon: import AMD Styx SoC support and platforms
> 
>     Common files for AMD Overdrive, SoftIron Overdrive 1000
>     and LeMaker Cello, as well as actual platform support.
>     Imported from commit efd798c1eb of
>     https://git.linaro.org/uefi/OpenPlatformPkg.git
> ---
> 
> and the initial commit of the platform in that repository is:
> ---
> From: Leo Duran <leo.duran@amd.com>
> Date: Thu, 20 Aug 2015 13:30:24 -0500
> 
>     Subject: Platforms/AMD: add support for AMD Overdrive and Lemaker Cello
> 
>     This adds support for the AMD Seattle based Overdrive and Husky
>     platforms,
>     and the Lemaker Cello which is derived from it.
> 
>     This code was tested with upstream EDK2 commit 758ea94651.
> 
>     The binaries in this branch are based on SeattleFDK 1.0.0.2
>     (Linaro SeattleFDK commit 4b419f2ef2)
> ---
> 
> Regards,
> 
> Leif
> 
> >
> > Thanks
> > Abner
> >
> > > -----Original Message-----
> > > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > > Sent: Saturday, March 18, 2023 12:09 AM
> > > To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> > > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
> > > <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> > > <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>;
> > > Michael D Kinney <michael.d.kinney@intel.com>
> > > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> > > AMD/BoardPkg and AMD/PlatformPkg maintainers
> > >
> > > Caution: This message originated from an External Source. Use proper
> > > caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> > > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > > >
> > > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> > > >
> > > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > ---
> > > >  Maintainers.txt | 6 ++++++
> > > >  1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/Maintainers.txt b/Maintainers.txt index
> > > > 747191366070..bb8ab643e090 100644
> > > > --- a/Maintainers.txt
> > > > +++ b/Maintainers.txt
> > > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
> > > >  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > >  M: Leif Lindholm <quic_llindhol@quicinc.com>
> > > >
> > > > +AMD Platform
> > >
> > > Annoyingly, I'm now going to ask the question I have been avoiding
> > > up until now. What does "AMD Platform" mean?
> > > I mean, you've placed this straight after the entry for the Seattle platforms.
> > > I think the name, and package names, are too generic.
> > >
> > > /
> > >     Leif
> > >
> > > > +F: Platform/AMD/BoardPkg
> > > > +F: Platform/AMD/PlatformPkg
> > > > +M: Abner Chang <abner.chang@amd.com>
> > > > +M: Abdul Lateef Attar <abdattar@amd.com>
> > > > +
> > > >  Ampere Computing
> > > >  F: Platform/Ampere
> > > >  F: Silicon/Ampere
> > > > --
> > > > 2.25.1
> > > >
> >
> >
> > 
> >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101458): https://edk2.groups.io/g/devel/message/101458
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[AMD Official Use Only - General]

Hi Leif,
        AMD/BoardPkg will implements modules specific to boards(one or more motherboards).
It will not contain any module specific to Platform or Silicon, which are part of MinPlatformPkg.

How about just Min prefix?
AMD/MinBoardPkg (I am avoiding the Amd prefix because its already in AMD folder).

AMD board package for MinPlatformPkg
 F: Platform/AMD/MinBoardPkg
 M: Maintainer1
 M: Maintainer2

Thanks
AbduL

-----Original Message-----
From: Leif Lindholm <quic_llindhol@quicinc.com>
Sent: 20 March 2023 23:33
To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
Cc: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


Hi Abdul,

On Mon, Mar 20, 2023 at 14:09:11 +0000, Attar, AbdulLateef (Abdul Lateef) wrote:
> AMD/BoardPkg will contains the modules/drivers to support MinPlatformPkg framework.
>    BoardPkg will be generic across all AMD boards which are based on MinPlatformPkg framework.
>    It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg".
>    We will gradually add modules and libraries to it.

So, if the purpose is exclusively to support MinPlatformPkg platforms, I think that should be part of the name.
Like Platform/AMD/AmdMinPlatformPkg (for example).

> AMD/PlatformPkg will contain the modules/drivers which are generic to future AMD platform.
>    Currently we don't have complete platform, we can drop
>    PlatformPkg for now till we have complete(reasonable modules)
>    solution.

It will certainly be easier to reason about what the preferred naming/layout should be once there is code to look at for examples.
It may be that parts of it would live more naturally under Silicon/AMD, for example.

> It's better to not touch existing AMD/OverdriveBoard, restructuring
> requires changes to .dsc and .fdf files, might break backward
> compatibility.

No problem. Config files occasionally need to be revamped, but that's simply a mechanical exercise.

> How about having just BoardPkg like below?

That, too, is a completely generic name that conveys no information about *what* boards one can expect to find in there.

Regards,

Leif

> AMD board package
> F: Platform/AMD/BoardPkg
> M: Maintainer1
> M: Maintainer2
>
> Please let me know your thoughts.
>
> Thanks
> AbduL
>
>
>
>
> -----Original Message-----
> From: Leif Lindholm <quic_llindhol@quicinc.com>
> Sent: 20 March 2023 18:35
> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
> Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> AMD/BoardPkg and AMD/PlatformPkg maintainers
>
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> Hi Abner,
>
> On Sat, Mar 18, 2023 at 09:16:17 +0000, Chang, Abner via groups.io wrote:
> > I don't see any modules under OverdriveBoard, is this package still
>
> The code is split between Platform/AMD and Silicon/AMD/Styx, the latter also being used by SoftIron/Overdrive1000 and LeMaker Cello (although that one is pretty much defunct and should probably be dropped).
>
> > in use? Do you still remember where is FDF and DSC come from (as
> > there is AMD copyright 2014-2016) back to the moment when you was
> > introduced this package?
>
> As the git history tells you:
> ---
> commit f4d38e50c0f24eb78eb003a94f583025621c63db
> Author: Leif Lindholm <leif.lindholm@linaro.org>
> Date:   Thu Aug 3 12:24:22 2017 +0100
>
>     Platform,Silicon: import AMD Styx SoC support and platforms
>
>     Common files for AMD Overdrive, SoftIron Overdrive 1000
>     and LeMaker Cello, as well as actual platform support.
>     Imported from commit efd798c1eb of
>     https://git.linaro.org/uefi/OpenPlatformPkg.git
> ---
>
> and the initial commit of the platform in that repository is:
> ---
> From: Leo Duran <leo.duran@amd.com>
> Date: Thu, 20 Aug 2015 13:30:24 -0500
>
>     Subject: Platforms/AMD: add support for AMD Overdrive and Lemaker
> Cello
>
>     This adds support for the AMD Seattle based Overdrive and Husky
>     platforms,
>     and the Lemaker Cello which is derived from it.
>
>     This code was tested with upstream EDK2 commit 758ea94651.
>
>     The binaries in this branch are based on SeattleFDK 1.0.0.2
>     (Linaro SeattleFDK commit 4b419f2ef2)
> ---
>
> Regards,
>
> Leif
>
> >
> > Thanks
> > Abner
> >
> > > -----Original Message-----
> > > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > > Sent: Saturday, March 18, 2023 12:09 AM
> > > To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> > > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
> > > <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> > > <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>;
> > > Michael D Kinney <michael.d.kinney@intel.com>
> > > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> > > AMD/BoardPkg and AMD/PlatformPkg maintainers
> > >
> > > Caution: This message originated from an External Source. Use
> > > proper caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> > > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > > >
> > > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> > > >
> > > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > ---
> > > >  Maintainers.txt | 6 ++++++
> > > >  1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/Maintainers.txt b/Maintainers.txt index
> > > > 747191366070..bb8ab643e090 100644
> > > > --- a/Maintainers.txt
> > > > +++ b/Maintainers.txt
> > > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
> > > >  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > >  M: Leif Lindholm <quic_llindhol@quicinc.com>
> > > >
> > > > +AMD Platform
> > >
> > > Annoyingly, I'm now going to ask the question I have been avoiding
> > > up until now. What does "AMD Platform" mean?
> > > I mean, you've placed this straight after the entry for the Seattle platforms.
> > > I think the name, and package names, are too generic.
> > >
> > > /
> > >     Leif
> > >
> > > > +F: Platform/AMD/BoardPkg
> > > > +F: Platform/AMD/PlatformPkg
> > > > +M: Abner Chang <abner.chang@amd.com>
> > > > +M: Abdul Lateef Attar <abdattar@amd.com>
> > > > +
> > > >  Ampere Computing
> > > >  F: Platform/Ampere
> > > >  F: Silicon/Ampere
> > > > --
> > > > 2.25.1
> > > >
> >
> >
> > 
> >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101490): https://edk2.groups.io/g/devel/message/101490
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[AMD Official Use Only - General]



> -----Original Message-----
> From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> Sent: Tuesday, March 21, 2023 11:01 AM
> To: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> AMD/BoardPkg and AMD/PlatformPkg maintainers
> 
> [AMD Official Use Only - General]
> 
> Hi Leif,
>         AMD/BoardPkg will implements modules specific to boards(one or more
> motherboards).
> It will not contain any module specific to Platform or Silicon, which are part of
> MinPlatformPkg.
> 
> How about just Min prefix?
> AMD/MinBoardPkg (I am avoiding the Amd prefix because its already in AMD
> folder).
I am good with this naming. So we will have AMD boards that leverage MinPlatform under MinBoardPkg. Those boards which are not Minplatform based can just stay under Platforms/AMD (e.g., OverdriveBoard.), is my understanding correct Abdul?
Abner
> 
> AMD board package for MinPlatformPkg
>  F: Platform/AMD/MinBoardPkg
>  M: Maintainer1
>  M: Maintainer2
> 
> Thanks
> AbduL
> 
> -----Original Message-----
> From: Leif Lindholm <quic_llindhol@quicinc.com>
> Sent: 20 March 2023 23:33
> To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> Cc: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> AMD/BoardPkg and AMD/PlatformPkg maintainers
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Abdul,
> 
> On Mon, Mar 20, 2023 at 14:09:11 +0000, Attar, AbdulLateef (Abdul Lateef)
> wrote:
> > AMD/BoardPkg will contains the modules/drivers to support
> MinPlatformPkg framework.
> >    BoardPkg will be generic across all AMD boards which are based on
> MinPlatformPkg framework.
> >    It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg".
> >    We will gradually add modules and libraries to it.
> 
> So, if the purpose is exclusively to support MinPlatformPkg platforms, I think
> that should be part of the name.
> Like Platform/AMD/AmdMinPlatformPkg (for example).
> 
> > AMD/PlatformPkg will contain the modules/drivers which are generic to
> future AMD platform.
> >    Currently we don't have complete platform, we can drop
> >    PlatformPkg for now till we have complete(reasonable modules)
> >    solution.
> 
> It will certainly be easier to reason about what the preferred naming/layout
> should be once there is code to look at for examples.
> It may be that parts of it would live more naturally under Silicon/AMD, for
> example.
> 
> > It's better to not touch existing AMD/OverdriveBoard, restructuring
> > requires changes to .dsc and .fdf files, might break backward
> > compatibility.
> 
> No problem. Config files occasionally need to be revamped, but that's simply
> a mechanical exercise.
> 
> > How about having just BoardPkg like below?
> 
> That, too, is a completely generic name that conveys no information about
> *what* boards one can expect to find in there.
> 
> Regards,
> 
> Leif
> 
> > AMD board package
> > F: Platform/AMD/BoardPkg
> > M: Maintainer1
> > M: Maintainer2
> >
> > Please let me know your thoughts.
> >
> > Thanks
> > AbduL
> >
> >
> >
> >
> > -----Original Message-----
> > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > Sent: 20 March 2023 18:35
> > To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
> > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard
> > Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney
> > <michael.d.kinney@intel.com>
> > Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> > AMD/BoardPkg and AMD/PlatformPkg maintainers
> >
> > Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> >
> >
> > Hi Abner,
> >
> > On Sat, Mar 18, 2023 at 09:16:17 +0000, Chang, Abner via groups.io wrote:
> > > I don't see any modules under OverdriveBoard, is this package still
> >
> > The code is split between Platform/AMD and Silicon/AMD/Styx, the latter
> also being used by SoftIron/Overdrive1000 and LeMaker Cello (although that
> one is pretty much defunct and should probably be dropped).
> >
> > > in use? Do you still remember where is FDF and DSC come from (as
> > > there is AMD copyright 2014-2016) back to the moment when you was
> > > introduced this package?
> >
> > As the git history tells you:
> > ---
> > commit f4d38e50c0f24eb78eb003a94f583025621c63db
> > Author: Leif Lindholm <leif.lindholm@linaro.org>
> > Date:   Thu Aug 3 12:24:22 2017 +0100
> >
> >     Platform,Silicon: import AMD Styx SoC support and platforms
> >
> >     Common files for AMD Overdrive, SoftIron Overdrive 1000
> >     and LeMaker Cello, as well as actual platform support.
> >     Imported from commit efd798c1eb of
> >     https://git.linaro.org/uefi/OpenPlatformPkg.git
> > ---
> >
> > and the initial commit of the platform in that repository is:
> > ---
> > From: Leo Duran <leo.duran@amd.com>
> > Date: Thu, 20 Aug 2015 13:30:24 -0500
> >
> >     Subject: Platforms/AMD: add support for AMD Overdrive and Lemaker
> > Cello
> >
> >     This adds support for the AMD Seattle based Overdrive and Husky
> >     platforms,
> >     and the Lemaker Cello which is derived from it.
> >
> >     This code was tested with upstream EDK2 commit 758ea94651.
> >
> >     The binaries in this branch are based on SeattleFDK 1.0.0.2
> >     (Linaro SeattleFDK commit 4b419f2ef2)
> > ---
> >
> > Regards,
> >
> > Leif
> >
> > >
> > > Thanks
> > > Abner
> > >
> > > > -----Original Message-----
> > > > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > Sent: Saturday, March 18, 2023 12:09 AM
> > > > To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> > > > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
> > > > <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> > > > <ardb+tianocore@kernel.org>; Chang, Abner
> <Abner.Chang@amd.com>;
> > > > Michael D Kinney <michael.d.kinney@intel.com>
> > > > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> > > > AMD/BoardPkg and AMD/PlatformPkg maintainers
> > > >
> > > > Caution: This message originated from an External Source. Use
> > > > proper caution when opening attachments, clicking links, or responding.
> > > >
> > > >
> > > > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> > > > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > > > >
> > > > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> > > > >
> > > > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > ---
> > > > >  Maintainers.txt | 6 ++++++
> > > > >  1 file changed, 6 insertions(+)
> > > > >
> > > > > diff --git a/Maintainers.txt b/Maintainers.txt index
> > > > > 747191366070..bb8ab643e090 100644
> > > > > --- a/Maintainers.txt
> > > > > +++ b/Maintainers.txt
> > > > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
> > > > >  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > > >  M: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > >
> > > > > +AMD Platform
> > > >
> > > > Annoyingly, I'm now going to ask the question I have been avoiding
> > > > up until now. What does "AMD Platform" mean?
> > > > I mean, you've placed this straight after the entry for the Seattle
> platforms.
> > > > I think the name, and package names, are too generic.
> > > >
> > > > /
> > > >     Leif
> > > >
> > > > > +F: Platform/AMD/BoardPkg
> > > > > +F: Platform/AMD/PlatformPkg
> > > > > +M: Abner Chang <abner.chang@amd.com>
> > > > > +M: Abdul Lateef Attar <abdattar@amd.com>
> > > > > +
> > > > >  Ampere Computing
> > > > >  F: Platform/Ampere
> > > > >  F: Silicon/Ampere
> > > > > --
> > > > > 2.25.1
> > > > >
> > >
> > >
> > > 
> > >
> > >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101569): https://edk2.groups.io/g/devel/message/101569
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[Public]

Hi Abner,
        That's right, Platform/AMD/MinBoardPkg will contains all modules/library/drivers required for AMD boards which are based on MinPlatformPkg framework.
Thanks
AbduL

-----Original Message-----
From: Chang, Abner <Abner.Chang@amd.com>
Sent: 22 March 2023 15:25
To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Leif Lindholm <quic_llindhol@quicinc.com>
Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney <michael.d.kinney@intel.com>
Subject: RE: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers

[AMD Official Use Only - General]



> -----Original Message-----
> From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> Sent: Tuesday, March 21, 2023 11:01 AM
> To: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> AMD/BoardPkg and AMD/PlatformPkg maintainers
>
> [AMD Official Use Only - General]
>
> Hi Leif,
>         AMD/BoardPkg will implements modules specific to boards(one or
> more motherboards).
> It will not contain any module specific to Platform or Silicon, which
> are part of MinPlatformPkg.
>
> How about just Min prefix?
> AMD/MinBoardPkg (I am avoiding the Amd prefix because its already in
> AMD folder).
I am good with this naming. So we will have AMD boards that leverage MinPlatform under MinBoardPkg. Those boards which are not Minplatform based can just stay under Platforms/AMD (e.g., OverdriveBoard.), is my understanding correct Abdul?
Abner
>
> AMD board package for MinPlatformPkg
>  F: Platform/AMD/MinBoardPkg
>  M: Maintainer1
>  M: Maintainer2
>
> Thanks
> AbduL
>
> -----Original Message-----
> From: Leif Lindholm <quic_llindhol@quicinc.com>
> Sent: 20 March 2023 23:33
> To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> Cc: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> AMD/BoardPkg and AMD/PlatformPkg maintainers
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> Hi Abdul,
>
> On Mon, Mar 20, 2023 at 14:09:11 +0000, Attar, AbdulLateef (Abdul
> Lateef)
> wrote:
> > AMD/BoardPkg will contains the modules/drivers to support
> MinPlatformPkg framework.
> >    BoardPkg will be generic across all AMD boards which are based on
> MinPlatformPkg framework.
> >    It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg".
> >    We will gradually add modules and libraries to it.
>
> So, if the purpose is exclusively to support MinPlatformPkg platforms,
> I think that should be part of the name.
> Like Platform/AMD/AmdMinPlatformPkg (for example).
>
> > AMD/PlatformPkg will contain the modules/drivers which are generic
> > to
> future AMD platform.
> >    Currently we don't have complete platform, we can drop
> >    PlatformPkg for now till we have complete(reasonable modules)
> >    solution.
>
> It will certainly be easier to reason about what the preferred
> naming/layout should be once there is code to look at for examples.
> It may be that parts of it would live more naturally under
> Silicon/AMD, for example.
>
> > It's better to not touch existing AMD/OverdriveBoard, restructuring
> > requires changes to .dsc and .fdf files, might break backward
> > compatibility.
>
> No problem. Config files occasionally need to be revamped, but that's
> simply a mechanical exercise.
>
> > How about having just BoardPkg like below?
>
> That, too, is a completely generic name that conveys no information
> about
> *what* boards one can expect to find in there.
>
> Regards,
>
> Leif
>
> > AMD board package
> > F: Platform/AMD/BoardPkg
> > M: Maintainer1
> > M: Maintainer2
> >
> > Please let me know your thoughts.
> >
> > Thanks
> > AbduL
> >
> >
> >
> >
> > -----Original Message-----
> > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > Sent: 20 March 2023 18:35
> > To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
> > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>;
> > Ard Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney
> > <michael.d.kinney@intel.com>
> > Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt:
> > Adds AMD/BoardPkg and AMD/PlatformPkg maintainers
> >
> > Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> >
> >
> > Hi Abner,
> >
> > On Sat, Mar 18, 2023 at 09:16:17 +0000, Chang, Abner via groups.io wrote:
> > > I don't see any modules under OverdriveBoard, is this package
> > > still
> >
> > The code is split between Platform/AMD and Silicon/AMD/Styx, the
> > latter
> also being used by SoftIron/Overdrive1000 and LeMaker Cello (although
> that one is pretty much defunct and should probably be dropped).
> >
> > > in use? Do you still remember where is FDF and DSC come from (as
> > > there is AMD copyright 2014-2016) back to the moment when you was
> > > introduced this package?
> >
> > As the git history tells you:
> > ---
> > commit f4d38e50c0f24eb78eb003a94f583025621c63db
> > Author: Leif Lindholm <leif.lindholm@linaro.org>
> > Date:   Thu Aug 3 12:24:22 2017 +0100
> >
> >     Platform,Silicon: import AMD Styx SoC support and platforms
> >
> >     Common files for AMD Overdrive, SoftIron Overdrive 1000
> >     and LeMaker Cello, as well as actual platform support.
> >     Imported from commit efd798c1eb of
> >     https://git.linaro.org/uefi/OpenPlatformPkg.git
> > ---
> >
> > and the initial commit of the platform in that repository is:
> > ---
> > From: Leo Duran <leo.duran@amd.com>
> > Date: Thu, 20 Aug 2015 13:30:24 -0500
> >
> >     Subject: Platforms/AMD: add support for AMD Overdrive and
> > Lemaker Cello
> >
> >     This adds support for the AMD Seattle based Overdrive and Husky
> >     platforms,
> >     and the Lemaker Cello which is derived from it.
> >
> >     This code was tested with upstream EDK2 commit 758ea94651.
> >
> >     The binaries in this branch are based on SeattleFDK 1.0.0.2
> >     (Linaro SeattleFDK commit 4b419f2ef2)
> > ---
> >
> > Regards,
> >
> > Leif
> >
> > >
> > > Thanks
> > > Abner
> > >
> > > > -----Original Message-----
> > > > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > Sent: Saturday, March 18, 2023 12:09 AM
> > > > To: Attar, AbdulLateef (Abdul Lateef)
> > > > <AbdulLateef.Attar@amd.com>
> > > > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
> > > > <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> > > > <ardb+tianocore@kernel.org>; Chang, Abner
> <Abner.Chang@amd.com>;
> > > > Michael D Kinney <michael.d.kinney@intel.com>
> > > > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> > > > AMD/BoardPkg and AMD/PlatformPkg maintainers
> > > >
> > > > Caution: This message originated from an External Source. Use
> > > > proper caution when opening attachments, clicking links, or responding.
> > > >
> > > >
> > > > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> > > > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > > > >
> > > > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> > > > >
> > > > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > ---
> > > > >  Maintainers.txt | 6 ++++++
> > > > >  1 file changed, 6 insertions(+)
> > > > >
> > > > > diff --git a/Maintainers.txt b/Maintainers.txt index
> > > > > 747191366070..bb8ab643e090 100644
> > > > > --- a/Maintainers.txt
> > > > > +++ b/Maintainers.txt
> > > > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
> > > > >  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > > >  M: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > >
> > > > > +AMD Platform
> > > >
> > > > Annoyingly, I'm now going to ask the question I have been
> > > > avoiding up until now. What does "AMD Platform" mean?
> > > > I mean, you've placed this straight after the entry for the
> > > > Seattle
> platforms.
> > > > I think the name, and package names, are too generic.
> > > >
> > > > /
> > > >     Leif
> > > >
> > > > > +F: Platform/AMD/BoardPkg
> > > > > +F: Platform/AMD/PlatformPkg
> > > > > +M: Abner Chang <abner.chang@amd.com>
> > > > > +M: Abdul Lateef Attar <abdattar@amd.com>
> > > > > +
> > > > >  Ampere Computing
> > > > >  F: Platform/Ampere
> > > > >  F: Silicon/Ampere
> > > > > --
> > > > > 2.25.1
> > > > >
> > >
> > >
> > > 
> > >
> > >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101584): https://edk2.groups.io/g/devel/message/101584
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Wed, Mar 22, 2023 at 11:59:38 +0000, Attar, AbdulLateef (Abdul Lateef) wrote:
> [Public]
> 
> Hi Abner,
>         That's right, Platform/AMD/MinBoardPkg will contains all
>         modules/library/drivers required for AMD boards which are
>         based on MinPlatformPkg framework.

That works for me.

/
    Leif

> Thanks
> AbduL
> 
> -----Original Message-----
> From: Chang, Abner <Abner.Chang@amd.com>
> Sent: 22 March 2023 15:25
> To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers
> 
> [AMD Official Use Only - General]
> 
> 
> 
> > -----Original Message-----
> > From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> > Sent: Tuesday, March 21, 2023 11:01 AM
> > To: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; Ard
> > Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney
> > <michael.d.kinney@intel.com>
> > Subject: RE: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> > AMD/BoardPkg and AMD/PlatformPkg maintainers
> >
> > [AMD Official Use Only - General]
> >
> > Hi Leif,
> >         AMD/BoardPkg will implements modules specific to boards(one or
> > more motherboards).
> > It will not contain any module specific to Platform or Silicon, which
> > are part of MinPlatformPkg.
> >
> > How about just Min prefix?
> > AMD/MinBoardPkg (I am avoiding the Amd prefix because its already in
> > AMD folder).
> I am good with this naming. So we will have AMD boards that leverage MinPlatform under MinBoardPkg. Those boards which are not Minplatform based can just stay under Platforms/AMD (e.g., OverdriveBoard.), is my understanding correct Abdul?
> Abner
> >
> > AMD board package for MinPlatformPkg
> >  F: Platform/AMD/MinBoardPkg
> >  M: Maintainer1
> >  M: Maintainer2
> >
> > Thanks
> > AbduL
> >
> > -----Original Message-----
> > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > Sent: 20 March 2023 23:33
> > To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> > Cc: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; Ard
> > Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney
> > <michael.d.kinney@intel.com>
> > Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> > AMD/BoardPkg and AMD/PlatformPkg maintainers
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > Hi Abdul,
> >
> > On Mon, Mar 20, 2023 at 14:09:11 +0000, Attar, AbdulLateef (Abdul
> > Lateef)
> > wrote:
> > > AMD/BoardPkg will contains the modules/drivers to support
> > MinPlatformPkg framework.
> > >    BoardPkg will be generic across all AMD boards which are based on
> > MinPlatformPkg framework.
> > >    It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg".
> > >    We will gradually add modules and libraries to it.
> >
> > So, if the purpose is exclusively to support MinPlatformPkg platforms,
> > I think that should be part of the name.
> > Like Platform/AMD/AmdMinPlatformPkg (for example).
> >
> > > AMD/PlatformPkg will contain the modules/drivers which are generic
> > > to
> > future AMD platform.
> > >    Currently we don't have complete platform, we can drop
> > >    PlatformPkg for now till we have complete(reasonable modules)
> > >    solution.
> >
> > It will certainly be easier to reason about what the preferred
> > naming/layout should be once there is code to look at for examples.
> > It may be that parts of it would live more naturally under
> > Silicon/AMD, for example.
> >
> > > It's better to not touch existing AMD/OverdriveBoard, restructuring
> > > requires changes to .dsc and .fdf files, might break backward
> > > compatibility.
> >
> > No problem. Config files occasionally need to be revamped, but that's
> > simply a mechanical exercise.
> >
> > > How about having just BoardPkg like below?
> >
> > That, too, is a completely generic name that conveys no information
> > about
> > *what* boards one can expect to find in there.
> >
> > Regards,
> >
> > Leif
> >
> > > AMD board package
> > > F: Platform/AMD/BoardPkg
> > > M: Maintainer1
> > > M: Maintainer2
> > >
> > > Please let me know your thoughts.
> > >
> > > Thanks
> > > AbduL
> > >
> > >
> > >
> > >
> > > -----Original Message-----
> > > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > > Sent: 20 March 2023 18:35
> > > To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
> > > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>;
> > > Ard Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney
> > > <michael.d.kinney@intel.com>
> > > Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt:
> > > Adds AMD/BoardPkg and AMD/PlatformPkg maintainers
> > >
> > > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > Hi Abner,
> > >
> > > On Sat, Mar 18, 2023 at 09:16:17 +0000, Chang, Abner via groups.io wrote:
> > > > I don't see any modules under OverdriveBoard, is this package
> > > > still
> > >
> > > The code is split between Platform/AMD and Silicon/AMD/Styx, the
> > > latter
> > also being used by SoftIron/Overdrive1000 and LeMaker Cello (although
> > that one is pretty much defunct and should probably be dropped).
> > >
> > > > in use? Do you still remember where is FDF and DSC come from (as
> > > > there is AMD copyright 2014-2016) back to the moment when you was
> > > > introduced this package?
> > >
> > > As the git history tells you:
> > > ---
> > > commit f4d38e50c0f24eb78eb003a94f583025621c63db
> > > Author: Leif Lindholm <leif.lindholm@linaro.org>
> > > Date:   Thu Aug 3 12:24:22 2017 +0100
> > >
> > >     Platform,Silicon: import AMD Styx SoC support and platforms
> > >
> > >     Common files for AMD Overdrive, SoftIron Overdrive 1000
> > >     and LeMaker Cello, as well as actual platform support.
> > >     Imported from commit efd798c1eb of
> > >     https://git.linaro.org/uefi/OpenPlatformPkg.git
> > > ---
> > >
> > > and the initial commit of the platform in that repository is:
> > > ---
> > > From: Leo Duran <leo.duran@amd.com>
> > > Date: Thu, 20 Aug 2015 13:30:24 -0500
> > >
> > >     Subject: Platforms/AMD: add support for AMD Overdrive and
> > > Lemaker Cello
> > >
> > >     This adds support for the AMD Seattle based Overdrive and Husky
> > >     platforms,
> > >     and the Lemaker Cello which is derived from it.
> > >
> > >     This code was tested with upstream EDK2 commit 758ea94651.
> > >
> > >     The binaries in this branch are based on SeattleFDK 1.0.0.2
> > >     (Linaro SeattleFDK commit 4b419f2ef2)
> > > ---
> > >
> > > Regards,
> > >
> > > Leif
> > >
> > > >
> > > > Thanks
> > > > Abner
> > > >
> > > > > -----Original Message-----
> > > > > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > > Sent: Saturday, March 18, 2023 12:09 AM
> > > > > To: Attar, AbdulLateef (Abdul Lateef)
> > > > > <AbdulLateef.Attar@amd.com>
> > > > > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
> > > > > <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> > > > > <ardb+tianocore@kernel.org>; Chang, Abner
> > <Abner.Chang@amd.com>;
> > > > > Michael D Kinney <michael.d.kinney@intel.com>
> > > > > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> > > > > AMD/BoardPkg and AMD/PlatformPkg maintainers
> > > > >
> > > > > Caution: This message originated from an External Source. Use
> > > > > proper caution when opening attachments, clicking links, or responding.
> > > > >
> > > > >
> > > > > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> > > > > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > > > > >
> > > > > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> > > > > >
> > > > > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> > > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > > > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > > ---
> > > > > >  Maintainers.txt | 6 ++++++
> > > > > >  1 file changed, 6 insertions(+)
> > > > > >
> > > > > > diff --git a/Maintainers.txt b/Maintainers.txt index
> > > > > > 747191366070..bb8ab643e090 100644
> > > > > > --- a/Maintainers.txt
> > > > > > +++ b/Maintainers.txt
> > > > > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
> > > > > >  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > > > >  M: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > > >
> > > > > > +AMD Platform
> > > > >
> > > > > Annoyingly, I'm now going to ask the question I have been
> > > > > avoiding up until now. What does "AMD Platform" mean?
> > > > > I mean, you've placed this straight after the entry for the
> > > > > Seattle
> > platforms.
> > > > > I think the name, and package names, are too generic.
> > > > >
> > > > > /
> > > > >     Leif
> > > > >
> > > > > > +F: Platform/AMD/BoardPkg
> > > > > > +F: Platform/AMD/PlatformPkg
> > > > > > +M: Abner Chang <abner.chang@amd.com>
> > > > > > +M: Abdul Lateef Attar <abdattar@amd.com>
> > > > > > +
> > > > > >  Ampere Computing
> > > > > >  F: Platform/Ampere
> > > > > >  F: Silicon/Ampere
> > > > > > --
> > > > > > 2.25.1
> > > > > >
> > > >
> > > >
> > > > 
> > > >
> > > >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101572): https://edk2.groups.io/g/devel/message/101572
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Sat, 18 Mar 2023 at 10:16, Chang, Abner <Abner.Chang@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> BTW Leif,
> I don't see any modules under OverdriveBoard, is this package still in use? Do you still remember where is FDF and DSC come from (as there is AMD copyright 2014-2016) back to the moment when you was introduced this package?
>

Hello Abner,

I can help with this, but I'm not sure I understand the question.

Check with Leo Duran - we worked with him on the Huskyboard at the
time, and he provided us with access to the SeattleFDK, some of which
became part of the OverdriveBoard/CelloBoard platform implementation.

The package is still in use, at least by me :-)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101362): https://edk2.groups.io/g/devel/message/101362
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[AMD Official Use Only - General]

Hi Ard,
Thanks for letting us know this history. I know Leo and I will reach out to him if necessary.
We are going to relocate OverdriveBoard to under AMD/BoardPkg, hope it won't bring you too much problems. 😊
I can see some people had contributions to OverdriveBoard, however I don’t know some of them and I don’t have their email address neither.
I will send the notification to devel mailing list about this relocation.

Thanks
Abner

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Saturday, March 18, 2023 5:43 PM
> To: Chang, Abner <Abner.Chang@amd.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Attar, AbdulLateef (Abdul
> Lateef) <AbdulLateef.Attar@amd.com>; devel@edk2.groups.io; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney
> <michael.d.kinney@intel.com>
> Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg
> and AMD/PlatformPkg maintainers
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> On Sat, 18 Mar 2023 at 10:16, Chang, Abner <Abner.Chang@amd.com> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > BTW Leif,
> > I don't see any modules under OverdriveBoard, is this package still in use?
> Do you still remember where is FDF and DSC come from (as there is AMD
> copyright 2014-2016) back to the moment when you was introduced this
> package?
> >
> 
> Hello Abner,
> 
> I can help with this, but I'm not sure I understand the question.
> 
> Check with Leo Duran - we worked with him on the Huskyboard at the time,
> and he provided us with access to the SeattleFDK, some of which became
> part of the OverdriveBoard/CelloBoard platform implementation.
> 
> The package is still in use, at least by me :-)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101364): https://edk2.groups.io/g/devel/message/101364
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[AMD Official Use Only - General]

Hi Leif,
Thanks to your review.
AMD\PlatformPkg is mainly for the modules that are generic to AMD's server, client or other platforms, while AMD\BoardPkg that contains the modules that support MinPlatformrPkg framework. AMD\BoardPkg may also provide the modules those are common to all AMD boards and leverage by the board specific packages under AMD\BoardPkg. Perhaps AMD\Board would a better naming that contains both common board modules and the specific board packages. I don't know the context of OverdriveBoard , however we would like to see OverdriveBoard is relocated to under AMD\Board(Pkg) as well. With this we can have a well organized AMD directory under edk2-platform that provides AMD opensource edk2 solution to industry.

Thanks
Abner

> -----Original Message-----
> From: Leif Lindholm <quic_llindhol@quicinc.com>
> Sent: Saturday, March 18, 2023 12:09 AM
> To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
> <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>;
> Michael D Kinney <michael.d.kinney@intel.com>
> Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg
> and AMD/PlatformPkg maintainers
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> >
> > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> >
> > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >  Maintainers.txt | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt index
> > 747191366070..bb8ab643e090 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
> >  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> >  M: Leif Lindholm <quic_llindhol@quicinc.com>
> >
> > +AMD Platform
> 
> Annoyingly, I'm now going to ask the question I have been avoiding up until
> now. What does "AMD Platform" mean?
> I mean, you've placed this straight after the entry for the Seattle platforms.
> I think the name, and package names, are too generic.
> 
> /
>     Leif
> 
> > +F: Platform/AMD/BoardPkg
> > +F: Platform/AMD/PlatformPkg
> > +M: Abner Chang <abner.chang@amd.com>
> > +M: Abdul Lateef Attar <abdattar@amd.com>
> > +
> >  Ampere Computing
> >  F: Platform/Ampere
> >  F: Silicon/Ampere
> > --
> > 2.25.1
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101360): https://edk2.groups.io/g/devel/message/101360
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Abner,

On Sat, Mar 18, 2023 at 09:03:50 +0000, Chang, Abner via groups.io wrote:
> AMD\PlatformPkg is mainly for the modules that are generic to AMD's
> server, client or other platforms, while AMD\BoardPkg that contains
> the modules that support MinPlatformrPkg framework. AMD\BoardPkg may
> also provide the modules those are common to all AMD boards and
> leverage by the board specific packages under AMD\BoardPkg. Perhaps
> AMD\Board would a better naming that contains both common board
> modules and the specific board packages.

We don't really have a rigorous "here is what the contents of a vendor
directory should look like" ruleset.

My interpretation is as follows:
a Pkg has a .dec and a Pkg shouldn't live in a Pkg.

So, I'm not opposed to non-package subdirectories to AMD that
themselves contain packages.

But then, what's the difference between a board and a platform?

> I don't know the context of
> OverdriveBoard , however we would like to see OverdriveBoard is
> relocated to under AMD\Board(Pkg) as well. With this we can have a
> well organized AMD directory under edk2-platform that provides AMD
> opensource edk2 solution to industry.

That sounds ideal to me.
We just need to figure out a directory layout that will work, for
Overdrive/Styx, the platforms supported by this set, and future
platforms.

Regards,

Leif


> 
> Thanks
> Abner
> 
> > -----Original Message-----
> > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > Sent: Saturday, March 18, 2023 12:09 AM
> > To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
> > <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> > <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>;
> > Michael D Kinney <michael.d.kinney@intel.com>
> > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg
> > and AMD/PlatformPkg maintainers
> > 
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> > 
> > 
> > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > >
> > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> > >
> > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > ---
> > >  Maintainers.txt | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Maintainers.txt b/Maintainers.txt index
> > > 747191366070..bb8ab643e090 100644
> > > --- a/Maintainers.txt
> > > +++ b/Maintainers.txt
> > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
> > >  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > >  M: Leif Lindholm <quic_llindhol@quicinc.com>
> > >
> > > +AMD Platform
> > 
> > Annoyingly, I'm now going to ask the question I have been avoiding up until
> > now. What does "AMD Platform" mean?
> > I mean, you've placed this straight after the entry for the Seattle platforms.
> > I think the name, and package names, are too generic.
> > 
> > /
> >     Leif
> > 
> > > +F: Platform/AMD/BoardPkg
> > > +F: Platform/AMD/PlatformPkg
> > > +M: Abner Chang <abner.chang@amd.com>
> > > +M: Abdul Lateef Attar <abdattar@amd.com>
> > > +
> > >  Ampere Computing
> > >  F: Platform/Ampere
> > >  F: Silicon/Ampere
> > > --
> > > 2.25.1
> > >
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101434): https://edk2.groups.io/g/devel/message/101434
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[AMD Official Use Only - General]

Acked-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Abdul Lateef Attar <abdattar@amd.com>
> Sent: Friday, March 17, 2023 2:50 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Attar,
> AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Leif Lindholm <quic_llindhol@quicinc.com>;
> Chang, Abner <Abner.Chang@amd.com>; Michael D Kinney
> <michael.d.kinney@intel.com>
> Subject: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and
> AMD/PlatformPkg maintainers
> 
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> 
> Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> 
> Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt index
> 747191366070..bb8ab643e090 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
>  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
>  M: Leif Lindholm <quic_llindhol@quicinc.com>
> 
> +AMD Platform
> +F: Platform/AMD/BoardPkg
> +F: Platform/AMD/PlatformPkg
> +M: Abner Chang <abner.chang@amd.com>
> +M: Abdul Lateef Attar <abdattar@amd.com>
> +
>  Ampere Computing
>  F: Platform/Ampere
>  F: Silicon/Ampere
> --
> 2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101315): https://edk2.groups.io/g/devel/message/101315
Mute This Topic: https://groups.io/mt/97667946/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-