[edk2-devel] [edk2-platforms] [PATCH 0/3] Fix SimicsOpenBoardPkg GCC Build

Agyeman, Prince posted 3 patches 1 week ago
Failed in applying to current master (apply log)
.../Smbios/SmbiosBasicDxe/SmbiosBasic.h       |  2 +-
.../PlatformBootManagerLib/BdsPlatform.c      | 38 -------------------
.../SimicsOpenBoardPkg/SecCore/SecMain.c      | 23 -----------
.../BasePchSpiCommonLib/SpiCommon.c           |  3 --
.../SmmControl/RuntimeDxe/SmmControl2Dxe.c    |  7 +---
5 files changed, 3 insertions(+), 70 deletions(-)

[edk2-devel] [edk2-platforms] [PATCH 0/3] Fix SimicsOpenBoardPkg GCC Build

Posted by Agyeman, Prince 1 week ago
This patch series fix gcc build issues seen
in SimicsOpenBoardPkg.
Patches were tested on GCC 5

Prince Agyeman (3):
  AdvancedFeaturePkg: Fix GCC build
  SimicsOpenBoardPkg: Fix GCC build issues
  SimicsIch10Pkg: Fix GCC build issues

 .../Smbios/SmbiosBasicDxe/SmbiosBasic.h       |  2 +-
 .../PlatformBootManagerLib/BdsPlatform.c      | 38 -------------------
 .../SimicsOpenBoardPkg/SecCore/SecMain.c      | 23 -----------
 .../BasePchSpiCommonLib/SpiCommon.c           |  3 --
 .../SmmControl/RuntimeDxe/SmmControl2Dxe.c    |  7 +---
 5 files changed, 3 insertions(+), 70 deletions(-)

-- 
2.19.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47054): https://edk2.groups.io/g/devel/message/47054
Mute This Topic: https://groups.io/mt/34086415/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH 0/3] Fix SimicsOpenBoardPkg GCC Build

Posted by Philippe Mathieu-Daudé 1 week ago
Hi Prince,

On 9/10/19 1:15 AM, Agyeman, Prince wrote:
> This patch series fix gcc build issues seen
> in SimicsOpenBoardPkg.
> Patches were tested on GCC 5
> 
> Prince Agyeman (3):
>   AdvancedFeaturePkg: Fix GCC build
>   SimicsOpenBoardPkg: Fix GCC build issues
>   SimicsIch10Pkg: Fix GCC build issues

It seems you forgot to describe what each patch does and why.

The EDK2 project has few recommendations:
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

Personally I find this link very explicit:
https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages

You could paste the relevant part of the GCC error you get,
and explain why you decided to do your change:
"This variable is never read, we can safely remove it because ..."

Sometime the proper fix for a warning is not to remove the unused code,
but check why this code is not used, and fix by using it correctly.

If you can justify it is safe to remove unused code, then it is fine.

Regards,

Phil.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47068): https://edk2.groups.io/g/devel/message/47068
Mute This Topic: https://groups.io/mt/34086415/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-