From nobody Thu Apr 25 15:08:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47056+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47056+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1568070914; cv=none; d=zoho.com; s=zohoarc; b=AXGbjACoRHmsnAzPhsBLy7kr9HV7kDT4EZ9y1LPGytGfYQc1p291KtYMlFgn8zH7I4HPL2P+dDnPccrBzVTvguRu+j4B5AsKVfEf8y/la841t51BtoWBSjqbfp2I6Ic0agiDfLG9X/cDqwJjFUHKbsRNjQ6+N/Gscx9KL8WZeiQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568070914; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=5fZLGBDEKFF6Jh5dnj6k/f0zIWItR17D3ytZzT26ugI=; b=bKnOz73lfSJDAFL/NCLYIE0lxrE25px/G/0C8ivu54S2GR/i+UnMWF/NJ6nLopaRu+YS1qmoBCSl6NMwchqUv6YKHw9cK2jOWAYxxXjQUy4rSrp3xYeFcXDteyCKWPvz8uvAFdUJKPIHCRgHa/n8FDMQwhHD2rOB8uoZ2LVaeRw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47056+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568070913937743.981026095074; Mon, 9 Sep 2019 16:15:13 -0700 (PDT) Return-Path: X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Mon, 09 Sep 2019 16:15:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 16:15:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,487,1559545200"; d="scan'208";a="268226387" X-Received: from paagyema-desk2.amr.corp.intel.com ([10.7.159.148]) by orsmga001.jf.intel.com with ESMTP; 09 Sep 2019 16:15:10 -0700 From: "Agyeman, Prince" To: devel@edk2.groups.io Cc: David Wei , Liming Gao , Ankit Sinha , Agyeman Prince , Kubacki Michael A , Nate DeSimone Subject: [edk2-devel] [edk2-platforms] [PATCH 1/3] AdvancedFeaturePkg: Fix GCC build Date: Mon, 9 Sep 2019 16:15:07 -0700 Message-Id: <984cadf47043eb542d1831667963933321dceaa2.1568070575.git.prince.agyeman@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,prince.agyeman@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568070913; bh=4rH37yQBykf3DxkqDmVJpdaDYRTw4/TjMLLRklBkAnw=; h=Cc:Date:From:Reply-To:Subject:To; b=SQEe74aSVonaPI2Wz0zc+J9nzXSVP3z0zVFXUge4/fiVd4TDiOPStmVN5L7LiKMw0IL 2ENhpjh/dZQ329/1VxPpTkyo0LGTDrwf4HZ+Rj+TIDjq0A6gVNiD8UmSOJuADFG1oPkVe 1zRmWP0ZsCzJEp5KSDn50/ttByMMOlU2kaU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Cc: David Wei Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Signed-off-by: Prince Agyeman Reviewed-by: Nate DeSimone --- .../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/Smbios= Basic.h b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBas= ic.h index e278a4ed18..944946b5b8 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasic.h +++ b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasic.h @@ -11,7 +11,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent =20 #include #include -#include +#include #include #include #include --=20 2.19.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47056): https://edk2.groups.io/g/devel/message/47056 Mute This Topic: https://groups.io/mt/34086417/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu Apr 25 15:08:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47057+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47057+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1568070914; cv=none; d=zoho.com; s=zohoarc; b=cCXP2Sj4l2xg/xm5D2l4HKcYEyrKPJcDD3i+Kn28RxKkq/g+bv7mFpBFA+kTyOWJwNgMCmLBIgGktx8GWdWJjKBqVJmE/pvOZz35YSc4GMDXeXhobBchUtATG/JiTIDVdL2aVC4BpjY/NCg801XkM23nQeZ3MVxsfni10aIroqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568070914; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=PqXRl6uJcq9SP8j3QPlHC4k4i9EY4HXX2CcFkWg4XNs=; b=IoQFQjFctmgEb/2YJf8OusgKrQxFosYSd0ySjsMa48r6ETJsRClu+bT+J051bgMnKTVasm+XBjInH2ljOZZpfP8bXgpAUAwkEElhuaXt6C/1bje7J0JiKeelH5F3tGZbDoFHg54akQ5mFn86w+utx/Un2kVvz3MdL1wcLW8tP9M= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47057+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568070914746177.99889689956353; Mon, 9 Sep 2019 16:15:14 -0700 (PDT) Return-Path: X-Received: from mga05.intel.com (mga05.intel.com []) by groups.io with SMTP; Mon, 09 Sep 2019 16:15:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 16:15:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,487,1559545200"; d="scan'208";a="268226388" X-Received: from paagyema-desk2.amr.corp.intel.com ([10.7.159.148]) by orsmga001.jf.intel.com with ESMTP; 09 Sep 2019 16:15:10 -0700 From: "Agyeman, Prince" To: devel@edk2.groups.io Cc: David Wei , Liming Gao , Ankit Sinha , Agyeman Prince , Kubacki Michael A , Nate DeSimone Subject: [edk2-devel] [edk2-platforms] [PATCH 2/3] SimicsOpenBoardPkg: Fix GCC build issues Date: Mon, 9 Sep 2019 16:15:08 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,prince.agyeman@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568070913; bh=56+XxDxHX/2tWqyQMc62bf9BwujobuBSzchq+WsFmo0=; h=Cc:Date:From:Reply-To:Subject:To; b=q7cL6opF67VfSmB4/cmzBf+ngn+CjG0EVQmjTZutdtTbzbdzGz7bV3O2n+nG6FzdQHK nWfoptLPdZyOHOeD04QxeVmW4Ckj6QtBZ3/77Jz9u4HPk/lIIjdL+NIblziFqA1cPs7lf 8H5CaskxLzHOaoVPcBMWPHxQE9CSyyYHWHo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Cc: David Wei Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Signed-off-by: Prince Agyeman Reviewed-by: Nate DeSimone --- .../PlatformBootManagerLib/BdsPlatform.c | 38 ------------------- .../SimicsOpenBoardPkg/SecCore/SecMain.c | 23 ----------- 2 files changed, 61 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerL= ib/BdsPlatform.c b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootMa= nagerLib/BdsPlatform.c index 117c72b35f..953a4a6c15 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsP= latform.c +++ b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsP= latform.c @@ -316,12 +316,6 @@ ConnectRootBridge ( IN VOID *Context ); =20 -STATIC -VOID -SaveS3BootScript ( - VOID - ); - // // BDS Platform Functions // @@ -1296,38 +1290,6 @@ PlatformBdsConnectSequence ( PciAcpiInitialization (); } =20 -/** - Save the S3 boot script. - - Note that DxeSmmReadyToLock must be signaled after this function returns; - otherwise the script wouldn't be saved actually. -**/ -STATIC -VOID -SaveS3BootScript ( - VOID - ) -{ - EFI_STATUS Status; - EFI_S3_SAVE_STATE_PROTOCOL *BootScript; - STATIC CONST UINT8 Info[] =3D { 0xDE, 0xAD, 0xBE, 0xEF }; - - Status =3D gBS->LocateProtocol (&gEfiS3SaveStateProtocolGuid, NULL, - (VOID **) &BootScript); - ASSERT_EFI_ERROR (Status); - - // - // Despite the opcode documentation in the PI spec, the protocol - // implementation embeds a deep copy of the info in the boot script, rat= her - // than storing just a pointer to runtime or NVS storage. - // - Status =3D BootScript->Write(BootScript, EFI_BOOT_SCRIPT_INFORMATION_OPC= ODE, - (UINT32) sizeof Info, - (EFI_PHYSICAL_ADDRESS)(UINTN) &Info); - ASSERT_EFI_ERROR (Status); -} - - /** Do the platform specific action after the console is ready =20 diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c b/Platform= /Intel/SimicsOpenBoardPkg/SecCore/SecMain.c index 5cbb47687b..4514641b46 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c @@ -495,29 +495,6 @@ FindPeiCoreImageBaseInFv ( return EFI_SUCCESS; } =20 - -/** - Reads 8-bits of CMOS data. - - Reads the 8-bits of CMOS data at the location specified by Index. - The 8-bit read value is returned. - - @param Index The CMOS location to read. - - @return The value read. - -**/ -STATIC -UINT8 -CmosRead8 ( - IN UINTN Index - ) -{ - IoWrite8 (0x70, (UINT8) Index); - return IoRead8 (0x71); -} - - STATIC BOOLEAN IsS3Resume ( --=20 2.19.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47057): https://edk2.groups.io/g/devel/message/47057 Mute This Topic: https://groups.io/mt/34086418/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu Apr 25 15:08:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47055+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47055+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1568070914; cv=none; d=zoho.com; s=zohoarc; b=JmwoAcx2C+g1F2Qio1neJ8/gf726OY4jBV3+9rG+NDGk9zdaySDuYI2IydE6AEYHX+unwUfNCn+9ljPpVZPemxJlIXHiDFHjFBlkXYtg1TkdilxsnwXINQCidE11ntnyHWL08aUL+4Yo8UnL96n3r9NZanhZmz09W9PN9/wufQ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568070914; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=qkf2ANoJJHysSj6wk34PJX/3TN0NgK8KZ2AhqP/iqBY=; b=jZfF5Hc/DA6yPVOKbDVgJYz1RsyhMnVIXlBJXz7HDZFrFbXfXl850CEwhxhSxICVnMG1duzmRz/4g2WPI9DuOjmmFQ1tC2p2s78oCX8/VT2zy8avyVGgTfG9lrTDwiRQu/gt2GU/rnB0gzSk4MnpXVsfNAa7ksYy3+O1NsVjHNc= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47055+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568070914485151.9727753667962; Mon, 9 Sep 2019 16:15:14 -0700 (PDT) Return-Path: X-Received: from mga05.intel.com (mga05.intel.com []) by groups.io with SMTP; Mon, 09 Sep 2019 16:15:12 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 16:15:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,487,1559545200"; d="scan'208";a="268226389" X-Received: from paagyema-desk2.amr.corp.intel.com ([10.7.159.148]) by orsmga001.jf.intel.com with ESMTP; 09 Sep 2019 16:15:10 -0700 From: "Agyeman, Prince" To: devel@edk2.groups.io Cc: David Wei , Liming Gao , Ankit Sinha , Agyeman Prince , Kubacki Michael A , Nate DeSimone Subject: [edk2-devel] [edk2-platforms] [PATCH 3/3] SimicsIch10Pkg: Fix GCC build issues Date: Mon, 9 Sep 2019 16:15:09 -0700 Message-Id: <53c8ae3dc3621bf64abfe21ceff0d04831df787e.1568070575.git.prince.agyeman@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,prince.agyeman@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568070913; bh=SKMBllBvIq4N2UNFkukANF+UIwF9vO6J58duRW7sPqk=; h=Cc:Date:From:Reply-To:Subject:To; b=aDZlu9/Zeaque5SnGaPDA6scrzI1YJcEDRWXyemCtZILwxAm1JgZUv15+9T29cSzKw2 TT+cyQCJkPVZmetQYZ9eWRJDpT1FGB/58vulAQzyzYJIVdQFwwUiZCpZWufl7FMhHue0P RnNn3Xw8/3oy5uilihPxz0t7+aPNFJlMwqU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Cc: David Wei Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Signed-off-by: Prince Agyeman Reviewed-by: Nate DeSimone --- .../LibraryPrivate/BasePchSpiCommonLib/SpiCommon.c | 3 --- .../SimicsIch10Pkg/SmmControl/RuntimeDxe/SmmControl2Dxe.c | 7 ++----- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLi= b/SpiCommon.c b/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommo= nLib/SpiCommon.c index bd08b2453b..3e7dffedfb 100644 --- a/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCo= mmon.c +++ b/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCo= mmon.c @@ -637,7 +637,6 @@ SendSpiCmd ( EFI_STATUS Status; UINT32 Index; SPI_INSTANCE *SpiInstance; - UINTN SpiBaseAddress; UINTN PchSpiBar0; UINT32 HardwareSpiAddr; UINT32 FlashRegionSize; @@ -648,9 +647,7 @@ SendSpiCmd ( =20 Status =3D EFI_SUCCESS; SpiInstance =3D SPI_INSTANCE_FROM_SPIPROTOCOL (This); - SpiBaseAddress =3D SpiInstance->PchSpiBase; PchSpiBar0 =3D AcquireSpiBar0 (SpiInstance); - SpiBaseAddress =3D SpiInstance->PchSpiBase; ABase =3D SpiInstance->PchAcpiBase; =20 // diff --git a/Silicon/Intel/SimicsIch10Pkg/SmmControl/RuntimeDxe/SmmControl2= Dxe.c b/Silicon/Intel/SimicsIch10Pkg/SmmControl/RuntimeDxe/SmmControl2Dxe.c index 268b04d25a..cc2d00b785 100644 --- a/Silicon/Intel/SimicsIch10Pkg/SmmControl/RuntimeDxe/SmmControl2Dxe.c +++ b/Silicon/Intel/SimicsIch10Pkg/SmmControl/RuntimeDxe/SmmControl2Dxe.c @@ -131,7 +131,6 @@ SmmControl2DxeTrigger ( IN UINTN ActivationInterval OPTIONAL ) { - EFI_STATUS Status; // // No support for queued or periodic activation. // @@ -141,7 +140,7 @@ SmmControl2DxeTrigger ( /// /// Clear any pending the APM SMI /// - Status =3D SmmClear(); + SmmClear(); // // The so-called "Advanced Power Management Status Port Register" is in = fact // a generic data passing register, between the caller and the SMI @@ -181,8 +180,6 @@ SmmControl2DxeClear ( IN BOOLEAN Periodic OPTIONAL ) { - EFI_STATUS Status; - if (Periodic) { return EFI_INVALID_PARAMETER; } @@ -201,7 +198,7 @@ SmmControl2DxeClear ( // // So, nothing to do here. // - Status =3D SmmClear(); + SmmClear(); =20 return EFI_SUCCESS; } --=20 2.19.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47055): https://edk2.groups.io/g/devel/message/47055 Mute This Topic: https://groups.io/mt/34086416/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-