.../NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 4 ++++ 1 file changed, 4 insertions(+)
Add check for NULL HostAddress in AllocateBuffer as required by UEFI
specification.
Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
.../NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
index a40c1a9593..363c4a765b 100644
--- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
+++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
@@ -856,6 +856,10 @@ CoherentPciIoAllocateBuffer (
return EFI_UNSUPPORTED;
}
+ if (HostAddress == NULL) {
+ return EFI_INVALID_PARAMETER;
+ }
+
if ((MemoryType != EfiBootServicesData) &&
(MemoryType != EfiRuntimeServicesData)) {
return EFI_INVALID_PARAMETER;
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65193): https://edk2.groups.io/g/devel/message/65193
Mute This Topic: https://groups.io/mt/76784482/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Hao A Wu <hao.a.wu@intel.com> Best Regards, Hao Wu > -----Original Message----- > From: Jeff Brasen <jbrasen@nvidia.com> > Sent: Saturday, September 12, 2020 1:17 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Jeff > Brasen <jbrasen@nvidia.com> > Subject: [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL > pointer check > > Add check for NULL HostAddress in AllocateBuffer as required by UEFI > specification. > > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com> > --- > .../NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git > a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > PciDeviceIo.c > b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > PciDeviceIo.c > index a40c1a9593..363c4a765b 100644 > --- > a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > PciDeviceIo.c > +++ > b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > Pc > +++ iDeviceIo.c > @@ -856,6 +856,10 @@ CoherentPciIoAllocateBuffer ( > return EFI_UNSUPPORTED; } + if (HostAddress == NULL) {+ return > EFI_INVALID_PARAMETER;+ }+ if ((MemoryType != EfiBootServicesData) > && (MemoryType != EfiRuntimeServicesData)) { return > EFI_INVALID_PARAMETER;-- > 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65241): https://edk2.groups.io/g/devel/message/65241 Mute This Topic: https://groups.io/mt/76784482/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Pushed via commit 698d3d7726232694018d437279dd4166e462deb7. Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wu, Hao A > Sent: Tuesday, September 15, 2020 9:48 AM > To: Jeff Brasen <jbrasen@nvidia.com>; devel@edk2.groups.io > Cc: Ni, Ray <ray.ni@intel.com> > Subject: Re: [edk2-devel] [PATCH] > MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL pointer check > > Reviewed-by: Hao A Wu <hao.a.wu@intel.com> > > Best Regards, > Hao Wu > > > -----Original Message----- > > From: Jeff Brasen <jbrasen@nvidia.com> > > Sent: Saturday, September 12, 2020 1:17 AM > > To: devel@edk2.groups.io > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Jeff > > Brasen <jbrasen@nvidia.com> > > Subject: [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL > > pointer check > > > > Add check for NULL HostAddress in AllocateBuffer as required by UEFI > > specification. > > > > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com> > > --- > > .../NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 4 > > ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git > > a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > > PciDeviceIo.c > > b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > > PciDeviceIo.c > > index a40c1a9593..363c4a765b 100644 > > --- > > a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > > PciDeviceIo.c > > +++ > > b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > > Pc > > +++ iDeviceIo.c > > @@ -856,6 +856,10 @@ CoherentPciIoAllocateBuffer ( > > return EFI_UNSUPPORTED; } + if (HostAddress == NULL) {+ return > > EFI_INVALID_PARAMETER;+ }+ if ((MemoryType != EfiBootServicesData) > > && (MemoryType != EfiRuntimeServicesData)) { return > > EFI_INVALID_PARAMETER;-- > > 2.25.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65396): https://edk2.groups.io/g/devel/message/65396 Mute This Topic: https://groups.io/mt/76784482/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.