From nobody Thu Apr 25 07:15:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65193+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65193+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; t=1599844598; cv=none; d=zohomail.com; s=zohoarc; b=EFls+F7rL2+N/13PKs9+tkoWeDG1fgibtN47Jr1CEZXk0UxaqYlDQSpAxQ+YBW23hrvWwYpCvXx5KKMlMWGKfEsw6gtu3UoZIQw8wed1e15MDFrtDPfc211J+3OgYx0kb5UPzJRSu8MS3giN0bKvNm7Bs1720rJJvDIfSwcIjx4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599844598; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=c/AWWeeNM/gEY7NCUiI+o8DgPDSVMGFh/GovflrwhlI=; b=oKs9SbmLYRudnRte8KR005oMCL0IOUHTQaVBTMtp3ycmMtSX35uyNx6jloWPDJYqqvMmovAR23nBNDvqWV8z2Q0Pr7tB14Mje/rFPKR4lBNGx//rgJMyg7Gp/qE8eItcEv0ijHfNHqCwE2bOpWJ73XAM/IESTtd+priQPsJvj4k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65193+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1599844598896464.9285148652058; Fri, 11 Sep 2020 10:16:38 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id FQa4YY1788612xcom54cUJeT; Fri, 11 Sep 2020 10:16:38 -0700 X-Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by mx.groups.io with SMTP id smtpd.web11.18.1599844598016445694 for ; Fri, 11 Sep 2020 10:16:38 -0700 X-Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 11 Sep 2020 10:14:20 -0700 X-Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 11 Sep 2020 10:16:37 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 11 Sep 2020 10:16:37 -0700 X-Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 11 Sep 2020 17:16:34 +0000 X-Received: from rnnvemgw01.nvidia.com (10.128.109.123) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 11 Sep 2020 17:16:34 +0000 X-Received: from jbrasen-ux.nvidia.com (Not Verified[10.20.23.99]) by rnnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Fri, 11 Sep 2020 10:16:33 -0700 From: "Jeff Brasen" To: CC: , , Jeff Brasen Subject: [edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL pointer check Date: Fri, 11 Sep 2020 11:16:30 -0600 Message-ID: <3e6a774a62a4ef92fcdfb5e156e2abc4c440d35e.1599844505.git.jbrasen@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jbrasen@nvidia.com X-Gm-Message-State: 7uunmmDSCEJpORL4BF1HOCiBx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1599844598; bh=RDYy8EASFenT5XCZjHiOn8LuBzsh7g9g09V+RGMO+OQ=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=c23AI2qHK8PHqgSfJlt3tDDKdJnZ9gdK4iXtSFttLpPZoFcbEZuav7BN7CIn3MZz98U ImKGf0iGQoeeialpt4JmwWBd1VftuYHwOLYCq/ho02nP4yQF1unHV/00mzUIiLL5PesiV fTQVvUexgNuMFoPGl7+6xI3fxip3H1OZjF0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Add check for NULL HostAddress in AllocateBuffer as required by UEFI specification. Signed-off-by: Jeff Brasen Reviewed-by: Hao A Wu --- .../NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverab= lePciDeviceIo.c b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDisco= verablePciDeviceIo.c index a40c1a9593..363c4a765b 100644 --- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDe= viceIo.c +++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDe= viceIo.c @@ -856,6 +856,10 @@ CoherentPciIoAllocateBuffer ( return EFI_UNSUPPORTED; } =20 + if (HostAddress =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + if ((MemoryType !=3D EfiBootServicesData) && (MemoryType !=3D EfiRuntimeServicesData)) { return EFI_INVALID_PARAMETER; --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65193): https://edk2.groups.io/g/devel/message/65193 Mute This Topic: https://groups.io/mt/76784482/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-