Hello Prabin,
Except for patches 1,3,4 where I had a remark/question,
for all other patches:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
Also, I could not directly apply the patches you sent on the latest
master branch. Indeed, the serie is on top of other patches on the
branch you shared:
https://gitlab.arm.com/infra-solutions/reference-design/platsw/edk2-platforms/-/tree/topics/rdfremont
I think that normally, the patches should only be based on the latest
master without relying on other patches,
Regards,
Pierre
On 1/12/24 16:47, Prabin CA via groups.io wrote:
> Changes since V1:
> - Corrected memory map in the DSDT file.
>
> This patch series introduce support for RD-Fremont reference design
> platform. This platform includes 32 CPUs, but the fixed virtual platform
> (FVP) simulates 16 CPUs of the platform. There is one CPU per cluster in
> the system and so the FVP simulates 16 clusters. Each of the CPUs
> include 64KB L1 Data cache, 64KB L1 Instruction cache and 2MB L2 cache.
> The platform also includes system level cache of 32MB and 8GB of RAM.
> Also, this patch series adding the extended SMBIO support for RD-Fremont
> platform.
>
> In addition to patches that introduce RD-Fremont platform, there are
> three patches that update support for existing platforms. The first
> patch in this series changes the data type of PcdSmmuBase from u32 to
> u64. The second patch refactor the system memory map base and size
> values. The third patch add a flag to enable PCIE support for existing
> and future platforms.
>
> This patch series should be applied on top of the patch series
> https://edk2.groups.io/g/devel/message/113732
>
> Link to gitlab branch with the patches in this series -
> https://gitlab.arm.com/infra-solutions/reference-design/platsw/edk2-platforms/-/tree/topics/rdfremont
>
> Prabin CA (6):
> Platform/Sgi: Refactor system memory base and size definitions
> Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms
> Platform/Sgi: Add initial support for RD-Fremont platform
> Platform/Sgi: Extend SMBIOS support for RD-Fremont
> Platform/Sgi: Low Power Idle States for RD-Fremont
> Platform/Sgi: Add CPPC support for RD-Fremont platform
>
> Shriram K (1):
> Platform/Sgi: Add ACPI tables for RD-Fremont platform
>
> Vivek Gautam (1):
> Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64
>
> Platform/ARM/SgiPkg/SgiPlatform.dec | 3 +-
> Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc | 8 +-
> Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc | 8 +-
> Platform/ARM/SgiPkg/{SgiMemoryMap2.dsc.inc => SgiMemoryMap3.dsc.inc} | 88 ++--
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 12 +-
> Platform/ARM/SgiPkg/RdE1Edge/RdE1Edge.dsc | 4 +-
> Platform/ARM/SgiPkg/{RdV1/RdV1.dsc => RdFremont/RdFremont.dsc} | 14 +-
> Platform/ARM/SgiPkg/RdN1Edge/RdN1Edge.dsc | 4 +-
> Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc | 4 +-
> Platform/ARM/SgiPkg/RdV1/RdV1.dsc | 4 +-
> Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc | 4 +-
> Platform/ARM/SgiPkg/Sgi575/Sgi575.dsc | 4 +-
> Platform/ARM/SgiPkg/SgiPlatform.fdf | 4 +-
> Platform/ARM/SgiPkg/AcpiTables/RdFremontAcpiTables.inf | 75 +++
> Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf | 5 +-
> Platform/ARM/SgiPkg/Include/SgiPlatform.h | 5 +
> Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c | 5 +-
> Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c | 5 +-
> Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c | 1 +
> Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c | 6 +
> Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c | 25 +-
> Platform/ARM/SgiPkg/AcpiTables/RdFremont/Dsdt.asl | 512 ++++++++++++++++++++
> Platform/ARM/SgiPkg/AcpiTables/RdFremont/Madt.aslc | 138 ++++++
> Platform/ARM/SgiPkg/AcpiTables/RdFremont/Pptt.aslc | 167 +++++++
> Platform/ARM/SgiPkg/RdFremont/RdFremont.fdf.inc | 10 +
> 25 files changed, 1032 insertions(+), 83 deletions(-)
> copy Platform/ARM/SgiPkg/{SgiMemoryMap2.dsc.inc => SgiMemoryMap3.dsc.inc} (62%)
> copy Platform/ARM/SgiPkg/{RdV1/RdV1.dsc => RdFremont/RdFremont.dsc} (77%)
> create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdFremontAcpiTables.inf
> create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdFremont/Dsdt.asl
> create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdFremont/Madt.aslc
> create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdFremont/Pptt.aslc
> create mode 100644 Platform/ARM/SgiPkg/RdFremont/RdFremont.fdf.inc
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113817): https://edk2.groups.io/g/devel/message/113817
Mute This Topic: https://groups.io/mt/103685111/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-