[edk2-devel] [edk2-platforms][PATCH V4 0/4] Add support to parse NT_FW_CONFIG

sahil posted 4 patches 3 months, 3 weeks ago
Failed in applying to current master (apply log)
Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec                                                 |   8 +-
Platform/ARM/N1Sdp/N1SdpPlatform.dsc                                                        |   5 +-
Platform/ARM/N1Sdp/N1SdpPlatform.fdf                                                        |   3 +-
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |   6 +-
Platform/ARM/N1Sdp/Drivers/N1SdpNtFwConfigPei/NtFwConfigPei.inf                             |  41 ++++++
Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.inf                               |   4 +-
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h      |   5 +-
Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h                                           |  14 +--
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      |  33 ++---
Platform/ARM/N1Sdp/Drivers/N1SdpNtFwConfigPei/NtFwConfigPei.c                               | 132 ++++++++++++++++++++
Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c                                 |  12 +-
Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c                              |  35 ++++--
Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/AArch64/Helper.S                              |   4 +-
13 files changed, 263 insertions(+), 39 deletions(-)
create mode 100644 Platform/ARM/N1Sdp/Drivers/N1SdpNtFwConfigPei/NtFwConfigPei.inf
create mode 100644 Platform/ARM/N1Sdp/Drivers/N1SdpNtFwConfigPei/NtFwConfigPei.c
[edk2-devel] [edk2-platforms][PATCH V4 0/4] Add support to parse NT_FW_CONFIG
Posted by sahil 3 months, 3 weeks ago
NT_FW_CONFIG DTB contains platform information passed by Tf-A boot stage.
This information is used for Virtual memory map generation during PEI phase
and passed on to DXE phase as a HOB, where it is used in
ConfigurationManagerDxe.

This patch adds a PEI to parse NT_FW_CONFIG and pass it to other
PEI modules(as PPI) and DXE modules(as HOB).

v4:
     - Fixed code review comments
     - Split the patch into four patches

sahil (4):
  Silicon/ARM/NeoverseN1Soc: Extract NT_FW_CONFIG address passed by TF-A
  Platform/ARM/N1Sdp: Add N1SdpNtFwConfigPei PEI module
  Platform/ARM/N1Sdp: Enable N1SdpNtFwConfigPei PEI module for N1Sdp
  Silicon/ARM/NeoverseN1Soc: Consume N1SdpNtFwConfigPei supplied data

 Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec                                                 |   8 +-
 Platform/ARM/N1Sdp/N1SdpPlatform.dsc                                                        |   5 +-
 Platform/ARM/N1Sdp/N1SdpPlatform.fdf                                                        |   3 +-
 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |   6 +-
 Platform/ARM/N1Sdp/Drivers/N1SdpNtFwConfigPei/NtFwConfigPei.inf                             |  41 ++++++
 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.inf                               |   4 +-
 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h      |   5 +-
 Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h                                           |  14 +--
 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      |  33 ++---
 Platform/ARM/N1Sdp/Drivers/N1SdpNtFwConfigPei/NtFwConfigPei.c                               | 132 ++++++++++++++++++++
 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c                                 |  12 +-
 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c                              |  35 ++++--
 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/AArch64/Helper.S                              |   4 +-
 13 files changed, 263 insertions(+), 39 deletions(-)
 create mode 100644 Platform/ARM/N1Sdp/Drivers/N1SdpNtFwConfigPei/NtFwConfigPei.inf
 create mode 100644 Platform/ARM/N1Sdp/Drivers/N1SdpNtFwConfigPei/NtFwConfigPei.c

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113163): https://edk2.groups.io/g/devel/message/113163
Mute This Topic: https://groups.io/mt/103521642/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH V4 0/4] Add support to parse NT_FW_CONFIG
Posted by Sami Mujawar 3 months, 1 week ago
Hi Sahil,
On Thu, Jan 4, 2024 at 05:16 AM, sahil wrote:

> 
> v4:
> - Fixed code review comments
> - Split the patch into four patches

Can you add git notes for the patches in the future, please? See https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-30
Also, it would be of great help if you can add a link to the edk2 mailing list discussion that has taken place. I normally do that as it helps the maintainer locate the previous discussion easily.

For now, can you reply to the individual patches with the links to the previous discussion, please?

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114042): https://edk2.groups.io/g/devel/message/114042
Mute This Topic: https://groups.io/mt/103521642/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-