1. Patchew
  2. EDK2
  3. [edk2-devel] [PATCH v2 0/14] Redfish related fixes and improvements
  4. View patch

[edk2-devel] [PATCH v2 08/14] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService

Mike Maslenkin posted 14 patches 2 years, 1 month ago
Only 13 patches received!
There is a newer version of this series
[edk2-devel] [PATCH v2 08/14] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService
Posted by Mike Maslenkin 2 years, 1 month ago 
Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
---
 EmulatorPkg/EmulatorPkg.dec                          |  8 ++++----
 .../RedfishPlatformCredentialLib.c                   | 12 ++++++------
 .../RedfishPlatformCredentialLib.inf                 |  8 ++++----
 3 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec
index fe81652b0478..c2a92923e9b7 100644
--- a/EmulatorPkg/EmulatorPkg.dec
+++ b/EmulatorPkg/EmulatorPkg.dec
@@ -77,15 +77,15 @@
   ## Platform level Redfish Service control PCD
   # These PCDs are used to stop the Redfish sevice when secure boot is disabled
   # or exit boot service.
-  gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled|TRUE|BOOLEAN|0x00001020
-  gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService|TRUE|BOOLEAN|0x00001021
+  gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled|TRUE|BOOLEAN|0x00001020
+  gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService|TRUE|BOOLEAN|0x00001021
   ##
   # edk2 Redfish implementation on Emulator package is designed to access
   # to Redfish simulator.
   # https://github.com/DMTF/Redfish-Profile-Simulator
   # The user ID and password are fixed as below.
-  gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId|"admin"|VOID*|0x00001022
-  gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword|"pwd123456"|VOID*|0x00001023
+  gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId|"admin"|VOID*|0x00001022
+  gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword|"pwd123456"|VOID*|0x00001023
   gEmulatorPkgTokenSpaceGuid.PcdPersistentMemorySize|0x4000000|UINT32|0x00001024
 
 [PcdsFixedAtBuild, PcdsPatchableInModule]
diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c
index 614eaebb0d0e..5c167fcdea56 100644
--- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c
+++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c
@@ -57,8 +57,8 @@ GetRedfishCredential (
   //
   // User ID and Password.
   //
-  UserIdSize   = AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServieUserId));
-  PasswordSize = AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiePassword));
+  UserIdSize   = AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiceUserId));
+  PasswordSize = AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServicePassword));
   if ((UserIdSize == 0) || (PasswordSize == 0)) {
     DEBUG ((DEBUG_ERROR, "Incorrect string of UserID or Password for REdfish service.\n"));
     return EFI_INVALID_PARAMETER;
@@ -69,7 +69,7 @@ GetRedfishCredential (
     return EFI_OUT_OF_RESOURCES;
   }
 
-  CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServieUserId), UserIdSize);
+  CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServiceUserId), UserIdSize);
 
   *Password = AllocateZeroPool (PasswordSize);
   if (*Password == NULL) {
@@ -77,7 +77,7 @@ GetRedfishCredential (
     return EFI_OUT_OF_RESOURCES;
   }
 
-  CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServiePassword), PasswordSize);
+  CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServicePassword), PasswordSize);
   return EFI_SUCCESS;
 }
 
@@ -177,7 +177,7 @@ LibStopRedfishService (
     // Check platform PCD to determine the action for stopping
     // Redfish service due to secure boot is disabled.
     //
-    if (!PcdGetBool (PcdRedfishServieStopIfSecureBootDisabled)) {
+    if (!PcdGetBool (PcdRedfishServiceStopIfSecureBootDisabled)) {
       return EFI_UNSUPPORTED;
     } else {
       //
@@ -198,7 +198,7 @@ LibStopRedfishService (
     // Check platform PCD to determine the action for stopping
     // Redfish service due to exit boot service.
     //
-    if (PcdGetBool (PcdRedfishServieStopIfExitbootService)) {
+    if (PcdGetBool (PcdRedfishServiceStopIfExitbootService)) {
       return EFI_UNSUPPORTED;
     } else {
       mStopRedfishService = TRUE;
diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.inf b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.inf
index 41c389c4a292..9d151f14ee17 100644
--- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.inf
+++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.inf
@@ -36,10 +36,10 @@
   UefiLib
 
 [Pcd]
-  gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled ## CONSUMES
-  gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService    ## CONSUMES
-  gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId                   ## CONSUMES
-  gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword                 ## CONSUMES
+  gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled ## CONSUMES
+  gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService    ## CONSUMES
+  gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId                   ## CONSUMES
+  gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword                 ## CONSUMES
 
 [Guids]
   gEfiGlobalVariableGuid
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112557): https://edk2.groups.io/g/devel/message/112557
Mute This Topic: https://groups.io/mt/103181043/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 08/14] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService
Posted by Chang, Abner via groups.io 2 years, 1 month ago 
[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Friday, December 15, 2023 7:25 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH v2 08/14] EmulatorPkg: fix typo. PcdRedfishServie ->
> PcdRedfishService
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
>  EmulatorPkg/EmulatorPkg.dec                          |  8 ++++----
>  .../RedfishPlatformCredentialLib.c                   | 12 ++++++------
>  .../RedfishPlatformCredentialLib.inf                 |  8 ++++----
>  3 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec
> index fe81652b0478..c2a92923e9b7 100644
> --- a/EmulatorPkg/EmulatorPkg.dec
> +++ b/EmulatorPkg/EmulatorPkg.dec
> @@ -77,15 +77,15 @@
>    ## Platform level Redfish Service control PCD
>
>    # These PCDs are used to stop the Redfish sevice when secure boot is
> disabled
>
>    # or exit boot service.
>
> -
> gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled|TR
> UE|BOOLEAN|0x00001020
>
> -
> gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService|TRUE|
> BOOLEAN|0x00001021
>
> +
> gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled|T
> RUE|BOOLEAN|0x00001020
>
> +
> gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService|TRUE|
> BOOLEAN|0x00001021
>
>    ##
>
>    # edk2 Redfish implementation on Emulator package is designed to access
>
>    # to Redfish simulator.
>
>    # https://github.com/DMTF/Redfish-Profile-Simulator
>
>    # The user ID and password are fixed as below.
>
> -
> gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId|"admin"|VOID*|0x00
> 001022
>
> -
> gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword|"pwd123456"|VOI
> D*|0x00001023
>
> +
> gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId|"admin"|VOID*|0x0
> 0001022
>
> +
> gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword|"pwd123456"|V
> OID*|0x00001023
>
>
> gEmulatorPkgTokenSpaceGuid.PcdPersistentMemorySize|0x4000000|UINT3
> 2|0x00001024
>
>
>
>  [PcdsFixedAtBuild, PcdsPatchableInModule]
>
> diff --git
> a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden
> tialLib.c
> b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden
> tialLib.c
> index 614eaebb0d0e..5c167fcdea56 100644
> ---
> a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden
> tialLib.c
> +++
> b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden
> tialLib.c
> @@ -57,8 +57,8 @@ GetRedfishCredential (
>    //
>
>    // User ID and Password.
>
>    //
>
> -  UserIdSize   = AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServieUserId));
>
> -  PasswordSize = AsciiStrSize ((CHAR8 *)PcdGetPtr
> (PcdRedfishServiePassword));
>
> +  UserIdSize   = AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiceUserId));
>
> +  PasswordSize = AsciiStrSize ((CHAR8 *)PcdGetPtr
> (PcdRedfishServicePassword));
>
>    if ((UserIdSize == 0) || (PasswordSize == 0)) {
>
>      DEBUG ((DEBUG_ERROR, "Incorrect string of UserID or Password for
> REdfish service.\n"));
>
>      return EFI_INVALID_PARAMETER;
>
> @@ -69,7 +69,7 @@ GetRedfishCredential (
>      return EFI_OUT_OF_RESOURCES;
>
>    }
>
>
>
> -  CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServieUserId),
> UserIdSize);
>
> +  CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServiceUserId),
> UserIdSize);
>
>
>
>    *Password = AllocateZeroPool (PasswordSize);
>
>    if (*Password == NULL) {
>
> @@ -77,7 +77,7 @@ GetRedfishCredential (
>      return EFI_OUT_OF_RESOURCES;
>
>    }
>
>
>
> -  CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServiePassword),
> PasswordSize);
>
> +  CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServicePassword),
> PasswordSize);
>
>    return EFI_SUCCESS;
>
>  }
>
>
>
> @@ -177,7 +177,7 @@ LibStopRedfishService (
>      // Check platform PCD to determine the action for stopping
>
>      // Redfish service due to secure boot is disabled.
>
>      //
>
> -    if (!PcdGetBool (PcdRedfishServieStopIfSecureBootDisabled)) {
>
> +    if (!PcdGetBool (PcdRedfishServiceStopIfSecureBootDisabled)) {
>
>        return EFI_UNSUPPORTED;
>
>      } else {
>
>        //
>
> @@ -198,7 +198,7 @@ LibStopRedfishService (
>      // Check platform PCD to determine the action for stopping
>
>      // Redfish service due to exit boot service.
>
>      //
>
> -    if (PcdGetBool (PcdRedfishServieStopIfExitbootService)) {
>
> +    if (PcdGetBool (PcdRedfishServiceStopIfExitbootService)) {
>
>        return EFI_UNSUPPORTED;
>
>      } else {
>
>        mStopRedfishService = TRUE;
>
> diff --git
> a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden
> tialLib.inf
> b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden
> tialLib.inf
> index 41c389c4a292..9d151f14ee17 100644
> ---
> a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden
> tialLib.inf
> +++
> b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden
> tialLib.inf
> @@ -36,10 +36,10 @@
>    UefiLib
>
>
>
>  [Pcd]
>
> -  gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled
> ## CONSUMES
>
> -  gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService    ##
> CONSUMES
>
> -  gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId                   ##
> CONSUMES
>
> -  gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword                 ##
> CONSUMES
>
> +  gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled
> ## CONSUMES
>
> +  gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService    ##
> CONSUMES
>
> +  gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId                   ##
> CONSUMES
>
> +  gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword                 ##
> CONSUMES
>
>
>
>  [Guids]
>
>    gEfiGlobalVariableGuid
>
> --
> 2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112626): https://edk2.groups.io/g/devel/message/112626
Mute This Topic: https://groups.io/mt/103181043/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.