From nobody Mon Feb 9 07:55:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112557+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112557+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702596310; cv=none; d=zohomail.com; s=zohoarc; b=naObxbIwC5pRFvNd4J1iyEo0pWz/ZL9ag6+BahnHmO78XBEtSl4N5gEvyl2GaRskh6/JENTaivbY+3N0xY/ljxR7bEzegh20zowl28Ytzp88HtnEpPkdM6NlydJ4VEcTnmiZh0f+XQ637mBLOlDkJnsDUGoAXGgJENhLR6sPnJg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702596310; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=zeTgAPPRaEEx2Dngi5NbiZq6RtyOa7bOW9EIUKIaDbI=; b=Z/vkOIwebLLs4HW96epLARQb/2FBA1vZckXOYVNcizqMUQbyoKZbqrmCvB18kQS4aqyWM5irleOgUAMoQN8cFT3iiwuBb9q80fZ3SH4ccX45ieB3KxNhSarFvHyClWv/i9Ct/LpognF7DLOPlANOxVXCfXJDqbEWmDdgPNig+g8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112557+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702596310873794.1970094789176; Thu, 14 Dec 2023 15:25:10 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=8MJCIIAHvgXCa/BWGm1fvMB22TeiKxxkjLTz8Uhvl+o=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702596310; v=1; b=Tax2tQD4+E3gTOvBVE0oqHPqcuO5fzAM2lZFWjoXUsMlGZH8oLK8YZJ06hhVoXI478gtrkKM tQZA1XAqwlHGZ6iWwQ0QyPrX/8mSjpG3rmll97/OV9e8+efUN44V9tx/WZyl04RYCtQ+CWM8ktd trZ0pR8hx7jw01OSm4Wt8qBA= X-Received: by 127.0.0.2 with SMTP id nvWhYY1788612xWcqIGloY0x; Thu, 14 Dec 2023 15:25:10 -0800 X-Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mx.groups.io with SMTP id smtpd.web11.44955.1702596309702655150 for ; Thu, 14 Dec 2023 15:25:10 -0800 X-Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-50c0f6b1015so28359e87.3 for ; Thu, 14 Dec 2023 15:25:09 -0800 (PST) X-Gm-Message-State: cK4PdFirYAi6qzWg4OprmwoQx1787277AA= X-Google-Smtp-Source: AGHT+IGCV6B6kxhwUQHMIQaxmXMO8saqoMWdEMh0/LYd/ZdvxX3baxPasJj50YrCZAzcjmwCkbaRGg== X-Received: by 2002:a05:6512:348a:b0:50b:f0b2:70d8 with SMTP id v10-20020a056512348a00b0050bf0b270d8mr4594477lfr.101.1702596307879; Thu, 14 Dec 2023 15:25:07 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id j24-20020ac24558000000b0050bfe5815e7sm1973119lfm.165.2023.12.14.15.25.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 14 Dec 2023 15:25:07 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v2 08/14] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService Date: Fri, 15 Dec 2023 02:24:52 +0300 Message-Id: <20231214232458.4636-9-mike.maslenkin@gmail.com> In-Reply-To: <20231214232458.4636-1-mike.maslenkin@gmail.com> References: <20231214232458.4636-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702596312253100035 Content-Type: text/plain; charset="utf-8" Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- EmulatorPkg/EmulatorPkg.dec | 8 ++++---- .../RedfishPlatformCredentialLib.c | 12 ++++++------ .../RedfishPlatformCredentialLib.inf | 8 ++++---- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec index fe81652b0478..c2a92923e9b7 100644 --- a/EmulatorPkg/EmulatorPkg.dec +++ b/EmulatorPkg/EmulatorPkg.dec @@ -77,15 +77,15 @@ ## Platform level Redfish Service control PCD # These PCDs are used to stop the Redfish sevice when secure boot is dis= abled # or exit boot service. - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled|TRUE= |BOOLEAN|0x00001020 - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService|TRUE|BO= OLEAN|0x00001021 + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled|TRU= E|BOOLEAN|0x00001020 + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService|TRUE|B= OOLEAN|0x00001021 ## # edk2 Redfish implementation on Emulator package is designed to access # to Redfish simulator. # https://github.com/DMTF/Redfish-Profile-Simulator # The user ID and password are fixed as below. - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId|"admin"|VOID*|0x000010= 22 - gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword|"pwd123456"|VOID*|0x= 00001023 + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId|"admin"|VOID*|0x00001= 022 + gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword|"pwd123456"|VOID*|0= x00001023 gEmulatorPkgTokenSpaceGuid.PcdPersistentMemorySize|0x4000000|UINT32|0x00= 001024 =20 [PcdsFixedAtBuild, PcdsPatchableInModule] diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatfo= rmCredentialLib.c b/EmulatorPkg/Library/RedfishPlatformCredentialLib/Redfis= hPlatformCredentialLib.c index 614eaebb0d0e..5c167fcdea56 100644 --- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.c +++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.c @@ -57,8 +57,8 @@ GetRedfishCredential ( // // User ID and Password. // - UserIdSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServieUserI= d)); - PasswordSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiePassw= ord)); + UserIdSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiceUser= Id)); + PasswordSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServicePass= word)); if ((UserIdSize =3D=3D 0) || (PasswordSize =3D=3D 0)) { DEBUG ((DEBUG_ERROR, "Incorrect string of UserID or Password for REdfi= sh service.\n")); return EFI_INVALID_PARAMETER; @@ -69,7 +69,7 @@ GetRedfishCredential ( return EFI_OUT_OF_RESOURCES; } =20 - CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServieUserId), UserIdSiz= e); + CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServiceUserId), UserIdSi= ze); =20 *Password =3D AllocateZeroPool (PasswordSize); if (*Password =3D=3D NULL) { @@ -77,7 +77,7 @@ GetRedfishCredential ( return EFI_OUT_OF_RESOURCES; } =20 - CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServiePassword), Passw= ordSize); + CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServicePassword), Pass= wordSize); return EFI_SUCCESS; } =20 @@ -177,7 +177,7 @@ LibStopRedfishService ( // Check platform PCD to determine the action for stopping // Redfish service due to secure boot is disabled. // - if (!PcdGetBool (PcdRedfishServieStopIfSecureBootDisabled)) { + if (!PcdGetBool (PcdRedfishServiceStopIfSecureBootDisabled)) { return EFI_UNSUPPORTED; } else { // @@ -198,7 +198,7 @@ LibStopRedfishService ( // Check platform PCD to determine the action for stopping // Redfish service due to exit boot service. // - if (PcdGetBool (PcdRedfishServieStopIfExitbootService)) { + if (PcdGetBool (PcdRedfishServiceStopIfExitbootService)) { return EFI_UNSUPPORTED; } else { mStopRedfishService =3D TRUE; diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatfo= rmCredentialLib.inf b/EmulatorPkg/Library/RedfishPlatformCredentialLib/Redf= ishPlatformCredentialLib.inf index 41c389c4a292..9d151f14ee17 100644 --- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.inf +++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.inf @@ -36,10 +36,10 @@ UefiLib =20 [Pcd] - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled ## C= ONSUMES - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService ## C= ONSUMES - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId ## C= ONSUMES - gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword ## C= ONSUMES + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled ## = CONSUMES + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService ## = CONSUMES + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId ## = CONSUMES + gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword ## = CONSUMES =20 [Guids] gEfiGlobalVariableGuid --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112557): https://edk2.groups.io/g/devel/message/112557 Mute This Topic: https://groups.io/mt/103181043/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-