ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 5 ++-- EmbeddedPkg/Include/Library/RealTimeClockLib.h | 15 ------------ EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c | 24 -------------------- EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 18 --------------- PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 5 ++-- 5 files changed, 6 insertions(+), 61 deletions(-)
https://bugzilla.tianocore.org/show_bug.cgi?id=4564
The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly
declares a function called LibRtcVirtualNotifyEvent(). No component ever
calls this function across module boundaries; all RealTimeClockLib
instances in edk2 and edk2-platforms are supposed to register -- and do
register -- their SetVirtualAddressMap() notification functions.
After the edk2-platforms and edk2-non-osi changes, we can repeat the
procedure form the edk2-platforms series in edk2. In those
RealTimeClockLib instances that define LibRtcVirtualNotifyEvent(),
demonstrate that either (a) the usage is module-internal, or (b) there
is no usage. In case (a), rename LibRtcVirtualNotifyEvent() to
VirtualNotifyEvent(), and make it static. In case (b), remove the
function definition.
There is a superficial name match in
PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe. Note that that module is a
*driver*, not a library instance; what's more,
PcatRealTimeClockRuntimeDxe does not depend on "EmbeddedPkg.dec" at all.
Treat that module too as case (a), right at the front of the series.
Finally, drop the LibRtcVirtualNotifyEvent() API declaration.
Cc: Abner Chang <abner.chang@amd.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Daniel Schaefer <git@danielschaefer.me>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ray Ni <ray.ni@intel.com>
Thanks
Laszlo
Laszlo Ersek (5):
PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename
LibRtcVirtualNotifyEvent
ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent
EmbeddedPkg/TemplateRealTimeClockLib: drop LibRtcVirtualNotifyEvent
EmbeddedPkg/VirtualRealTimeClockLib: drop LibRtcVirtualNotifyEvent
EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib
class
ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 5 ++--
EmbeddedPkg/Include/Library/RealTimeClockLib.h | 15 ------------
EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c | 24 --------------------
EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 18 ---------------
PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 5 ++--
5 files changed, 6 insertions(+), 61 deletions(-)
base-commit: 95c9f470ca6eab23bfd016bd438f932d7263d395
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109563): https://edk2.groups.io/g/devel/message/109563
Mute This Topic: https://groups.io/mt/101914677/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
On 10/12/23 11:10, Laszlo Ersek wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=4564 > > The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly > declares a function called LibRtcVirtualNotifyEvent(). No component ever > calls this function across module boundaries; all RealTimeClockLib > instances in edk2 and edk2-platforms are supposed to register -- and do > register -- their SetVirtualAddressMap() notification functions. > > After the edk2-platforms and edk2-non-osi changes, we can repeat the > procedure form the edk2-platforms series in edk2. In those > RealTimeClockLib instances that define LibRtcVirtualNotifyEvent(), > demonstrate that either (a) the usage is module-internal, or (b) there > is no usage. In case (a), rename LibRtcVirtualNotifyEvent() to > VirtualNotifyEvent(), and make it static. In case (b), remove the > function definition. > > There is a superficial name match in > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe. Note that that module is a > *driver*, not a library instance; what's more, > PcatRealTimeClockRuntimeDxe does not depend on "EmbeddedPkg.dec" at all. > Treat that module too as case (a), right at the front of the series. > > Finally, drop the LibRtcVirtualNotifyEvent() API declaration. > > Cc: Abner Chang <abner.chang@amd.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Daniel Schaefer <git@danielschaefer.me> > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > Cc: Ray Ni <ray.ni@intel.com> Can I get an ACK for the last three (EmbeddedPkg) patches? Thanks Laszlo > > Thanks > Laszlo > > Laszlo Ersek (5): > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename > LibRtcVirtualNotifyEvent > ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent > EmbeddedPkg/TemplateRealTimeClockLib: drop LibRtcVirtualNotifyEvent > EmbeddedPkg/VirtualRealTimeClockLib: drop LibRtcVirtualNotifyEvent > EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib > class > > ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 5 ++-- > EmbeddedPkg/Include/Library/RealTimeClockLib.h | 15 ------------ > EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c | 24 -------------------- > EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 18 --------------- > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 5 ++-- > 5 files changed, 6 insertions(+), 61 deletions(-) > > > base-commit: 95c9f470ca6eab23bfd016bd438f932d7263d395 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109751): https://edk2.groups.io/g/devel/message/109751 Mute This Topic: https://groups.io/mt/101914677/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Wed, 18 Oct 2023 at 15:43, Laszlo Ersek <lersek@redhat.com> wrote: > > On 10/12/23 11:10, Laszlo Ersek wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=4564 > > > > The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly > > declares a function called LibRtcVirtualNotifyEvent(). No component ever > > calls this function across module boundaries; all RealTimeClockLib > > instances in edk2 and edk2-platforms are supposed to register -- and do > > register -- their SetVirtualAddressMap() notification functions. > > > > After the edk2-platforms and edk2-non-osi changes, we can repeat the > > procedure form the edk2-platforms series in edk2. In those > > RealTimeClockLib instances that define LibRtcVirtualNotifyEvent(), > > demonstrate that either (a) the usage is module-internal, or (b) there > > is no usage. In case (a), rename LibRtcVirtualNotifyEvent() to > > VirtualNotifyEvent(), and make it static. In case (b), remove the > > function definition. > > > > There is a superficial name match in > > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe. Note that that module is a > > *driver*, not a library instance; what's more, > > PcatRealTimeClockRuntimeDxe does not depend on "EmbeddedPkg.dec" at all. > > Treat that module too as case (a), right at the front of the series. > > > > Finally, drop the LibRtcVirtualNotifyEvent() API declaration. > > > > Cc: Abner Chang <abner.chang@amd.com> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > Cc: Daniel Schaefer <git@danielschaefer.me> > > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > > Cc: Ray Ni <ray.ni@intel.com> > > Can I get an ACK for the last three (EmbeddedPkg) patches? > For the series, Reviewed-by: Ard Biesheuvel <ardb@kernel.org> > > > > Laszlo Ersek (5): > > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename > > LibRtcVirtualNotifyEvent > > ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent > > EmbeddedPkg/TemplateRealTimeClockLib: drop LibRtcVirtualNotifyEvent > > EmbeddedPkg/VirtualRealTimeClockLib: drop LibRtcVirtualNotifyEvent > > EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib > > class > > > > ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 5 ++-- > > EmbeddedPkg/Include/Library/RealTimeClockLib.h | 15 ------------ > > EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c | 24 -------------------- > > EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 18 --------------- > > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 5 ++-- > > 5 files changed, 6 insertions(+), 61 deletions(-) > > > > > > base-commit: 95c9f470ca6eab23bfd016bd438f932d7263d395 > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109752): https://edk2.groups.io/g/devel/message/109752 Mute This Topic: https://groups.io/mt/101914677/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 10/18/23 15:44, Ard Biesheuvel wrote: > On Wed, 18 Oct 2023 at 15:43, Laszlo Ersek <lersek@redhat.com> wrote: >> >> On 10/12/23 11:10, Laszlo Ersek wrote: >>> https://bugzilla.tianocore.org/show_bug.cgi?id=4564 >>> >>> The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly >>> declares a function called LibRtcVirtualNotifyEvent(). No component ever >>> calls this function across module boundaries; all RealTimeClockLib >>> instances in edk2 and edk2-platforms are supposed to register -- and do >>> register -- their SetVirtualAddressMap() notification functions. >>> >>> After the edk2-platforms and edk2-non-osi changes, we can repeat the >>> procedure form the edk2-platforms series in edk2. In those >>> RealTimeClockLib instances that define LibRtcVirtualNotifyEvent(), >>> demonstrate that either (a) the usage is module-internal, or (b) there >>> is no usage. In case (a), rename LibRtcVirtualNotifyEvent() to >>> VirtualNotifyEvent(), and make it static. In case (b), remove the >>> function definition. >>> >>> There is a superficial name match in >>> PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe. Note that that module is a >>> *driver*, not a library instance; what's more, >>> PcatRealTimeClockRuntimeDxe does not depend on "EmbeddedPkg.dec" at all. >>> Treat that module too as case (a), right at the front of the series. >>> >>> Finally, drop the LibRtcVirtualNotifyEvent() API declaration. >>> >>> Cc: Abner Chang <abner.chang@amd.com> >>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> >>> Cc: Daniel Schaefer <git@danielschaefer.me> >>> Cc: Leif Lindholm <quic_llindhol@quicinc.com> >>> Cc: Ray Ni <ray.ni@intel.com> >> >> Can I get an ACK for the last three (EmbeddedPkg) patches? >> > > For the series, > > Reviewed-by: Ard Biesheuvel <ardb@kernel.org> Merged via <https://github.com/tianocore/edk2/pull/4926>; commit range 747a08eae26b..7fe49887c4d2. Thank you! Laszlo > >>> >>> Laszlo Ersek (5): >>> PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename >>> LibRtcVirtualNotifyEvent >>> ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent >>> EmbeddedPkg/TemplateRealTimeClockLib: drop LibRtcVirtualNotifyEvent >>> EmbeddedPkg/VirtualRealTimeClockLib: drop LibRtcVirtualNotifyEvent >>> EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib >>> class >>> >>> ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 5 ++-- >>> EmbeddedPkg/Include/Library/RealTimeClockLib.h | 15 ------------ >>> EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c | 24 -------------------- >>> EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 18 --------------- >>> PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 5 ++-- >>> 5 files changed, 6 insertions(+), 61 deletions(-) >>> >>> >>> base-commit: 95c9f470ca6eab23bfd016bd438f932d7263d395 >>> >>> >>> >>> >>> >> >> >> >> >> >> > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109765): https://edk2.groups.io/g/devel/message/109765 Mute This Topic: https://groups.io/mt/101914677/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.