From nobody Sat May 18 10:48:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109562+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109562+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101863; cv=none; d=zohomail.com; s=zohoarc; b=QdYiEJsNPXampkgMYgWP4ogpDqDrGbYaE1KE5196NCJxQ/X2Be+KSU8U299mwTK/P/ZNptuvmRCEAJd2FSR+V9Gaz5GLbsKqTxUjfDG1dUxxqWxDAcYhYHgPq1QrJJxdQ+c3Wc6sraDFfQ52a4Ixe/04wOj/HFSkzeMKJPdWrjg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101863; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=SLLtJkfE6EvAIwRXC/5x+jk5xDkdKaav2VGHW+coJL8=; b=ZSBmBCAmXHr+x9r9XYDthL3z7IPbtsHRWonQxO2nwvb712jLX17n5ax5OCLVovpoaqkMX4Qn5U4ei4yWc1alRmiAlEkPWeeN4nEsbaYcmSkIWfEMsW+g5CtWm+ENwmpdPktTlRz7gfmnSVpJ9mU8kXXgG6v8gEKwi5nll0YkxqY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109562+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101863685975.7795993906242; Thu, 12 Oct 2023 02:11:03 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=SLLtJkfE6EvAIwRXC/5x+jk5xDkdKaav2VGHW+coJL8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101863; v=1; b=bRUyiCb0pBd0I9gmktCMiAtAfQ96ZdPTsZr0gNxwcw2WEgVdlzDnNbGBm3tROh2PcS2I0SQG Kzjq61JPBg/T78IyItP3TFQc7wX/F5aTemcf79g4fOMBi31HPxpGjQSkzF19ZrRHdHe2J+lura1 senX8FR0rL1IihnrUsyW+erE= X-Received: by 127.0.0.2 with SMTP id CEnpYY1788612xuFpdX7xdEF; Thu, 12 Oct 2023 02:11:03 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.7214.1697101862743993948 for ; Thu, 12 Oct 2023 02:11:02 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-142-az58jJ95MUivKaDsni18Tw-1; Thu, 12 Oct 2023 05:11:00 -0400 X-MC-Unique: az58jJ95MUivKaDsni18Tw-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 421621C06EC6; Thu, 12 Oct 2023 09:11:00 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id A773A40C6F7F; Thu, 12 Oct 2023 09:10:59 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ray Ni Subject: [edk2-devel] [PATCH 1/5] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent Date: Thu, 12 Oct 2023 11:10:53 +0200 Message-Id: <20231012091057.108728-2-lersek@redhat.com> In-Reply-To: <20231012091057.108728-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012091057.108728-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: oeW7nZlk2AyXz3uxYFFD07bGx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101865645100005 Content-Type: text/plain; charset="utf-8"; x-default="true" PcatRealTimeClockRuntimeDxe seems to have copied the interface name LibRtcVirtualNotifyEvent() from EmbeddedPkg's RealTimeClockLib class. That's not right, for two reasons: - PcatRealTimeClockRuntimeDxe doesn't consume "EmbeddedPkg.dec" in the first place, - in EmbeddedPkg, the RealTimeClockLib class API LibRtcVirtualNotifyEvent() is about to be eliminated (it's a bogus API). Rename the LibRtcVirtualNotifyEvent() function to VirtualNotifyEvent(), and make it static. Tested with booting OVMF. Cc: Ray Ni Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar Tested-by: Sami Mujawar --- PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c b/PcAt= ChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c index b600df487952..ca0cad9b0198 100644 --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c @@ -122,9 +122,10 @@ PcRtcEfiSetWakeupTime ( @param[in] Event The Event that is being processed @param[in] Context Event Context **/ +STATIC VOID EFIAPI -LibRtcVirtualNotifyEvent ( +VirtualNotifyEvent ( IN EFI_EVENT Event, IN VOID *Context ) @@ -220,7 +221,7 @@ InitializePcRtc ( Status =3D gBS->CreateEventEx ( EVT_NOTIFY_SIGNAL, TPL_NOTIFY, - LibRtcVirtualNotifyEvent, + VirtualNotifyEvent, NULL, &gEfiEventVirtualAddressChangeGuid, &mVirtualAddrChangeEvent -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109562): https://edk2.groups.io/g/devel/message/109562 Mute This Topic: https://groups.io/mt/101914676/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 10:48:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109564+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109564+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101866; cv=none; d=zohomail.com; s=zohoarc; b=KnEVdh9Gdeux8gINoVsT1oUSMa4AZEtLUtS1HvgduBQnE3KqCmyFSW7XPoFlMuXkc/OZlNKfpteniOjzb/ArEDN062LEu0kik64ub4B5iBbVuJbxQ7C2CbLW8aNve8dIf51JkETrzvVY0L7VULsnZ6z3A2OE1T4cqG9o1xdK6I8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101866; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=4Twk+r2suV1LDyOGWK0yVRUbijtIhguZUd01hrCugbU=; b=RInW1Ti+XU3G9WHbYOAmEb5+OICDEde+sjOLTXMHP5tmgJJqzh5emoiPY5BbH5IVZdPqGSvAvVdmJgp2LXbUkWCSd0pgGDkLAdGRfzZVXXn0TpHzRZy8gd8L1UYoTVQ0DcteGlYf/kKOmJoP1jHc4HgIbnpcqFkrmA5ONRbqpB4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109564+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101866650357.72540638003807; Thu, 12 Oct 2023 02:11:06 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=4Twk+r2suV1LDyOGWK0yVRUbijtIhguZUd01hrCugbU=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101866; v=1; b=lJguTdkSYaJyUaO+oovyeYlEG7bmAFUwfEILBDI4h5tyOJzdiFAArbI35Udt+AwjEaSQa2+q VE9ylreKWvFUh+QGMYv1Kk7bj3UP/yQCvgH49sDXOP0/enZFbIZt51PYFwl7BWCW4SB3XxuFflq oDIZ/ySWmGq+w/NuwWSxB8iU= X-Received: by 127.0.0.2 with SMTP id QquMYY1788612xEUrEAEEZ5K; Thu, 12 Oct 2023 02:11:06 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.7112.1697101865687076195 for ; Thu, 12 Oct 2023 02:11:05 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-467-BEsVCQ7fOWybbQL0i-FFfQ-1; Thu, 12 Oct 2023 05:11:01 -0400 X-MC-Unique: BEsVCQ7fOWybbQL0i-FFfQ-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 411F73C0F236; Thu, 12 Oct 2023 09:11:01 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 848C840C6F7F; Thu, 12 Oct 2023 09:11:00 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Leif Lindholm Subject: [edk2-devel] [PATCH 2/5] ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent Date: Thu, 12 Oct 2023 11:10:54 +0200 Message-Id: <20231012091057.108728-3-lersek@redhat.com> In-Reply-To: <20231012091057.108728-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012091057.108728-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9Hp2ndeQwi3vSnKAVfOZOjCrx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101867752100011 Content-Type: text/plain; charset="utf-8"; x-default="true" The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it static, in preparation for removing the LibRtcVirtualNotifyEvent() declaration from the lib class header later. Build- and boot-tested with ArmVirtQemu. Cc: Ard Biesheuvel Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 5 += ++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeCloc= kLib.c b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib= .c index ec7feaeedcf8..9e852696d2fd 100644 --- a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c +++ b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c @@ -274,9 +274,10 @@ LibSetWakeupTime ( @param[in] Event The Event that is being processed @param[in] Context Event Context **/ +STATIC VOID EFIAPI -LibRtcVirtualNotifyEvent ( +VirtualNotifyEvent ( IN EFI_EVENT Event, IN VOID *Context ) @@ -346,7 +347,7 @@ LibRtcInitialize ( Status =3D gBS->CreateEventEx ( EVT_NOTIFY_SIGNAL, TPL_NOTIFY, - LibRtcVirtualNotifyEvent, + VirtualNotifyEvent, NULL, &gEfiEventVirtualAddressChangeGuid, &mRtcVirtualAddrChangeEvent -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109564): https://edk2.groups.io/g/devel/message/109564 Mute This Topic: https://groups.io/mt/101914679/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 10:48:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109565+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109565+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101867; cv=none; d=zohomail.com; s=zohoarc; b=Lx2P47MLyOm7eGZSZlJwU6o+3g+ctuAKTui2SjNs5/tRYJWdM9POVx957Yabm1EVmyYsqV9pcihhh+SeUmWjrHLSgBj23yzDR9lU//E2+MSF9xKM6OR9SzT2gEgDxlh9Jlo4S69zNQQJKUuB8Zo4MX3A3TD/OVIA44QckjQ8svg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101867; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=4FtgdtxajTHa8SlLU9SBIoGbDcTxydGZRly5sHTTr0A=; b=PzHOepqm39CU7Y31EuYepakzpNzq8qRNavjq59y+gLsnwID59diBaYDri/jotUT/FAzJJNGsW17kTb3s1zOgSDHM3T5ilfZa9yQ85hkevHaWlIOmC/n/RPhS7c74yq1evgPUxnKhnysN1XNkCMbwTs09BEFZyKVlkVHx9Q6yhac= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109565+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101867874945.7335913893878; Thu, 12 Oct 2023 02:11:07 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=4FtgdtxajTHa8SlLU9SBIoGbDcTxydGZRly5sHTTr0A=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101867; v=1; b=fWpcqslTQa+c3Ym4vnKO3+/EmehnaezwRzA1OGFSGTCxKERMO1gwmQu0L8K8emA4yTgDVcgO l47sown8HcApAvjpyxVu+FUjgDBn3jncdIZq6aNhv7gCj5iUZ6X0FHq6VURIwU1UGEu64WHeiZz c8jynLGfoE/Bm1iHh89hfG7I= X-Received: by 127.0.0.2 with SMTP id QFMlYY1788612xxQNFXeR6KM; Thu, 12 Oct 2023 02:11:07 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.7114.1697101866946270629 for ; Thu, 12 Oct 2023 02:11:07 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-652-l0pdlC_LPwmKwlOl8QVSDg-1; Thu, 12 Oct 2023 05:11:02 -0400 X-MC-Unique: l0pdlC_LPwmKwlOl8QVSDg-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 85E8780349A; Thu, 12 Oct 2023 09:11:02 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83D7340C6F79; Thu, 12 Oct 2023 09:11:01 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Abner Chang , Ard Biesheuvel , Daniel Schaefer , Leif Lindholm Subject: [edk2-devel] [PATCH 3/5] EmbeddedPkg/TemplateRealTimeClockLib: drop LibRtcVirtualNotifyEvent Date: Thu, 12 Oct 2023 11:10:55 +0200 Message-Id: <20231012091057.108728-4-lersek@redhat.com> In-Reply-To: <20231012091057.108728-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012091057.108728-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: REcBZQogs6QmuVnOIp8FZh6Yx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101869683100018 Content-Type: text/plain; charset="utf-8"; x-default="true" The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. In particular, TemplateRealTimeClockLib *itself* doesn't even use LibRtcVirtualNotifyEvent() -- the function is defined with an empty body, clearly in an understandable, but misguided, attempt, to conform to the (bogus) library interface. Remove the function. Build-tested only (with "EmbeddedPkg.dsc"). Cc: Abner Chang Cc: Ard Biesheuvel Cc: Daniel Schaefer Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel --- EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c | 24 -----= --------------- 1 file changed, 24 deletions(-) diff --git a/EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.= c b/EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c index cb5025914e3f..4e0f52ef7bce 100644 --- a/EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c +++ b/EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c @@ -133,27 +133,3 @@ LibRtcInitialize ( // return EFI_SUCCESS; } - -/** - Fixup internal data so that EFI can be call in virtual mode. - Call the passed in Child Notify event and convert any pointers in - lib to virtual mode. - - @param[in] Event The Event that is being processed - @param[in] Context Event Context -**/ -VOID -EFIAPI -LibRtcVirtualNotifyEvent ( - IN EFI_EVENT Event, - IN VOID *Context - ) -{ - // - // Only needed if you are going to support the OS calling RTC functions = in virtual mode. - // You will need to call EfiConvertPointer (). To convert any stored phy= sical addresses - // to virtual address. After the OS transitions to calling in virtual mo= de, all future - // runtime calls will be made in virtual mode. - // - return; -} -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109565): https://edk2.groups.io/g/devel/message/109565 Mute This Topic: https://groups.io/mt/101914680/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 10:48:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109566+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109566+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101868; cv=none; d=zohomail.com; s=zohoarc; b=f24OhE0zvvUfzK7C2QS+NUN4rG/P/WmiQV30izrfRs21+wI2mRUBJiujQYdbBxo9gOxCny3xLydAbTz2Y6x0R7w/piVqjuhlyhZ6tFyaj/LhxDYFij6LsFEvlpWZNc+QuuMNQHyOVDWfaiI8OxDoiEZKk9Qids/c+GjJI7oTx9M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101868; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=delaF3NQq/6Z5ys+tqxUR/KdcBzx1+eRp++k7j1V0U4=; b=cInUd5TjHd9sqJy/OpzOGO4zGdevpqyp1jQ5+xveX5mq/wqbfqa8w4wGolrxIDCRmAGNCGPeJejt2WfVEiV6wHFYlkJs9/Lz7N21/jiSB2WdBwmo7Wl7ocDZUGkZlk5xTss2UtxJ1urNpK0xMrb60jj1/5u6iCs1yjmAHTZMX6c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109566+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101868405273.8481571046656; Thu, 12 Oct 2023 02:11:08 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=delaF3NQq/6Z5ys+tqxUR/KdcBzx1+eRp++k7j1V0U4=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101868; v=1; b=kJEHOavQ6unI0/crL2JpArZ2drDaPhtNZJDRBRS0GIcZgnZc6fmdzYJVsRFzI7GpQ/t4DuO1 sEo+nBT7Ri/08QaFE3KDabs6TV1w2Fux85PnZI0dzTMi7KSWBu5ju/SxczzoX3D1b9kC0nEqwzG AlYgxT4ithgq+DMOmHSHZprk= X-Received: by 127.0.0.2 with SMTP id ACqaYY1788612xD8wHAGLvqQ; Thu, 12 Oct 2023 02:11:08 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.7115.1697101867424150041 for ; Thu, 12 Oct 2023 02:11:07 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-589-G2g9HCkFP6Wl7FpDpkJHng-1; Thu, 12 Oct 2023 05:11:04 -0400 X-MC-Unique: G2g9HCkFP6Wl7FpDpkJHng-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CAFF51C06EF4; Thu, 12 Oct 2023 09:11:03 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id C862740C6CA2; Thu, 12 Oct 2023 09:11:02 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Abner Chang , Ard Biesheuvel , Daniel Schaefer , Leif Lindholm Subject: [edk2-devel] [PATCH 4/5] EmbeddedPkg/VirtualRealTimeClockLib: drop LibRtcVirtualNotifyEvent Date: Thu, 12 Oct 2023 11:10:56 +0200 Message-Id: <20231012091057.108728-5-lersek@redhat.com> In-Reply-To: <20231012091057.108728-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012091057.108728-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Ie4G3NANAZvKpCq5edRTdcIXx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101869671100017 Content-Type: text/plain; charset="utf-8"; x-default="true" The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. In particular, VirtualRealTimeClockLib *itself* doesn't even use LibRtcVirtualNotifyEvent() -- the function is defined with an empty body, clearly in an understandable, but misguided, attempt, to conform to the (bogus) library interface. Remove the function. Build-tested only (with "RiscVVirtQemu.dsc"). Cc: Abner Chang Cc: Ard Biesheuvel Cc: Daniel Schaefer Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel --- EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 18= ------------------ 1 file changed, 18 deletions(-) diff --git a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClo= ckLib.c b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockL= ib.c index 685e590980ec..ce288d719fba 100644 --- a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c +++ b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c @@ -402,21 +402,3 @@ LibRtcInitialize ( { return EFI_SUCCESS; } - -/** - Fixup internal data so that EFI can be call in virtual mode. - Call the passed in Child Notify event and convert any pointers in - lib to virtual mode. - - @param[in] Event The Event that is being processed - @param[in] Context Event Context -**/ -VOID -EFIAPI -LibRtcVirtualNotifyEvent ( - IN EFI_EVENT Event, - IN VOID *Context - ) -{ - return; -} -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109566): https://edk2.groups.io/g/devel/message/109566 Mute This Topic: https://groups.io/mt/101914681/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 10:48:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109567+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109567+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101872; cv=none; d=zohomail.com; s=zohoarc; b=gmtw+JhdD0YvEGIxIJ1y1rZ0IWzScAsXYkv7gFxpD9FU7kGCYWc9iq+r0Fbkzi+ZdhemcsB1fNNZxHjo3D+iif6QAq9sE+i9jZNyiZZO57/pJAxuyQYGNCZrm1OJIg5v0qM1AtMgOamcr4tZb4rCHs/gBqHvd+uo6fHjS2fyQe4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101872; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=aBnhCcJyU6PUtjf5pcfbKgUk51+kC7GlwbAXD5SpKf8=; b=nLlv1gTnjHA6XCMHF6LEleJ35Xz02dFfMg4WJKyR2Zh4MI4F32nwfDTUpX1zASu4dviPPDqszU/cgTxZlINXT/EuQ4qzY4Nel40nDBC4WJ6cOgRchYD96W880aHbvlR1lXL9cLL0GULqlYCc8vqnSrvjCitBhutiFL+oRpzUSYQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109567+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101872381811.4945373513867; Thu, 12 Oct 2023 02:11:12 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=aBnhCcJyU6PUtjf5pcfbKgUk51+kC7GlwbAXD5SpKf8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101872; v=1; b=YWfvtnN7eXDIDwALoEDih4WSmrf/U5T2lvweiDv/F7/7/Vz6lqthateo07VBCviakX7efJlC q0eSdiyNg5iX3SDo/pv7ea5KDALVGaE8DN5jkPuAfmrDC9tAFs7L4asa+umJrQYkao/xjJO/rZr 9kP+3m3i7/MOYpoGaPDyZGvM= X-Received: by 127.0.0.2 with SMTP id toIqYY1788612xtAdszCTamc; Thu, 12 Oct 2023 02:11:12 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.7219.1697101871424384036 for ; Thu, 12 Oct 2023 02:11:11 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-452-iRUJorICNmiO3I2rX46cZA-1; Thu, 12 Oct 2023 05:11:05 -0400 X-MC-Unique: iRUJorICNmiO3I2rX46cZA-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1D177101A53B; Thu, 12 Oct 2023 09:11:05 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 195DF40C6F7F; Thu, 12 Oct 2023 09:11:03 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Abner Chang , Ard Biesheuvel , Daniel Schaefer , Leif Lindholm Subject: [edk2-devel] [PATCH 5/5] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class Date: Thu, 12 Oct 2023 11:10:57 +0200 Message-Id: <20231012091057.108728-6-lersek@redhat.com> In-Reply-To: <20231012091057.108728-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012091057.108728-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: BjjtQDOl3f48C1PIPUUJp7ZTx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101873678100003 Content-Type: text/plain; charset="utf-8"; x-default="true" The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. At this point, the word "LibRtcVirtualNotifyEvent" no longer occurs in any of edk2, edk2-platforms, even edk2-non-osi, except the library class header proper. Remove the LibRtcVirtualNotifyEvent() function declaration. Build-tested only (with "EmbeddedPkg.dsc"). Cc: Abner Chang Cc: Ard Biesheuvel Cc: Daniel Schaefer Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel --- EmbeddedPkg/Include/Library/RealTimeClockLib.h | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/EmbeddedPkg/Include/Library/RealTimeClockLib.h b/EmbeddedPkg/I= nclude/Library/RealTimeClockLib.h index ff45e26d6cfc..b2ff3f233bea 100644 --- a/EmbeddedPkg/Include/Library/RealTimeClockLib.h +++ b/EmbeddedPkg/Include/Library/RealTimeClockLib.h @@ -105,19 +105,4 @@ LibRtcInitialize ( IN EFI_SYSTEM_TABLE *SystemTable ); =20 -/** - Fixup internal data so that EFI can be call in virtual mode. - Call the passed in Child Notify event and convert any pointers in - lib to virtual mode. - - @param[in] Event The Event that is being processed - @param[in] Context Event Context -**/ -VOID -EFIAPI -LibRtcVirtualNotifyEvent ( - IN EFI_EVENT Event, - IN VOID *Context - ); - #endif -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109567): https://edk2.groups.io/g/devel/message/109567 Mute This Topic: https://groups.io/mt/101914682/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-