let LibRtcVirtualNotifyEvent() be dropped

[edk2-devel] [edk2-platforms PATCH 14/19] LoongArchQemuPkg/LsRealTimeClockLib: hide LibRtcVirtualNotifyEvent

Posted by Laszlo Ersek 2 years, 4 months ago

The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
SetVirtualAddressMap() notification functions.

Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it
static, in preparation for removing the LibRtcVirtualNotifyEvent()
declaration from the lib class header later.

Build-tested only (with "Loongson.dsc").

Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Chao Li <lichao@loongson.cn>
Cc: Xianglai li <lixianglai@loongson.cn>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c
index 4315c2074d2f..eeac011a9400 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c
+++ b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c
@@ -180,9 +180,10 @@ LibSetWakeupTime (
   @param[in]    Event   The Event that is being processed
   @param[in]    Context Event Context
 **/
+STATIC
 VOID
 EFIAPI
-LibRtcVirtualNotifyEvent (
+VirtualNotifyEvent (
   IN EFI_EVENT        Event,
   IN VOID             *Context
   )
@@ -325,7 +326,7 @@ LibRtcInitialize (
   Status = gBS->CreateEventEx (
                   EVT_NOTIFY_SIGNAL,
                   TPL_NOTIFY,
-                  LibRtcVirtualNotifyEvent,
+                  VirtualNotifyEvent,
                   NULL,
                   &gEfiEventVirtualAddressChangeGuid,
                   &mRtcVirtualAddrChangeEvent



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109553): https://edk2.groups.io/g/devel/message/109553
Mute This Topic: https://groups.io/mt/101914663/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH 14/19] LoongArchQemuPkg/LsRealTimeClockLib: hide LibRtcVirtualNotifyEvent

Posted by xianglai 2 years, 3 months ago

Hi Laszlo Ersek:
> The RealTimeClockLib class header in edk2 mistakenly declares a function
> called LibRtcVirtualNotifyEvent(). No component ever calls this function
> crossing module boundaries; all RealTimeClockLib instances in edk2 and
> edk2-platforms are supposed to register (and do register) their
> SetVirtualAddressMap() notification functions.
>
> Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it
> static, in preparation for removing the LibRtcVirtualNotifyEvent()
> declaration from the lib class header later.
>
> Build-tested only (with "Loongson.dsc").
>
> Cc: Bibo Mao <maobibo@loongson.cn>
> Cc: Chao Li <lichao@loongson.cn>
> Cc: Xianglai li <lixianglai@loongson.cn>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>   Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c
> index 4315c2074d2f..eeac011a9400 100644
> --- a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c
> +++ b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c
> @@ -180,9 +180,10 @@ LibSetWakeupTime (
>     @param[in]    Event   The Event that is being processed
>     @param[in]    Context Event Context
>   **/
> +STATIC
>   VOID
>   EFIAPI
> -LibRtcVirtualNotifyEvent (
> +VirtualNotifyEvent (
>     IN EFI_EVENT        Event,
>     IN VOID             *Context
>     )
> @@ -325,7 +326,7 @@ LibRtcInitialize (
>     Status = gBS->CreateEventEx (
>                     EVT_NOTIFY_SIGNAL,
>                     TPL_NOTIFY,
> -                  LibRtcVirtualNotifyEvent,
> +                  VirtualNotifyEvent,
>                     NULL,
>                     &gEfiEventVirtualAddressChangeGuid,
>                     &mRtcVirtualAddrChangeEvent
>
This patch was compiled and tested on loongson without problems, and 
modification is agreed.

Thanks,

xianglai.


>
> 
>
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109569): https://edk2.groups.io/g/devel/message/109569
Mute This Topic: https://groups.io/mt/101914663/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH 14/19] LoongArchQemuPkg/LsRealTimeClockLib: hide LibRtcVirtualNotifyEvent

Posted by Chao Li 2 years, 3 months ago

Hi Laszlo,

This patch is look good to me. Thanks.

Acked-by: Chao Li <lichao@loongson.cn>


Thanks,
Chao
在 2023/10/12 20:14, xianglai 写道:
> Hi Laszlo Ersek:
>> The RealTimeClockLib class header in edk2 mistakenly declares a function
>> called LibRtcVirtualNotifyEvent(). No component ever calls this function
>> crossing module boundaries; all RealTimeClockLib instances in edk2 and
>> edk2-platforms are supposed to register (and do register) their
>> SetVirtualAddressMap() notification functions.
>>
>> Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it
>> static, in preparation for removing the LibRtcVirtualNotifyEvent()
>> declaration from the lib class header later.
>>
>> Build-tested only (with "Loongson.dsc").
>>
>> Cc: Bibo Mao <maobibo@loongson.cn>
>> Cc: Chao Li <lichao@loongson.cn>
>> Cc: Xianglai li <lixianglai@loongson.cn>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c 
>> | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git 
>> a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c 
>> b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c 
>>
>> index 4315c2074d2f..eeac011a9400 100644
>> --- 
>> a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c
>> +++ 
>> b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c
>> @@ -180,9 +180,10 @@ LibSetWakeupTime (
>>     @param[in]    Event   The Event that is being processed
>>     @param[in]    Context Event Context
>>   **/
>> +STATIC
>>   VOID
>>   EFIAPI
>> -LibRtcVirtualNotifyEvent (
>> +VirtualNotifyEvent (
>>     IN EFI_EVENT        Event,
>>     IN VOID             *Context
>>     )
>> @@ -325,7 +326,7 @@ LibRtcInitialize (
>>     Status = gBS->CreateEventEx (
>>                     EVT_NOTIFY_SIGNAL,
>>                     TPL_NOTIFY,
>> -                  LibRtcVirtualNotifyEvent,
>> +                  VirtualNotifyEvent,
>>                     NULL,
>>                     &gEfiEventVirtualAddressChangeGuid,
>>                     &mRtcVirtualAddrChangeEvent
>>
> This patch was compiled and tested on loongson without problems, and 
> modification is agreed.
>
> Thanks,
>
> xianglai.
>
>
>>
>>
>>
>>
>
>
>
> 
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109570): https://edk2.groups.io/g/devel/message/109570
Mute This Topic: https://groups.io/mt/101914663/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-