From nobody Mon Feb 9 23:16:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109553+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109553+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101816; cv=none; d=zohomail.com; s=zohoarc; b=g3dPo3Dl5J//VbJkcUmdX7soofyBKXTVa10P9WljTv9wmODP4fZ4/Woqui32shkuEZtICs0nQaP7+ZtApDrYN1QkmF5bGXp9NdyPhK6XvEss+FA/3aR3tdsFwSQmHty1kXua9ru0JbYdEUwKU2coGRv+tSU3tlpebvHBUPISs9U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101816; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=mMMTCxUpcKBFnhhOkbU12T8T7vPOULrZ9Xd9spwKs/Q=; b=Ilwhil6C73lZslgn5EmkrkemL/6p2Csjoug3Qac/tpEuKYWYr6Bl1S4sltY9M2zXO+7dlvBSiYT5I0MgO6JkVFC0310NMnQN3w2910gWdUzqr8Gwva+v5TlP3a2RJXtt7ByrbNoFNnB1rcLpxsrksZBZblxaTFcN3TrRuZepkQY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109553+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101816815323.6066008698451; Thu, 12 Oct 2023 02:10:16 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=mMMTCxUpcKBFnhhOkbU12T8T7vPOULrZ9Xd9spwKs/Q=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101816; v=1; b=Cfeu2TAEo+GpxHVSBfXolqWm/1qgR9Yb3e9nBJ+Kwfq2pkRyaiwXzyJVmGWwmOy73/5h1why 4oARxBb7ca7A4+LUpNKjA0cFlRh43efUfa9yATngZ5Ce/YdZYEa//FiPPq72YNwc+k492z/p3sQ ZozgWtHXkB5aDJRXB67iQ6zM= X-Received: by 127.0.0.2 with SMTP id dWShYY1788612xcATrEZA000; Thu, 12 Oct 2023 02:10:16 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.7198.1697101815910409707 for ; Thu, 12 Oct 2023 02:10:16 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-564-q4w8rWlPOgCCCSNFoK4GcA-1; Thu, 12 Oct 2023 05:10:11 -0400 X-MC-Unique: q4w8rWlPOgCCCSNFoK4GcA-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7536F1C0653B; Thu, 12 Oct 2023 09:10:11 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9717A40C6F79; Thu, 12 Oct 2023 09:10:10 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Bibo Mao , Chao Li , Xianglai li Subject: [edk2-devel] [edk2-platforms PATCH 14/19] LoongArchQemuPkg/LsRealTimeClockLib: hide LibRtcVirtualNotifyEvent Date: Thu, 12 Oct 2023 11:09:45 +0200 Message-Id: <20231012090950.108577-15-lersek@redhat.com> In-Reply-To: <20231012090950.108577-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012090950.108577-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: dljpiPEJSfa5ijh0aIeHHtZlx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101817483100024 Content-Type: text/plain; charset="utf-8"; x-default="true" The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it static, in preparation for removing the LibRtcVirtualNotifyEvent() declaration from the lib class header later. Build-tested only (with "Loongson.dsc"). Cc: Bibo Mao Cc: Chao Li Cc: Xianglai li Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek Acked-by: Chao Li --- Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeCl= ockLib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/= LsRealTimeClockLib.c b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTim= eClockLib/LsRealTimeClockLib.c index 4315c2074d2f..eeac011a9400 100644 --- a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealT= imeClockLib.c +++ b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealT= imeClockLib.c @@ -180,9 +180,10 @@ LibSetWakeupTime ( @param[in] Event The Event that is being processed @param[in] Context Event Context **/ +STATIC VOID EFIAPI -LibRtcVirtualNotifyEvent ( +VirtualNotifyEvent ( IN EFI_EVENT Event, IN VOID *Context ) @@ -325,7 +326,7 @@ LibRtcInitialize ( Status =3D gBS->CreateEventEx ( EVT_NOTIFY_SIGNAL, TPL_NOTIFY, - LibRtcVirtualNotifyEvent, + VirtualNotifyEvent, NULL, &gEfiEventVirtualAddressChangeGuid, &mRtcVirtualAddrChangeEvent -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109553): https://edk2.groups.io/g/devel/message/109553 Mute This Topic: https://groups.io/mt/101914663/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-