[edk2-devel] [PATCH v4 10/13] BaseTools: Only call LoadConfiguration once in build.py

Rebecca Cran posted 13 patches 2 years, 9 months ago
There is a newer version of this series
[edk2-devel] [PATCH v4 10/13] BaseTools: Only call LoadConfiguration once in build.py
Posted by Rebecca Cran 2 years, 9 months ago
Avoid calling LoadConfiguration twice, in both InitPreBuild and
InitBuild. Since InitPreBuild is called first, delete the second call
from InitBuild.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 BaseTools/Source/Python/build/build.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index 51fb1f433eb7..8681b98776a9 100755
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -1002,9 +1002,6 @@ class Build():
     #   command line and target.txt, then get the final build configurations.
     #
     def InitBuild(self):
-        # parse target.txt, tools_def.txt, and platform file
-        self.LoadConfiguration()
-
         # Allow case-insensitive for those from command line or configuration file
         ErrorCode, ErrorInfo = self.PlatformFile.Validate(".dsc", False)
         if ErrorCode != 0:
@@ -1012,6 +1009,7 @@ class Build():
 
 
     def InitPreBuild(self):
+        # parse target.txt, tools_def.txt, and platform file
         self.LoadConfiguration()
         ErrorCode, ErrorInfo = self.PlatformFile.Validate(".dsc", False)
         if ErrorCode != 0:
-- 
2.37.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103250): https://edk2.groups.io/g/devel/message/103250
Mute This Topic: https://groups.io/mt/98375162/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-