From nobody Sat Feb 7 06:55:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103250+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103250+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1681934327; cv=none; d=zohomail.com; s=zohoarc; b=OyCfqKgHLaQc3QIzBox3hmy41kzKsmz+GPk29qw6R6Nee7NmFHoniLY2jerpUXC2uKGr79Y564U+JkkgdNCDWWU8bPjI/Qa47NYu3OJkF4D+MFR2sBoQ4Xu5Js2eDfA1/gekIxigS4CXhOTYn3U0jInms8YC0vwnGK7Fh/5XK90= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681934327; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=dNRbe8pmfFMMPCF+G3Ev6MFsHt0eYmJDvh57WHYjHwo=; b=Ye2GeGnql53rPfGeY5KhO/66H/o+be9b8Ey4TaVQTgwAObrij+OyLdx18JeS7trz29MXwRIZCWuUwnW4VxYxfi1Lc9WJZ12W2MAnTChgjDPpFPea8/g6rA3OC85bpY2RAwGjMG3mBVMn7XYeghu8swbzX0ydFSqHPNER8qczDZY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103250+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1681934327081412.0428787575104; Wed, 19 Apr 2023 12:58:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id suyiYY1788612xOgMKhsmRgN; Wed, 19 Apr 2023 12:58:46 -0700 X-Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mx.groups.io with SMTP id smtpd.web11.48798.1681934326277666132 for ; Wed, 19 Apr 2023 12:58:46 -0700 X-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 341B1320097A; Wed, 19 Apr 2023 15:58:44 -0400 (EDT) X-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 19 Apr 2023 15:58:45 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedttddgudegiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeegffeuueelvdeggfdvvdfgtedvudfhfeekudekieektddukeefteetieef vdelfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Apr 2023 15:58:41 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io, Liming Gao , Bob Feng , Yuwei Chen , Michael D Kinney , Michael Kubacki , Sean Brogan , Chasel Chiu , Nate DeSimone , Star Zeng , Andrew Fish Cc: Rebecca Cran , Ray Ni , Leif Lindholm , Zhiguang Liu , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Gua Guo , Ard Biesheuvel , Pedro Falcato , Gerd Hoffmann , =?UTF-8?q?Marvin=20H=C3=A4user?= Subject: [edk2-devel] [PATCH v4 10/13] BaseTools: Only call LoadConfiguration once in build.py Date: Wed, 19 Apr 2023 13:57:43 -0600 Message-Id: <20230419195746.99074-11-rebecca@bsdio.com> In-Reply-To: <20230419195746.99074-1-rebecca@bsdio.com> References: <20230419195746.99074-1-rebecca@bsdio.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com X-Gm-Message-State: XaBSAB6lEOk8FhRMbRymtjjYx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1681934326; bh=9sJvt92a8VSvQaXwbw4rpDZcHeRAtrd6LbG3s+NUfg8=; h=Cc:Date:From:Reply-To:Subject:To; b=bEJuuIX2y+suLukNDOBW6rwtTheBICPKk2cMHiBG6x69RCg1pJNvXCL6tQkXPZxvZMY VVpCrDFtoFm1mG4su/VLWYhKKMw1npoJNXbVRrrcMHLf6/3KK+eRsfTQQTwrEcbSJVx3+ vy07qpb26Ro6tlutu5NOYby5CdLQw9xFeTI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1681934327341100001 Content-Type: text/plain; charset="utf-8" Avoid calling LoadConfiguration twice, in both InitPreBuild and InitBuild. Since InitPreBuild is called first, delete the second call from InitBuild. Signed-off-by: Rebecca Cran --- BaseTools/Source/Python/build/build.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Pyth= on/build/build.py index 51fb1f433eb7..8681b98776a9 100755 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -1002,9 +1002,6 @@ class Build(): # command line and target.txt, then get the final build configuratio= ns. # def InitBuild(self): - # parse target.txt, tools_def.txt, and platform file - self.LoadConfiguration() - # Allow case-insensitive for those from command line or configurat= ion file ErrorCode, ErrorInfo =3D self.PlatformFile.Validate(".dsc", False) if ErrorCode !=3D 0: @@ -1012,6 +1009,7 @@ class Build(): =20 =20 def InitPreBuild(self): + # parse target.txt, tools_def.txt, and platform file self.LoadConfiguration() ErrorCode, ErrorInfo =3D self.PlatformFile.Validate(".dsc", False) if ErrorCode !=3D 0: --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103250): https://edk2.groups.io/g/devel/message/103250 Mute This Topic: https://groups.io/mt/98375162/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-