[edk2-devel] [PATCH edk2-platforms v2 0/2] Platform/ARM/JunoPkg: Timer fixes

Rebecca Cran posted 2 patches 1 year, 2 months ago
Failed in applying to current master (apply log)
Platform/ARM/JunoPkg/ArmJuno.dsc | 6 +++---
Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
[edk2-devel] [PATCH edk2-platforms v2 0/2] Platform/ARM/JunoPkg: Timer fixes
Posted by Rebecca Cran 1 year, 2 months ago
The use of the EmbeddedPkg/MetronomeDxe driver on Juno can cause problems
with drivers that use gBS->Stall, since it takes 10x longer than
requested. For example requesting a timeout of 1 ms when doing a USB 
bulk transfer results in it taking 100 ms. Switching to the
MdeModulePkg/Universal/Metronome driver fixes this since it assumes the
timer clock ticks at least every 100 ns.

While here, set the PCD value of the timer frequency to 0 so it gets
read from the SoC instead of hard-coding it.

Changes in v2:

Dropped the patch to set PcdTimerPeriod.

Rebecca Cran (2):
  Platform/ARM/JunoPkg: Switch to MdeModulePkg/Universal/Metronome
    driver
  Platform/ARM/JunoPkg: Set PcdArmArchTimerFreqInHz to 0 to read from
    CNTFRQ_EL0

 Platform/ARM/JunoPkg/ArmJuno.dsc | 6 +++---
 Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.30.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100385): https://edk2.groups.io/g/devel/message/100385
Mute This Topic: https://groups.io/mt/97099986/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH edk2-platforms v2 0/2] Platform/ARM/JunoPkg: Timer fixes
Posted by Ard Biesheuvel 1 year, 2 months ago
On Tue, 21 Feb 2023 at 02:03, Rebecca Cran <rebecca@quicinc.com> wrote:
>
> The use of the EmbeddedPkg/MetronomeDxe driver on Juno can cause problems
> with drivers that use gBS->Stall, since it takes 10x longer than
> requested. For example requesting a timeout of 1 ms when doing a USB
> bulk transfer results in it taking 100 ms. Switching to the
> MdeModulePkg/Universal/Metronome driver fixes this since it assumes the
> timer clock ticks at least every 100 ns.
>
> While here, set the PCD value of the timer frequency to 0 so it gets
> read from the SoC instead of hard-coding it.
>
> Changes in v2:
>
> Dropped the patch to set PcdTimerPeriod.
>
> Rebecca Cran (2):
>   Platform/ARM/JunoPkg: Switch to MdeModulePkg/Universal/Metronome
>     driver
>   Platform/ARM/JunoPkg: Set PcdArmArchTimerFreqInHz to 0 to read from
>     CNTFRQ_EL0
>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Pushed as 81ec441723a0..e20ee6e3a65d

Thanks!

>  Platform/ARM/JunoPkg/ArmJuno.dsc | 6 +++---
>  Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> --
> 2.30.2
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100405): https://edk2.groups.io/g/devel/message/100405
Mute This Topic: https://groups.io/mt/97099986/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-