From nobody Fri May 17 05:54:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+100386+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100386+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1676941381; cv=none; d=zohomail.com; s=zohoarc; b=dEzx+nzwqMrx1yHDhKaDb2xvcRCJ2LICkJ4NC5OHOUrJTa2SoDtqGYJrmTs/KZHY6ORz2m++xLjPZv0CmQ8J66o5mPRlcqpBOxobEXfKHbn40h/DFrRAMnkF45BBM4uhF3QPZY552HVw7+sq/2v1PB1KTra9WHExeoytja0CPjI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676941381; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=nHjEkJ83mKZpgnrRDPMJBVekmzgQjO2k8sHlHDDOZ/4=; b=iggrySMI8LFGochFCWCfY+ogVRfR47/gsuloh5ZBcvyd+8KlmLNozljHuz9F99HRViMFY5CAZ+nJ1N8hJwlXMB8jUnMfx3JDG4YhzTBS/hwU9ezsvesuBnEFpYTHNy39DfaDqjyjg2d3dTMOf0vQCE7rGYi3oi3ebiimoklrjWY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100386+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16769413817511018.8023356773433; Mon, 20 Feb 2023 17:03:01 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id lI8MYY1788612x8rJJs10rrZ; Mon, 20 Feb 2023 17:03:01 -0800 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.31807.1676941380813073449 for ; Mon, 20 Feb 2023 17:03:00 -0800 X-Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31L0fO3j016116; Tue, 21 Feb 2023 01:02:58 GMT X-Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ntqene11b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Feb 2023 01:02:57 +0000 X-Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31L12vFh001975 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Feb 2023 01:02:57 GMT X-Received: from linbox.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 20 Feb 2023 17:02:56 -0800 From: "Rebecca Cran" To: , Pierre Gondois , "Ard Biesheuvel" , Sami Mujawar , Thomas Abraham CC: Rebecca Cran Subject: [edk2-devel] [PATCH edk2-platforms v2 1/2] Platform/ARM/JunoPkg: Switch to MdeModulePkg/Universal/Metronome driver Date: Mon, 20 Feb 2023 18:02:41 -0700 Message-ID: <20230221010242.1038521-2-rebecca@quicinc.com> In-Reply-To: <20230221010242.1038521-1-rebecca@quicinc.com> References: <20230221010242.1038521-1-rebecca@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-GUID: 13_TfQalAEwYaVIVKBPwgNJb2P_dFTq_ X-Proofpoint-ORIG-GUID: 13_TfQalAEwYaVIVKBPwgNJb2P_dFTq_ Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_rcran@quicinc.com X-Gm-Message-State: m4d3vCGfMsoHZXBhDoHH0Qtrx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1676941381; bh=sOm91eWLw0bkjtiznhYMh6Ai6dUWzcJkfVfYrP5/S1o=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=IxuEJQvt6c1ZxEl4ZAQjj0ALU+nanpaQZn8MyeZwJJVrppCnLFNzm9Vw+rUfvk1zrIp G9SZarnxDbXEbDciq04CNBTCoujJCRdLwFtacDNm1xWIjaakGzK8OiYfy5BUKRLKFIFAl qZjb6uMSn0/hQd2TJqi6F2zol5nCa0UinZc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1676941383877100008 Content-Type: text/plain; charset="utf-8" The MetronomeDxe driver uses the PCD PcdMetronomeTickPeriod to calculate how many ticks to wait in MicroSecondDelay. Given that the timer clock on Juno runs at 50 MHz, it ticks every 20 ns; therefore, a setting of 1000 is wrong: for example it causes a call to gBS->Stall (1) to take 10 us. The driver in MdeModulePkg/Universal/Metronome assumes the clock ticks at least every 100 ns, which is the minimum allowed by the Metronome protocol. Since that's the case on Juno, switch from EmbeddedPkg/MetronomeDxe to MdeModulePkg/Universal/Metronome. Signed-off-by: Rebecca Cran Reviewed-by: Ard Biesheuvel --- Platform/ARM/JunoPkg/ArmJuno.dsc | 3 +-- Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJun= o.dsc index a00b866c5e9a..9cde4c862651 100644 --- a/Platform/ARM/JunoPkg/ArmJuno.dsc +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc @@ -189,7 +189,6 @@ # ARM Architectural Timer Frequency # gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|50000000 - gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000 =20 gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FAL= SE =20 @@ -248,10 +247,10 @@ MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf + MdeModulePkg/Universal/Metronome/Metronome.inf MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntim= eDxe.inf MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf - EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf =20 MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf diff --git a/Platform/ARM/JunoPkg/ArmJuno.fdf b/Platform/ARM/JunoPkg/ArmJun= o.fdf index fca5a78cee6c..836d3cde8781 100644 --- a/Platform/ARM/JunoPkg/ArmJuno.fdf +++ b/Platform/ARM/JunoPkg/ArmJuno.fdf @@ -96,10 +96,10 @@ FvNameGuid =3D B73FE497-B92E-416e-8326-45AD0D27= 0092 INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf INF MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf + INF MdeModulePkg/Universal/Metronome/Metronome.inf INF MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRu= ntimeDxe.inf INF MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.i= nf INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf - INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf =20 INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.i= nf --=20 2.30.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100386): https://edk2.groups.io/g/devel/message/100386 Mute This Topic: https://groups.io/mt/97099988/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 05:54:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+100387+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100387+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1676941382; cv=none; d=zohomail.com; s=zohoarc; b=X7FZzLptYXCBoUV71BAjjZG5p165/NwPDt7ulRjgNxNk0xMPeNRx7qJYU4fb7fhpd2tClihHMfKuH/zHR9biuoTjIvwJZUy2KGkht+GtAQM5S8/ERZ/FT+V+Q9K7xB1SnW3rH4cNF8OZgwpU/TMZ6701DMi1vMIzz3l2C8A839Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676941382; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ltr5Z57SWmKukBT2Va41A5XWV/hovNqIj4inh+YwBkg=; b=VU4DmDcfDYMxL4V3xKFPc600V5jkmkZ8ltYu5Zt94fiq6vlzumq/s1BWfmQmOWjxQlL/xjg5kjq7J1YgWBv2Tq7+ZPppFCctuTcrcW3WbHVoJiUIEpkigcoXRRfpNwXG6dagtKiisXN8iUCJLQ3v0r9jSnkzAqamxF9+La9hTE8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100387+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 167694138280473.25844607018234; Mon, 20 Feb 2023 17:03:02 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id ept8YY1788612xR5HiXmE2qr; Mon, 20 Feb 2023 17:03:02 -0800 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.31471.1676941381763109783 for ; Mon, 20 Feb 2023 17:03:01 -0800 X-Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31L0pFT4026786; Tue, 21 Feb 2023 01:02:59 GMT X-Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ntm1veq5u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Feb 2023 01:02:58 +0000 X-Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31L12vn9018970 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Feb 2023 01:02:57 GMT X-Received: from linbox.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 20 Feb 2023 17:02:57 -0800 From: "Rebecca Cran" To: , Pierre Gondois , "Ard Biesheuvel" , Sami Mujawar , Thomas Abraham CC: Rebecca Cran Subject: [edk2-devel] [PATCH edk2-platforms v2 2/2] Platform/ARM/JunoPkg: Set PcdArmArchTimerFreqInHz to 0 to read from CNTFRQ_EL0 Date: Mon, 20 Feb 2023 18:02:42 -0700 Message-ID: <20230221010242.1038521-3-rebecca@quicinc.com> In-Reply-To: <20230221010242.1038521-1-rebecca@quicinc.com> References: <20230221010242.1038521-1-rebecca@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: f3XrLuNr0UD9iflCVPEYU92ShzihjdeG X-Proofpoint-GUID: f3XrLuNr0UD9iflCVPEYU92ShzihjdeG Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_rcran@quicinc.com X-Gm-Message-State: VPSpxlO3LIXKwvZZIQfBgzCyx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1676941382; bh=4cdk/jZtVo13XKalJzmRtUgH7R/KgM/eux+Li0RCZNM=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=FzAk4dzz3Zfd33SVYQ2Ky9funU9m4YRMu4z/6F+Kbco843ehUaEragJzQz0iSu7D+rQ bc3GzR7AQgZdICztysKCj7seV8Igh2kC7vMnVz1WwzZ78Px2EtX+gbT27o11jtfL5Nbr0 EXgQv5s/01TRZCyXIGiOroVyaXGzCrNFGOg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1676941383861100005 Content-Type: text/plain; charset="utf-8" If PcdArmArchTimerFreqInHz is zero, the value of the timer frequency will be read from CNTFRQ_EL0. Avoid hard-coding the value in ArmJuno.dsc and instead let the ArmArchTimerLib driver read it from the SoC. Signed-off-by: Rebecca Cran Reviewed-by: Ard Biesheuvel --- Platform/ARM/JunoPkg/ArmJuno.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJun= o.dsc index 9cde4c862651..d3bb205aa6f2 100644 --- a/Platform/ARM/JunoPkg/ArmJuno.dsc +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc @@ -188,7 +188,8 @@ # # ARM Architectural Timer Frequency # - gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|50000000 + # Set to 0 so ArmArchTimerLib will read its value from CNTFRQ_EL0 + gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0 =20 gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FAL= SE =20 --=20 2.30.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100387): https://edk2.groups.io/g/devel/message/100387 Mute This Topic: https://groups.io/mt/97099990/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-