The specialized relocation fixup handlers are used by ARM and RISC-V but
not by IPF/Itanium anymore, so let's clean up the comments referring to
Itanium. No code changes.
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 2 +-
MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h | 8 +++-----
MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c | 11 +++++------
3 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/MdePkg/Library/BasePeCoffLib/BasePeCoff.c b/MdePkg/Library/BasePeCoffLib/BasePeCoff.c
index 97a8aaf8c73d..85ada399e303 100644
--- a/MdePkg/Library/BasePeCoffLib/BasePeCoff.c
+++ b/MdePkg/Library/BasePeCoffLib/BasePeCoff.c
@@ -1901,7 +1901,7 @@ PeCoffLoaderRelocateImageForRuntime (
default:
//
- // Only Itanium requires ConvertPeImage_Ex
+ // Perform architecture/ISA specific relocation.
//
Status = PeHotRelocateImageEx (Reloc, Fixup, &FixupData, Adjust);
if (RETURN_ERROR (Status)) {
diff --git a/MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h b/MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h
index 4a43ec236529..a29a6febe98f 100644
--- a/MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h
+++ b/MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h
@@ -18,8 +18,7 @@
#include <IndustryStandard/PeImage.h>
/**
- Performs an Itanium-based specific relocation fixup and is a no-op on other
- instruction sets.
+ Performs an architecture/ISA specific relocation fixup.
@param Reloc The pointer to the relocation record.
@param Fixup The pointer to the address to fix up.
@@ -38,9 +37,8 @@ PeCoffLoaderRelocateImageEx (
);
/**
- Performs an Itanium-based specific re-relocation fixup and is a no-op on other
- instruction sets. This is used to re-relocated the image into the EFI virtual
- space for runtime calls.
+ Performs an architecture/ISA specific re-relocation fixup. This is used to
+ re-relocate the image into the EFI virtual space for runtime calls.
@param Reloc The pointer to the relocation record.
@param Fixup The pointer to the address to fix up.
diff --git a/MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c b/MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c
index 1a806dd62db6..f7cade4d7d4e 100644
--- a/MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c
+++ b/MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c
@@ -1,5 +1,6 @@
/** @file
- Specific relocation fixups for none Itanium architecture.
+ NULL implementations of architecture/ISA Specific relocation handlers,
+ for architectures/ISAs that only use the generic PE/COFF relocation types.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -9,8 +10,7 @@
#include "BasePeCoffLibInternals.h"
/**
- Performs an Itanium-based specific relocation fixup and is a no-op on other
- instruction sets.
+ Performs an architecture/ISA specific relocation fixup.
@param Reloc The pointer to the relocation record.
@param Fixup The pointer to the address to fix up.
@@ -59,9 +59,8 @@ PeCoffLoaderImageFormatSupported (
}
/**
- Performs an Itanium-based specific re-relocation fixup and is a no-op on other
- instruction sets. This is used to re-relocated the image into the EFI virtual
- space for runtime calls.
+ Performs an architecture/ISA specific re-relocation fixup. This is used to
+ re-relocate the image into the EFI virtual space for runtime calls.
@param Reloc The pointer to the relocation record.
@param Fixup The pointer to the address to fix up.
--
2.39.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99571): https://edk2.groups.io/g/devel/message/99571
Mute This Topic: https://groups.io/mt/96721187/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-