From nobody Sun Feb 8 14:52:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+99571+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99571+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1675426274; cv=none; d=zohomail.com; s=zohoarc; b=AZUMIu90Mwtq8+O9fdGAnS/il4iodkw1PMtdYCXLB0XO1APeg5GZ5gkO8876FjyKEjXuz7aHZj+SG5Yy51n8PFkKoiITd+t3S12df00vMC6OtJhQZBpI+YxvtO4/lH0XwnK7lHLDVVdYOOBozyrU6DYA8c266sikXvOiZiu7QM0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675426274; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=XXwPi/qIgBx0fx73yjBaVxiz/NATRQqjfocBjnZXblM=; b=JmDS3bCN3RcuoDPrPzv3Mp70C1Z5Wei6WcA+AFGjQReMUI0L3EmzmvS7eXpomtLPzqHspiP3FazxZfFl3GoSC/UijYTc199m8gDuN8OjSS7BHIXARRF1zm8S42WCBjziZqGCCNkFd8FWLR03ThB7CERVtPqzqxJ5HLIg2ogw6eE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99571+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1675426274503730.9519896357892; Fri, 3 Feb 2023 04:11:14 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id u78gYY1788612xMMqCscEl6s; Fri, 03 Feb 2023 04:11:14 -0800 X-Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.8774.1675426271823073355 for ; Fri, 03 Feb 2023 04:11:12 -0800 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8F6DFB82A72; Fri, 3 Feb 2023 12:11:09 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBB4DC433EF; Fri, 3 Feb 2023 12:11:05 +0000 (UTC) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Michael Kinney , Liming Gao , Jiewen Yao , Michael Kubacki , Sean Brogan , Rebecca Cran , Leif Lindholm , Sami Mujawar , Taylor Beebe , =?UTF-8?q?Marvin=20H=C3=A4user?= Subject: [edk2-devel] [RFC PATCH v2 3/7] MdePkg/BasePeCoffLib: Clean up stale Itanium references in comments Date: Fri, 3 Feb 2023 13:10:25 +0100 Message-Id: <20230203121029.2451394-4-ardb@kernel.org> In-Reply-To: <20230203121029.2451394-1-ardb@kernel.org> References: <20230203121029.2451394-1-ardb@kernel.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org X-Gm-Message-State: BrCoEdmBM7BGVnFhlfSsYLt6x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1675426274; bh=1qKjquWxGon6zdSJtWc7C91OyRMGEqqsSK85zP79ij4=; h=Cc:Date:From:Reply-To:Subject:To; b=iBWa1wPEqU/6kKbAZvmQ++pDX/VxmZjyM74OfTqUNbYd4yrw9x76qkDrW5+ghH/eLvP 7FN40/SEsMyI5ZP6c34B2yPfypg9641obot0bgPTU6rNoccCykiXw5UgMw4CmSRgrTIbe 56tkOnr2KfRI8VZozFAk5vM/9gvms7pHPGw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1675426275122100004 Content-Type: text/plain; charset="utf-8" The specialized relocation fixup handlers are used by ARM and RISC-V but not by IPF/Itanium anymore, so let's clean up the comments referring to Itanium. No code changes. Signed-off-by: Ard Biesheuvel --- MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 2 +- MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h | 8 +++----- MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c | 11 +++++------ 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/MdePkg/Library/BasePeCoffLib/BasePeCoff.c b/MdePkg/Library/Bas= ePeCoffLib/BasePeCoff.c index 97a8aaf8c73d..85ada399e303 100644 --- a/MdePkg/Library/BasePeCoffLib/BasePeCoff.c +++ b/MdePkg/Library/BasePeCoffLib/BasePeCoff.c @@ -1901,7 +1901,7 @@ PeCoffLoaderRelocateImageForRuntime ( =20 default: // - // Only Itanium requires ConvertPeImage_Ex + // Perform architecture/ISA specific relocation. // Status =3D PeHotRelocateImageEx (Reloc, Fixup, &FixupData, Adj= ust); if (RETURN_ERROR (Status)) { diff --git a/MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h b/MdePkg= /Library/BasePeCoffLib/BasePeCoffLibInternals.h index 4a43ec236529..a29a6febe98f 100644 --- a/MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h +++ b/MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h @@ -18,8 +18,7 @@ #include =20 /** - Performs an Itanium-based specific relocation fixup and is a no-op on ot= her - instruction sets. + Performs an architecture/ISA specific relocation fixup. =20 @param Reloc The pointer to the relocation record. @param Fixup The pointer to the address to fix up. @@ -38,9 +37,8 @@ PeCoffLoaderRelocateImageEx ( ); =20 /** - Performs an Itanium-based specific re-relocation fixup and is a no-op on= other - instruction sets. This is used to re-relocated the image into the EFI vi= rtual - space for runtime calls. + Performs an architecture/ISA specific re-relocation fixup. This is used = to + re-relocate the image into the EFI virtual space for runtime calls. =20 @param Reloc The pointer to the relocation record. @param Fixup The pointer to the address to fix up. diff --git a/MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c b/MdePkg/Library= /BasePeCoffLib/PeCoffLoaderEx.c index 1a806dd62db6..f7cade4d7d4e 100644 --- a/MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c +++ b/MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c @@ -1,5 +1,6 @@ /** @file - Specific relocation fixups for none Itanium architecture. + NULL implementations of architecture/ISA Specific relocation handlers, + for architectures/ISAs that only use the generic PE/COFF relocation type= s. =20 Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -9,8 +10,7 @@ #include "BasePeCoffLibInternals.h" =20 /** - Performs an Itanium-based specific relocation fixup and is a no-op on ot= her - instruction sets. + Performs an architecture/ISA specific relocation fixup. =20 @param Reloc The pointer to the relocation record. @param Fixup The pointer to the address to fix up. @@ -59,9 +59,8 @@ PeCoffLoaderImageFormatSupported ( } =20 /** - Performs an Itanium-based specific re-relocation fixup and is a no-op on= other - instruction sets. This is used to re-relocated the image into the EFI vi= rtual - space for runtime calls. + Performs an architecture/ISA specific re-relocation fixup. This is used = to + re-relocate the image into the EFI virtual space for runtime calls. =20 @param Reloc The pointer to the relocation record. @param Fixup The pointer to the address to fix up. --=20 2.39.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99571): https://edk2.groups.io/g/devel/message/99571 Mute This Topic: https://groups.io/mt/96721187/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-