[v3] OvmfPkg: Check arguments for validity

[edk2-devel] [PATCH v3 0/3] OvmfPkg: Check arguments for validity

Dimitrije Pavlov posted 3 patches 1 year, 8 months ago

Diff against v2
Download series mbox

Failed in applying to current master (apply log)

OvmfPkg/PlatformDxe/Platform.c      | 8 ++++++++
OvmfPkg/VirtioFsDxe/DriverBinding.c | 4 ++++
OvmfPkg/VirtioGpuDxe/Gop.c          | 5 ++++-
3 files changed, 16 insertions(+), 1 deletion(-)

Expand all Fold all

[edk2-devel] [PATCH v3 0/3] OvmfPkg: Check arguments for validity

Posted by Dimitrije Pavlov 1 year, 8 months ago

Some functions across OVMF don't check pointer arguments for
validity, which causes null pointer dereferences and crashes
in the SCT test suite.

This series adds checks to return EFI_INVALID_PARAMETER if a
pointer argument is NULL.

v3:
- Fix coding standard issues to pass CI checks [Ard]

v2: https://edk2.groups.io/g/devel/message/92443

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Sunny Wang <Sunny.Wang@arm.com>
Cc: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

Reviewed-by: Sunny Wang <sunny.wang@arm.com>

Dimitrije Pavlov (3):
  OvmfPkg/PlatformDxe: Check ExtractConfig and RouteConfig arguments
  OvmfPkg/VirtioGpuDxe: Check QueryMode arguments
  OvmfPkg/VirtioFsDxe: Check GetDriverName arguments

 OvmfPkg/PlatformDxe/Platform.c      | 8 ++++++++
 OvmfPkg/VirtioFsDxe/DriverBinding.c | 4 ++++
 OvmfPkg/VirtioGpuDxe/Gop.c          | 5 ++++-
 3 files changed, 16 insertions(+), 1 deletion(-)

-- 
2.37.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92484): https://edk2.groups.io/g/devel/message/92484
Mute This Topic: https://groups.io/mt/93067595/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-