From nobody Sun May 5 09:23:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92486+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92486+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1660681727; cv=none; d=zohomail.com; s=zohoarc; b=SwiHx0bQMhc97v9LeEKA0rNSuzLcLYPUMYcwf3BSdDH7V852V0NS5PD1D9DGrgb08pB23hVV3yXf2YvXIu95N2Lx2Q7Jq6j0Nyi5yyea1eSmHOxwLaQnxn7cOOudph3ArNXGgNLEMXsLBd+Uki01F61YuzWbqxksdnvIVWjNTwY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660681727; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=MapEGIaO4Ml142Jw8CmYwuwb68+OHIrjrEgPqibQP0M=; b=PVWyW+Z0xEqrn6ydU7LzAzs3bPnzZjv3n1QItXJLL6rodg5mejpZ3JkU1TLhm477E6Q2fpqLpySkdg/5TsFqz3HOdEKlg4LVSg/MFNvz/HFUkas9VInj6BuJDiDMReurVBfQ/zh5jjNIdV+fZG8ruk7oPveGHKtIqxGv9tL3sHY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92486+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660681727330969.8174520641267; Tue, 16 Aug 2022 13:28:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id KOtWYY1788612xMT0FetZnxy; Tue, 16 Aug 2022 13:28:47 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.20860.1660681724844959406 for ; Tue, 16 Aug 2022 13:28:44 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0FD32113E; Tue, 16 Aug 2022 13:28:44 -0700 (PDT) X-Received: from mammon-apollo-f36.austin.arm.com (mammon-apollo-f36.austin.arm.com [10.118.12.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6DDA53F7D7; Tue, 16 Aug 2022 13:28:43 -0700 (PDT) From: "Dimitrije Pavlov" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Liming Gao , Sunny Wang , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud , Sunny Wang Subject: [edk2-devel] [PATCH v3 1/3] OvmfPkg/PlatformDxe: Check ExtractConfig and RouteConfig arguments Date: Tue, 16 Aug 2022 15:28:35 -0500 Message-Id: <20220816202837.3257608-2-dimitrije.pavlov@arm.com> In-Reply-To: <20220816202837.3257608-1-dimitrije.pavlov@arm.com> References: <20220816202837.3257608-1-dimitrije.pavlov@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Dimitrije.Pavlov@arm.com X-Gm-Message-State: xNmsvK8P9iez388KwrTnxzr9x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660681727; bh=P2TEN89FnMlfQpuB0t2otPaHFbcsLlZbzLZTnZBMB/s=; h=Cc:Date:From:Reply-To:Subject:To; b=DPJ44CIK5MiFZY/0Aez7EY7AYgvrr0EVMG4mB2AHoE/fAAaz7v6eUF1oqprsBeOwm/o +xVd+ZzUBp9IWJPCVZTmi4iqBpOnY9iwQOJGMRvDKuGAk18frY/EYSMnF/N2/hvbodUm4 /o8zOUw9+VesiiOlwEtXDkpgFU/IoaUukzs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660681728640100004 Content-Type: text/plain; charset="utf-8" The current implementation does not check if Progress or Results pointers in ExtractConfig are NULL, or if Progress pointer in RouteConfig is NULL. This causes the SCT test suite to crash. Add a check to return EFI_INVALID_PARAMETER if any of these pointers are NULL. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Liming Gao Cc: Sunny Wang Cc: Jeff Booher-Kaeding Cc: Samer El-Haj-Mahmoud Signed-off-by: Dimitrije Pavlov Reviewed-by: Sunny Wang --- OvmfPkg/PlatformDxe/Platform.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platform.c index 4bf22712c78f..a6d459f3dfd7 100644 --- a/OvmfPkg/PlatformDxe/Platform.c +++ b/OvmfPkg/PlatformDxe/Platform.c @@ -232,6 +232,10 @@ ExtractConfig ( =20 DEBUG ((DEBUG_VERBOSE, "%a: Request=3D\"%s\"\n", __FUNCTION__, Request)); =20 + if ((Progress =3D=3D NULL) || (Results =3D=3D NULL)) { + return EFI_INVALID_PARAMETER; + } + Status =3D PlatformConfigToFormState (&MainFormState); if (EFI_ERROR (Status)) { *Progress =3D Request; @@ -340,6 +344,10 @@ RouteConfig ( Configuration )); =20 + if (Progress =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + // // the "read" step in RMW // --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92486): https://edk2.groups.io/g/devel/message/92486 Mute This Topic: https://groups.io/mt/93067597/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 09:23:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92483+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92483+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1660681726; cv=none; d=zohomail.com; s=zohoarc; b=ihC2Hjxg2og9IpEIT49t5WOtb25BgdPShnK96tTzQLS54/gDE2k0UO/VZXPhX18aRsyjt8e19P1RMNjR55TwA/93UaL8AFtyJXNvUYGmsDyLmjllBW/mhEm1UBJijWhliArKwXCpi3a5FXOnm4tMz7cQIKK1GDBMWuDtF0mI0OM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660681726; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=9v2OOoxwHVGQL5QfhiaQO0NlUm53QE4d+NpWehN+fY4=; b=WIOYC+zs8qpumwd2na7PKLQOlHpdXD8Le31/k6ij4ci3PmcnLv4xeoZu03LK5w44enMbS7oxm78p5SxeKv1wh7cGkaSL79GzgOVLoSHOK72bQ/5JFHf6uFsDBrGmTQJXXbNxZ10lkeQ7ISWc2XO2eOzPR5h7qvUXszOb91EPeck= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92483+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660681726940820.4352304073245; Tue, 16 Aug 2022 13:28:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id uwULYY1788612xcnZuCbypiC; Tue, 16 Aug 2022 13:28:46 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.20604.1660681724133774125 for ; Tue, 16 Aug 2022 13:28:44 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 326F01424; Tue, 16 Aug 2022 13:28:44 -0700 (PDT) X-Received: from mammon-apollo-f36.austin.arm.com (mammon-apollo-f36.austin.arm.com [10.118.12.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9048B3F66F; Tue, 16 Aug 2022 13:28:43 -0700 (PDT) From: "Dimitrije Pavlov" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Liming Gao , Sunny Wang , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud , Sunny Wang Subject: [edk2-devel] [PATCH v3 2/3] OvmfPkg/VirtioGpuDxe: Check QueryMode arguments Date: Tue, 16 Aug 2022 15:28:36 -0500 Message-Id: <20220816202837.3257608-3-dimitrije.pavlov@arm.com> In-Reply-To: <20220816202837.3257608-1-dimitrije.pavlov@arm.com> References: <20220816202837.3257608-1-dimitrije.pavlov@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Dimitrije.Pavlov@arm.com X-Gm-Message-State: OgTTrQaSh1pKpqucDW5c8V54x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660681726; bh=MC2Z/3oU7nutkMS1ftLil0Vu4EuxClmmWY34TxOlgcE=; h=Cc:Date:From:Reply-To:Subject:To; b=uQAa0+ToIo6KHetkE07/yA0n2UEnyGhOH6jAEANz2B0X0WtiBrnp5FLdIqYrF2BaX6x pIe6WrDoJxUjQB1I8RCHS5Ed8s2MJ2zudp6IdR93+l6ydzsdgFHqJsNhX29GxAXekY5fJ M37JgdbA+mdmff5uZXoQsb7szeljt9tYOgc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660681728640100005 Content-Type: text/plain; charset="utf-8" The current implementation does not check if Info or SizeInfo pointers are NULL. This causes the SCT test suite to crash. Add a check to return EFI_INVALID_PARAMETER if any of these pointers are NULL. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Liming Gao Cc: Sunny Wang Cc: Jeff Booher-Kaeding Cc: Samer El-Haj-Mahmoud Signed-off-by: Dimitrije Pavlov Reviewed-by: Sunny Wang --- OvmfPkg/VirtioGpuDxe/Gop.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/VirtioGpuDxe/Gop.c b/OvmfPkg/VirtioGpuDxe/Gop.c index 401db47672ec..16e92830d411 100644 --- a/OvmfPkg/VirtioGpuDxe/Gop.c +++ b/OvmfPkg/VirtioGpuDxe/Gop.c @@ -308,7 +308,10 @@ GopQueryMode ( { EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *GopModeInfo; =20 - if (ModeNumber >=3D This->Mode->MaxMode) { + if ((Info =3D=3D NULL) || + (SizeOfInfo =3D=3D NULL) || + (ModeNumber >=3D This->Mode->MaxMode)) + { return EFI_INVALID_PARAMETER; } =20 --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92483): https://edk2.groups.io/g/devel/message/92483 Mute This Topic: https://groups.io/mt/93067594/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 09:23:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92485+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92485+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1660681726; cv=none; d=zohomail.com; s=zohoarc; b=M1YW017JYiu3zgs7J6n3ON7EfOsENnAB25J86O1xIY6wYRElUoEftkATjKecy7R2gx4zKRxB3Fv0zBxv2Fj60XY3I1dVIObDybymG8a6ZGr0Ukr6k/H4G8VN4Jf4LzfKy7lo4doMOEozD14CauTh3WNvWQDEUqpa0h1ighS/UMc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660681726; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Ia4q2VWmKz+AkPt0semY9JYNTrJJrR6rsB1y2HC18HI=; b=WVzyKjFOiUfhkk7QzsbsvHRv9tOCbzYSsiO36EpTtSBGrLmYxGczVUTVj6JxZr9WLN14pN6suqLujm36V1DsoqhYy2CV73Z8FBvK1hgCWe3Ves7ODUSMvwTI+zih+c2auOMSTxOKs0TNBFUJogo+6GIBKSrl0fhqFkhB9i3U9Yw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92485+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660681726427503.9449501917908; Tue, 16 Aug 2022 13:28:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ytCPYY1788612xkZYqPso1Mw; Tue, 16 Aug 2022 13:28:46 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.20859.1660681724763059150 for ; Tue, 16 Aug 2022 13:28:44 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 54CDE153B; Tue, 16 Aug 2022 13:28:44 -0700 (PDT) X-Received: from mammon-apollo-f36.austin.arm.com (mammon-apollo-f36.austin.arm.com [10.118.12.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B2D9C3F66F; Tue, 16 Aug 2022 13:28:43 -0700 (PDT) From: "Dimitrije Pavlov" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Liming Gao , Sunny Wang , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud , Sunny Wang Subject: [edk2-devel] [PATCH v3 3/3] OvmfPkg/VirtioFsDxe: Check GetDriverName arguments Date: Tue, 16 Aug 2022 15:28:37 -0500 Message-Id: <20220816202837.3257608-4-dimitrije.pavlov@arm.com> In-Reply-To: <20220816202837.3257608-1-dimitrije.pavlov@arm.com> References: <20220816202837.3257608-1-dimitrije.pavlov@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Dimitrije.Pavlov@arm.com X-Gm-Message-State: poF3uTojo2To5bd0cQzHgXt9x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660681726; bh=NRctjT93yk8u4DjTmo/MaQtOWglUkXTLYmfWsjlUxLc=; h=Cc:Date:From:Reply-To:Subject:To; b=Csgrpxx+1ohomqBpa/kVb7czmAGfXXnrOemFKEvfEXn2wdTdqoOQK8korfW2hDQZeMn d3seHO9h9irupP9PnnL1eOrXuc2HD0QHa6j7mebb2kwWzOqSxmrVWYD4j1eQCZWgoSYuk LGzkiIARGrYnHDdedCvp+QUv9USZ0PV0O2c= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660681728640100003 Content-Type: text/plain; charset="utf-8" The current implementation does not check if Language or DriverName are NULL. This causes the SCT test suite to crash. Add a check to return EFI_INVALID_PARAMETER if any of these pointers are NULL. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Liming Gao Cc: Sunny Wang Cc: Jeff Booher-Kaeding Cc: Samer El-Haj-Mahmoud Signed-off-by: Dimitrije Pavlov Reviewed-by: Sunny Wang --- OvmfPkg/VirtioFsDxe/DriverBinding.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/OvmfPkg/VirtioFsDxe/DriverBinding.c b/OvmfPkg/VirtioFsDxe/Driv= erBinding.c index 86eb9cf0ba51..69d2bb777089 100644 --- a/OvmfPkg/VirtioFsDxe/DriverBinding.c +++ b/OvmfPkg/VirtioFsDxe/DriverBinding.c @@ -218,6 +218,10 @@ VirtioFsGetDriverName ( OUT CHAR16 **DriverName ) { + if ((Language =3D=3D NULL) || (DriverName =3D=3D NULL)) { + return EFI_INVALID_PARAMETER; + } + if (AsciiStrCmp (Language, "en") !=3D 0) { return EFI_UNSUPPORTED; } --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92485): https://edk2.groups.io/g/devel/message/92485 Mute This Topic: https://groups.io/mt/93067596/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-