[edk2-devel] [PATCH v2 0/3] Simplify InitializeSeparateExceptionStacks

Zhiguang Liu posted 3 patches 1 year, 8 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
.../Library/ArmExceptionLib/ArmExceptionLib.c |  15 +-
MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c       |   4 +-
.../Include/Library/CpuExceptionHandlerLib.h  |  82 +--------
.../CpuExceptionHandlerLibNull.c              |  15 +-
UefiCpuPkg/CpuDxe/CpuMp.c                     | 157 +++-------------
UefiCpuPkg/CpuDxe/CpuMp.h                     |  10 +-
UefiCpuPkg/CpuMpPei/CpuMpPei.c                | 173 +++---------------
UefiCpuPkg/CpuMpPei/CpuMpPei.h                |  10 +-
.../CpuExceptionCommon.h                      |  57 +++++-
.../CpuExceptionHandlerLib/DxeException.c     | 112 +++++++++---
.../Ia32/ArchExceptionHandler.c               |  71 ++++---
.../CpuExceptionHandlerLib/PeiCpuException.c  |  94 +++++++++-
.../PeiCpuExceptionHandlerLib.inf             |   4 +-
.../SecPeiCpuException.c                      |  15 +-
.../CpuExceptionHandlerLib/SmmException.c     |  15 +-
.../X64/ArchExceptionHandler.c                |  67 ++++---
16 files changed, 416 insertions(+), 485 deletions(-)
[edk2-devel] [PATCH v2 0/3] Simplify InitializeSeparateExceptionStacks
Posted by Zhiguang Liu 1 year, 8 months ago
The patch set is to hide the exception implementation details, 
so that caller don't need to know anything about IDT when separate stack
for it. However, this patch set changes a library API, so I have to
change multiple packages inside one patch. Otherwise, I can make sure
every single commit can build and boot fine. If anyone has good idea to
separate the first big patch, please tell me. Thanks in advance.

V2:
Add another patch to Simplify the CPU_EXCEPTION_INIT_DATA definition 
Keep the memory layout picture in CpuExceptionHandlerLib.
Fix some code and comment issue accoring to Ray's comment
Code can be seen at https://github.com/tianocore/edk2/pull/3124

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>


Zhiguang Liu (3):
  UefiCpuPkg: Simplify InitializeSeparateExceptionStacks
  MdeModulePkg: Move CPU_EXCEPTION_INIT_DATA to UefiCpuPkg
  UefiCpuPkg: Simplify the struct definition of CPU_EXCEPTION_INIT_DATA

 .../Library/ArmExceptionLib/ArmExceptionLib.c |  15 +-
 MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c       |   4 +-
 .../Include/Library/CpuExceptionHandlerLib.h  |  82 +--------
 .../CpuExceptionHandlerLibNull.c              |  15 +-
 UefiCpuPkg/CpuDxe/CpuMp.c                     | 157 +++-------------
 UefiCpuPkg/CpuDxe/CpuMp.h                     |  10 +-
 UefiCpuPkg/CpuMpPei/CpuMpPei.c                | 173 +++---------------
 UefiCpuPkg/CpuMpPei/CpuMpPei.h                |  10 +-
 .../CpuExceptionCommon.h                      |  57 +++++-
 .../CpuExceptionHandlerLib/DxeException.c     | 112 +++++++++---
 .../Ia32/ArchExceptionHandler.c               |  71 ++++---
 .../CpuExceptionHandlerLib/PeiCpuException.c  |  94 +++++++++-
 .../PeiCpuExceptionHandlerLib.inf             |   4 +-
 .../SecPeiCpuException.c                      |  15 +-
 .../CpuExceptionHandlerLib/SmmException.c     |  15 +-
 .../X64/ArchExceptionHandler.c                |  67 ++++---
 16 files changed, 416 insertions(+), 485 deletions(-)

-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92149): https://edk2.groups.io/g/devel/message/92149
Mute This Topic: https://groups.io/mt/92830474/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-