1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] ArmPlatformPkg: Add PCD for serial debug port interrupt

Thomas Abraham posted 1 patch 1 year, 10 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
1 file changed, 1 insertion(+)
[edk2-devel] [PATCH] ArmPlatformPkg: Add PCD for serial debug port interrupt
Posted by Thomas Abraham 1 year, 10 months ago 
Add a PCD to specify the interrupt number of the serial debug port
controller.

Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
Change-Id: I4ce6d29cdf5e8b5fcbfe740269d966a53f2b852a
---
 ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
index 3a25ddcdc8..dd6e78f62a 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.dec
+++ b/ArmPlatformPkg/ArmPlatformPkg.dec
@@ -94,6 +94,7 @@
   gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
   gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031
   gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032
+  gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041
 
   ## PL061 GPIO
   gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90674): https://edk2.groups.io/g/devel/message/90674
Mute This Topic: https://groups.io/mt/91918588/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] ArmPlatformPkg: Add PCD for serial debug port interrupt
Posted by Ard Biesheuvel 1 year, 10 months ago 
On Wed, 22 Jun 2022 at 12:12, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
> Add a PCD to specify the interrupt number of the serial debug port
> controller.
>

Why do we need this?

> Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
> Change-Id: I4ce6d29cdf5e8b5fcbfe740269d966a53f2b852a

Please drop the change id

> ---
>  ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
> index 3a25ddcdc8..dd6e78f62a 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.dec
> +++ b/ArmPlatformPkg/ArmPlatformPkg.dec
> @@ -94,6 +94,7 @@
>    gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
>    gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031
>    gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032
> +  gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041
>
>    ## PL061 GPIO
>    gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025
> --
> 2.17.1
>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90685): https://edk2.groups.io/g/devel/message/90685
Mute This Topic: https://groups.io/mt/91918588/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] ArmPlatformPkg: Add PCD for serial debug port interrupt
Posted by Thomas Abraham 1 year, 10 months ago 

On 22/06/2022 15:52, Ard Biesheuvel wrote:
> On Wed, 22 Jun 2022 at 12:12, Thomas Abraham <thomas.abraham@arm.com> wrote:
>>
>> Add a PCD to specify the interrupt number of the serial debug port
>> controller.
>>
> 
> Why do we need this?

The commit message will be updated in next version of this patch the 
describes the need for this change.

> 
>> Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
>> Change-Id: I4ce6d29cdf5e8b5fcbfe740269d966a53f2b852a
> 
> Please drop the change id

Apologies, I missed this, will fix in the next version.

Thanks Ard for your review.

> 
>> ---
>>   ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
>> index 3a25ddcdc8..dd6e78f62a 100644
>> --- a/ArmPlatformPkg/ArmPlatformPkg.dec
>> +++ b/ArmPlatformPkg/ArmPlatformPkg.dec
>> @@ -94,6 +94,7 @@
>>     gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
>>     gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031
>>     gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032
>> +  gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041
>>
>>     ## PL061 GPIO
>>     gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025
>> --
>> 2.17.1
>>
>>
>>
>> 
>>
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90690): https://edk2.groups.io/g/devel/message/90690
Mute This Topic: https://groups.io/mt/91918588/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.