[v2] ArmPlatformPkg: Add PCD for serial debug port interrupt

[edk2-devel] [PATCH v2] ArmPlatformPkg: Add PCD for serial debug port interrupt

Posted by Thomas Abraham 1 year, 10 months ago

For Arm platforms that support more that one serial port, one of the
serial port can be used for connecting debuggers such as WinDbg. There
are PCDs that allow the base address and clock rate to be specified for
this debug serial port but not its interrupt number. So add a PCD to
specify the interrupt number assigned to the serial debug port
controller.

Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
---
 ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
 1 file changed, 1 insertion(+)

Changes since v1
- Updated commit message and removed the Change-Id line as suggested by
  Ard.

diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
index 3a25ddcdc8..dd6e78f62a 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.dec
+++ b/ArmPlatformPkg/ArmPlatformPkg.dec
@@ -94,6 +94,7 @@
   gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
   gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031
   gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032
+  gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041
 
   ## PL061 GPIO
   gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90689): https://edk2.groups.io/g/devel/message/90689
Mute This Topic: https://groups.io/mt/91924413/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] ArmPlatformPkg: Add PCD for serial debug port interrupt

Posted by Ard Biesheuvel 1 year, 10 months ago

On Wed, 22 Jun 2022 at 17:38, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
> For Arm platforms that support more that one serial port, one of the
> serial port can be used for connecting debuggers such as WinDbg. There
> are PCDs that allow the base address and clock rate to be specified for
> this debug serial port but not its interrupt number. So add a PCD to
> specify the interrupt number assigned to the serial debug port
> controller.
>
> Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
> ---
>  ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
>  1 file changed, 1 insertion(+)
>
> Changes since v1
> - Updated commit message and removed the Change-Id line as suggested by
>   Ard.
>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>


Merged as #3001.

> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
> index 3a25ddcdc8..dd6e78f62a 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.dec
> +++ b/ArmPlatformPkg/ArmPlatformPkg.dec
> @@ -94,6 +94,7 @@
>    gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
>    gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031
>    gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032
> +  gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041
>
>    ## PL061 GPIO
>    gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025
> --
> 2.17.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90692): https://edk2.groups.io/g/devel/message/90692
Mute This Topic: https://groups.io/mt/91924413/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-