My testing was busted, ran the tests with outdated tools_def
so I didn't notice the patch had zero effect ...

So, revert the broken patch, drop two lines which are not used
anywhere to reduce confusion, then just disable omit-frame-pointers
for ia32 and x64 to get the source tree back into working state
with minimum fuss.

Not fully sure yet how to go forward with that longer-term.  Enabling
omit-frame-pointers unconditionally makes the NOOPT noticeable larger,
which is probably the reason why the gcc enables that by default only
for -O1 and higher.  So maybe we need different cflags for NOOPT vs.
DEBUG/RELEASE builds.

Or go for a completely different approach, like integrating
DebugAgentLib support into the Pei Dispatcher, so the need to
have a custom TemporaryRamMigration() for that goes away ...

Comments?

take care,
  Gerd

Gerd Hoffmann (3):
  Revert "OvmfPkg/Sec: fix stack switch"
  tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS
  tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS

 OvmfPkg/Sec/SecMain.c             | 4 ----
 BaseTools/Conf/tools_def.template | 8 +++-----
 2 files changed, 3 insertions(+), 9 deletions(-)

-- 
2.36.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90441): https://edk2.groups.io/g/devel/message/90441
Mute This Topic: https://groups.io/mt/91665754/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-