From nobody Mon May 6 19:13:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90440+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90440+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1654858976; cv=none; d=zohomail.com; s=zohoarc; b=DcRCl7pPYQZ/Z7BDKPI5FdAUOECGVjVut8Al8/F0/Nhu/roRY/FA8eWL3iGF3PciUNxh4PJc/ij6Z3G/+RpCzr9j9Ua2aJIdGCp+TVt45yXcKYT1Ikmp2ufatpPKWyhkxUz6CHxPDMO4Cm5OZLAGfAXuTeIW9K/SFfZfwor+7q0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654858976; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Hla3S/vzsoVQTC7Qvto4mRtQ4GBbJEsBjKDWuPC5LsY=; b=XEMC6xB8VsuTtwDjt42jKKxmacQ+L0NfBvJjqkhyTzUHNhzBcLaJzitnkHXLfB9/IOwCJeK5JqrMALWQQezGKdK6HPLTRj3nY7+4Si9t1ZiYBBQ9a1CiHLxV2nQFaU1lQTyd9IkO2WrxGoFlwOon7eRcA1mY+QjMXYza3JyZoXE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90440+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1654858976073404.16919872426763; Fri, 10 Jun 2022 04:02:56 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id AAS0YY1788612xQYbj9XbiFq; Fri, 10 Jun 2022 04:02:55 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.25744.1654858974544096797 for ; Fri, 10 Jun 2022 04:02:55 -0700 X-Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-643-QdfNY8fJP_-o7niYM1AiQg-1; Fri, 10 Jun 2022 07:02:50 -0400 X-MC-Unique: QdfNY8fJP_-o7niYM1AiQg-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 337FA3C0CD4F; Fri, 10 Jun 2022 11:02:50 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E39AE1415100; Fri, 10 Jun 2022 11:02:48 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id CADC61800395; Fri, 10 Jun 2022 13:02:46 +0200 (CEST) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Oliver Steffen , James Bottomley , Tom Lendacky , Gerd Hoffmann , Jordan Justen , Yuwei Chen , Brijesh Singh , Erdem Aktas , Jiewen Yao , Liming Gao , Ard Biesheuvel , Pawel Polawski , Bob Feng , Min Xu Subject: [edk2-devel] [PATCH v6 1/3] Revert "OvmfPkg/Sec: fix stack switch" Date: Fri, 10 Jun 2022 13:02:44 +0200 Message-Id: <20220610110246.2031470-2-kraxel@redhat.com> In-Reply-To: <20220610110246.2031470-1-kraxel@redhat.com> References: <20220610110246.2031470-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com X-Gm-Message-State: WXm13lP3ahOIQDgBhyE5Cwkzx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1654858975; bh=jY+sMCbwp2ahikEMSRtzuNvA1AWqD8StMGIouy4xJZ8=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=lD1C+V90pViNe1CQeFL0Xw9XNG6Aw2fRvEagA48ng8F6jc6hqIl1HHNbiaAmYtMJxag kDn57a0X/gSWv1sraC6eYchCSAgPhIk/odAOL3Mu43dbaiKGKDjlfmy5ELmqr6+gs1eBl jz1UplFLISOhUNz3kK8lxKN2dQCz/+ridrg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1654858976742100001 Content-Type: text/plain; charset="utf-8"; x-default="true" This reverts commit ff36b2550f94dc5fac838cf298ae5a23cfddf204. Has no effect because GCC_IA32_CC_FLAGS and GCC_X64_CC_FLAGS are unused. Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Sec/SecMain.c | 4 ---- BaseTools/Conf/tools_def.template | 6 +++--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c index 3ca0dcdfd3dd..1167d22a68cc 100644 --- a/OvmfPkg/Sec/SecMain.c +++ b/OvmfPkg/Sec/SecMain.c @@ -1052,15 +1052,11 @@ TemporaryRamMigration ( if (SetJump (&JumpBuffer) =3D=3D 0) { #if defined (MDE_CPU_IA32) JumpBuffer.Esp =3D JumpBuffer.Esp + DebugAgentContext.StackMigrateOffs= et; - #ifndef OMIT_FRAME_POINTER JumpBuffer.Ebp =3D JumpBuffer.Ebp + DebugAgentContext.StackMigrateOffs= et; #endif - #endif #if defined (MDE_CPU_X64) JumpBuffer.Rsp =3D JumpBuffer.Rsp + DebugAgentContext.StackMigrateOffs= et; - #ifndef OMIT_FRAME_POINTER JumpBuffer.Rbp =3D JumpBuffer.Rbp + DebugAgentContext.StackMigrateOffs= et; - #endif #endif LongJump (&JumpBuffer, (UINTN)-1); } diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.t= emplate index adcd23f7273f..5ed19810b727 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -1849,9 +1849,9 @@ NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG =3D --add-gnu-debu= glink=3D$(DEBUG_DIR)/$(MODULE_N *_*_*_DTC_PATH =3D DEF(DTC_BIN) =20 DEFINE GCC_ALL_CC_FLAGS =3D -g -Os -fshort-wchar -fno-builtin -= fno-strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno= -common -DEFINE GCC_IA32_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -m32 -malign-= double -freorder-blocks -freorder-blocks-and-partition -O2 -mno-stack-arg-p= robe -fno-omit-frame-pointer -DEFINE GCC_X64_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -mno-red-zone= -Wno-address -mno-stack-arg-probe -fomit-frame-pointer -DOMIT_FRAME_POINTE= R=3D1 -DEFINE GCC_ARM_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -mlittle-endi= an -mabi=3Daapcs -fno-short-enums -funsigned-char -ffunction-sections -fdat= a-sections -fomit-frame-pointer -DOMIT_FRAME_POINTER=3D1 -Wno-address -mthu= mb -mfloat-abi=3Dsoft -fno-pic -fno-pie +DEFINE GCC_IA32_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -m32 -malign-= double -freorder-blocks -freorder-blocks-and-partition -O2 -mno-stack-arg-p= robe +DEFINE GCC_X64_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -mno-red-zone= -Wno-address -mno-stack-arg-probe +DEFINE GCC_ARM_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -mlittle-endi= an -mabi=3Daapcs -fno-short-enums -funsigned-char -ffunction-sections -fdat= a-sections -fomit-frame-pointer -Wno-address -mthumb -mfloat-abi=3Dsoft -fn= o-pic -fno-pie DEFINE GCC_ARM_CC_XIPFLAGS =3D -mno-unaligned-access DEFINE GCC_AARCH64_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -mlittle-endi= an -fno-short-enums -fverbose-asm -funsigned-char -ffunction-sections -fda= ta-sections -Wno-address -fno-asynchronous-unwind-tables -fno-unwind-tables= -fno-pic -fno-pie -ffixed-x18 DEFINE GCC_AARCH64_CC_XIPFLAGS =3D -mstrict-align -mgeneral-regs-only --=20 2.36.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90440): https://edk2.groups.io/g/devel/message/90440 Mute This Topic: https://groups.io/mt/91665753/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 19:13:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90442+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90442+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1654858983; cv=none; d=zohomail.com; s=zohoarc; b=DS1UHH4SZZjXRWHkLMB6n0yEz+UlEnp+OaKkWDSjx6j+UFurTjP+dz1dVFO4QXnbn0G5VAXZ3VuWbEbtu40c7zL2v2VfCJEbOhYSJrsgBbmXtQrSLP9afWywqxR2tpxO1vrhAoPIHpR2qMvuj1cH+G4fJ6gUe0ujppuca4SY3Ts= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654858983; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=3mZofm8y6g7E9Pm28WqKLD3KScXokOqMKADsunbj5JA=; b=ROyHAoZ1Ay2sUJTpCL3srWAM66CyR+yCmq38pdTUlpXc1ZMD7QtuQ6EC46SZCq0/Eqlu8kKtzwaFgY8pFPZFzFyiYQ/etW8y0TCegkDXRMXpsOsB6Lr1h6pP8a4T+mQoo95bKLtPxXtlsi/0vTl/kBvAPl20UQKdVAA6pxBZRwQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90442+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1654858983826379.4247819620731; Fri, 10 Jun 2022 04:03:03 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 9mH7YY1788612xJpmmLaetqN; Fri, 10 Jun 2022 04:03:03 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web12.25570.1654858982657320869 for ; Fri, 10 Jun 2022 04:03:02 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-331-9JHP5a1eMW-KUQkI9sT1TA-1; Fri, 10 Jun 2022 07:03:00 -0400 X-MC-Unique: 9JHP5a1eMW-KUQkI9sT1TA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 91E47185A7A4; Fri, 10 Jun 2022 11:02:59 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B0C91121319; Fri, 10 Jun 2022 11:02:58 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D069B18003A8; Fri, 10 Jun 2022 13:02:46 +0200 (CEST) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Oliver Steffen , James Bottomley , Tom Lendacky , Gerd Hoffmann , Jordan Justen , Yuwei Chen , Brijesh Singh , Erdem Aktas , Jiewen Yao , Liming Gao , Ard Biesheuvel , Pawel Polawski , Bob Feng , Min Xu Subject: [edk2-devel] [PATCH v6 2/3] tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS Date: Fri, 10 Jun 2022 13:02:45 +0200 Message-Id: <20220610110246.2031470-3-kraxel@redhat.com> In-Reply-To: <20220610110246.2031470-1-kraxel@redhat.com> References: <20220610110246.2031470-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com X-Gm-Message-State: n5jdhIwFpZda88Cikydid7mxx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1654858983; bh=IyYpYdVfPaV387jFmxkDdfuJoH1E19heEp2xUomePxg=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=RpOom+4/03BI8TKAgRpEFbFRPmo0ENhFuur2T9xqQ27D1AhWx9OIBWqsNVvsic32YAM yAq6VeIBBgDxa8qtNApMTwaw+/qkppP6b55Pg2TtGmVI8k/pS8dIG/AdD28eIEI+jG8Jx HYzujRo7sFGM7HIq4CBIQxhrMTCgQnupKwY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1654858984761100003 Content-Type: text/plain; charset="utf-8"; x-default="true" They are not used anywhere. Remove them. Signed-off-by: Gerd Hoffmann --- BaseTools/Conf/tools_def.template | 2 -- 1 file changed, 2 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.t= emplate index 5ed19810b727..a53199c9c76b 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -1849,8 +1849,6 @@ NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG =3D --add-gnu-debu= glink=3D$(DEBUG_DIR)/$(MODULE_N *_*_*_DTC_PATH =3D DEF(DTC_BIN) =20 DEFINE GCC_ALL_CC_FLAGS =3D -g -Os -fshort-wchar -fno-builtin -= fno-strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno= -common -DEFINE GCC_IA32_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -m32 -malign-= double -freorder-blocks -freorder-blocks-and-partition -O2 -mno-stack-arg-p= robe -DEFINE GCC_X64_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -mno-red-zone= -Wno-address -mno-stack-arg-probe DEFINE GCC_ARM_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -mlittle-endi= an -mabi=3Daapcs -fno-short-enums -funsigned-char -ffunction-sections -fdat= a-sections -fomit-frame-pointer -Wno-address -mthumb -mfloat-abi=3Dsoft -fn= o-pic -fno-pie DEFINE GCC_ARM_CC_XIPFLAGS =3D -mno-unaligned-access DEFINE GCC_AARCH64_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -mlittle-endi= an -fno-short-enums -fverbose-asm -funsigned-char -ffunction-sections -fda= ta-sections -Wno-address -fno-asynchronous-unwind-tables -fno-unwind-tables= -fno-pic -fno-pie -ffixed-x18 --=20 2.36.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90442): https://edk2.groups.io/g/devel/message/90442 Mute This Topic: https://groups.io/mt/91665757/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 19:13:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90443+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90443+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1654859000; cv=none; d=zohomail.com; s=zohoarc; b=L93mDiincLHuqawyPwPmUnRXmkQKl+Pr4JMVPaUKZv1SuVckNcVTuvaitxRhduZfs2YBbN+05dtcqmY14J18KkrrkrZVKe1S/xYc/QDCsjXr5CnlTbbrnaCDl8LJ57ZMQTQhjRnlt8r0dViFOyRA1FSK+5qKfPfDxgu0QmeqDs0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654859000; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=CDWpNsS6elYak/P2G+WoaHo6IBx/vNTylBqsqnLhsRI=; b=nD3cS/1EdZaSfGImLi3KU9TIoBxbYbN86PPK0MJqv7crC1jFmUr5IPsVQg2oRdqyVGeHqABhUN3s2okBKGldZsdDmF5Fp5gpkuPNJQa8JyrmAbGVLoruY2lbKSf3Tx6VUGasadkDjsjb4TCXaS4kd7HrBQZPWsLwlee7GYb+Ct4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90443+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1654858999212121.75680407290145; Fri, 10 Jun 2022 04:03:19 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id WXHqYY1788612xDc7C90kxSq; Fri, 10 Jun 2022 04:03:17 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web12.25572.1654858996968840870 for ; Fri, 10 Jun 2022 04:03:17 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-417-oGS5HIT4OFeGuMhK4MEVEA-1; Fri, 10 Jun 2022 07:03:13 -0400 X-MC-Unique: oGS5HIT4OFeGuMhK4MEVEA-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 675E3100DE70; Fri, 10 Jun 2022 11:03:12 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23D06492C3B; Fri, 10 Jun 2022 11:03:12 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D3C8118003BA; Fri, 10 Jun 2022 13:02:46 +0200 (CEST) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Oliver Steffen , James Bottomley , Tom Lendacky , Gerd Hoffmann , Jordan Justen , Yuwei Chen , Brijesh Singh , Erdem Aktas , Jiewen Yao , Liming Gao , Ard Biesheuvel , Pawel Polawski , Bob Feng , Min Xu Subject: [edk2-devel] [PATCH v6 3/3] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS Date: Fri, 10 Jun 2022 13:02:46 +0200 Message-Id: <20220610110246.2031470-4-kraxel@redhat.com> In-Reply-To: <20220610110246.2031470-1-kraxel@redhat.com> References: <20220610110246.2031470-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com X-Gm-Message-State: dH15jyT20Vd7Aj5PnY8zSiyWx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1654858997; bh=Bp7izaDFVX9hpccBd4UbSwDNSxCl6/gw9Z9QXXrJ4Po=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=oBwcT44vzbJlc60LuzTyDvemMBCA18ppGI4QtC7BgRAUggckojCQ51u7bICoVGNJ27K jL3IQTWEiV4kp1Xm+18fJS7y2ck79XEOXosttulNmCu246ZVenCplGdrvYDFkACeFTyW4 onMJvNAma4YxMElpWqIg2+Hzz4X5Pq6Py8g= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1654859001137100003 Content-Type: text/plain; charset="utf-8"; x-default="true" Fixes problems due to code assuming it runs with frame pointers and thus updates rbp / ebp registers when switching stacks. Signed-off-by: Gerd Hoffmann --- BaseTools/Conf/tools_def.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.t= emplate index a53199c9c76b..756f112b9395 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -1882,8 +1882,8 @@ DEFINE GCC_DEPS_FLAGS =3D -MMD -MF $@.de= ps =20 DEFINE GCC48_ALL_CC_FLAGS =3D DEF(GCC_ALL_CC_FLAGS) -ffunction-= sections -fdata-sections -DSTRING_ARRAY_NAME=3D$(BASE_NAME)Strings DEFINE GCC48_IA32_X64_DLINK_COMMON =3D -nostdlib -Wl,-n,-q,--gc-sections= -z common-page-size=3D0x20 -DEFINE GCC48_IA32_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) -m32 -mar= ch=3Di586 -malign-double -fno-stack-protector -D EFI32 -fno-asynchronous-un= wind-tables -Wno-address -DEFINE GCC48_X64_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) -m64 -fno= -stack-protector "-DEFIAPI=3D__attribute__((ms_abi))" -maccumulate-outgoing= -args -mno-red-zone -Wno-address -mcmodel=3Dsmall -fpie -fno-asynchronous-u= nwind-tables -Wno-address +DEFINE GCC48_IA32_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) -m32 -mar= ch=3Di586 -malign-double -fno-stack-protector -D EFI32 -fno-asynchronous-un= wind-tables -Wno-address -fno-omit-frame-pointer +DEFINE GCC48_X64_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) -m64 -fno= -stack-protector "-DEFIAPI=3D__attribute__((ms_abi))" -maccumulate-outgoing= -args -mno-red-zone -Wno-address -mcmodel=3Dsmall -fpie -fno-asynchronous-u= nwind-tables -Wno-address -fno-omit-frame-pointer DEFINE GCC48_IA32_X64_ASLDLINK_FLAGS =3D DEF(GCC48_IA32_X64_DLINK_COMMON) = -Wl,--entry,ReferenceAcpiTable -u ReferenceAcpiTable DEFINE GCC48_IA32_X64_DLINK_FLAGS =3D DEF(GCC48_IA32_X64_DLINK_COMMON) = -Wl,--entry,$(IMAGE_ENTRY_POINT) -u $(IMAGE_ENTRY_POINT) -Wl,-Map,$(DEST_DI= R_DEBUG)/$(BASE_NAME).map,--whole-archive DEFINE GCC48_IA32_DLINK2_FLAGS =3D -Wl,--defsym=3DPECOFF_HEADER_SIZE= =3D0x220 DEF(GCC_DLINK2_FLAGS_COMMON) --=20 2.36.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90443): https://edk2.groups.io/g/devel/message/90443 Mute This Topic: https://groups.io/mt/91665761/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-