[edk2-devel] [PATCH 2/3] ArmPlatformPkg: Fix target initialisation in cmd_load_symbols.py

Rebecca Cran posted 3 patches 3 years, 10 months ago
[edk2-devel] [PATCH 2/3] ArmPlatformPkg: Fix target initialisation in cmd_load_symbols.py
Posted by Rebecca Cran 3 years, 10 months ago
The debugger in Arm Development Studio 2021.2 doesn't work with
"ec = debugger.getExecutionContext(0)" because it's subsequently unable
to access memory. Fix it by switching to
"ec = debugger.getCurrentExecutionContext()".

The documentation for waitForStop() says:

"It is not needed after a call to stop() because stop() is blocking."

So, remove the call to waitForStop.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py b/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py
index 89d2f28ba27d..cb4db148dedf 100644
--- a/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py
+++ b/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py
@@ -85,11 +85,10 @@ else:
 debugger = Debugger()
 
 # Initialisation commands
-ec = debugger.getExecutionContext(0)
+ec = debugger.getCurrentExecutionContext()
 ec.getExecutionService().stop()
-ec.getExecutionService().waitForStop()
 # in case the execution context reference is out of date
-ec = debugger.getExecutionContext(0)
+ec = debugger.getCurrentExecutionContext()
 
 try:
     armplatform_debugger = edk2_debugger.ArmPlatformDebugger(ec, report_file, regions, verbose)
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88672): https://edk2.groups.io/g/devel/message/88672
Mute This Topic: https://groups.io/mt/90385957/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/3] ArmPlatformPkg: Fix target initialisation in cmd_load_symbols.py
Posted by Rebecca Cran 3 years, 10 months ago
Since the documentation was a bit difficult to find, I'll make a note here.

For Development Studio 2021.2 it was in 
/opt/arm/developmentstudio-2021.2/sw/ide/plugins/com.arm.debug.interpreter.jython.api_2021.2.0.20211118_074138/doc/arm_ds.html 
.


-- 
Rebecca Cran


On 4/10/22 19:16, Rebecca Cran wrote:
> The debugger in Arm Development Studio 2021.2 doesn't work with
> "ec = debugger.getExecutionContext(0)" because it's subsequently unable
> to access memory. Fix it by switching to
> "ec = debugger.getCurrentExecutionContext()".
>
> The documentation for waitForStop() says:
>
> "It is not needed after a call to stop() because stop() is blocking."
>
> So, remove the call to waitForStop.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>   ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py b/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py
> index 89d2f28ba27d..cb4db148dedf 100644
> --- a/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py
> +++ b/ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py
> @@ -85,11 +85,10 @@ else:
>   debugger = Debugger()
>   
>   # Initialisation commands
> -ec = debugger.getExecutionContext(0)
> +ec = debugger.getCurrentExecutionContext()
>   ec.getExecutionService().stop()
> -ec.getExecutionService().waitForStop()
>   # in case the execution context reference is out of date
> -ec = debugger.getExecutionContext(0)
> +ec = debugger.getCurrentExecutionContext()
>   
>   try:
>       armplatform_debugger = edk2_debugger.ArmPlatformDebugger(ec, report_file, regions, verbose)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88708): https://edk2.groups.io/g/devel/message/88708
Mute This Topic: https://groups.io/mt/90385957/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-