[edk2-devel] [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile

Rebecca Cran posted 3 patches 2 years ago
Failed in applying to current master (apply log)
ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py | 5 ++---
ArmPlatformPkg/Scripts/Ds5/edk2_debugger.py    | 2 +-
ArmPlatformPkg/Scripts/Makefile                | 2 +-
3 files changed, 4 insertions(+), 5 deletions(-)
[edk2-devel] [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile
Posted by Rebecca Cran 2 years ago
I ran into some problems debugging EDK2 code using Development Studio with
the files under ArmPlatformPkg/Scripts and these patches fix them.

I'm using Arm Development Studio 2021.2 and not DS-5, so I'm not sure if
these changes would break things for people using the older environment.

Rebecca Cran (3):
  ArmPlatformPkg: Fix error message in Scripts/Ds5/edk2_debugger.py
  ArmPlatformPkg: Fix target initialisation in cmd_load_symbols.py
  ArmPlatformPkg: Fix EDK2_DSC check in Scripts/Makefile

 ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py | 5 ++---
 ArmPlatformPkg/Scripts/Ds5/edk2_debugger.py    | 2 +-
 ArmPlatformPkg/Scripts/Makefile                | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88670): https://edk2.groups.io/g/devel/message/88670
Mute This Topic: https://groups.io/mt/90385955/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile
Posted by Rebecca Cran 2 years ago
Could I get some reviews on this please?


-- 

Rebecca Cran


On 4/10/22 19:16, Rebecca Cran wrote:
> I ran into some problems debugging EDK2 code using Development Studio with
> the files under ArmPlatformPkg/Scripts and these patches fix them.
>
> I'm using Arm Development Studio 2021.2 and not DS-5, so I'm not sure if
> these changes would break things for people using the older environment.
>
> Rebecca Cran (3):
>    ArmPlatformPkg: Fix error message in Scripts/Ds5/edk2_debugger.py
>    ArmPlatformPkg: Fix target initialisation in cmd_load_symbols.py
>    ArmPlatformPkg: Fix EDK2_DSC check in Scripts/Makefile
>
>   ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py | 5 ++---
>   ArmPlatformPkg/Scripts/Ds5/edk2_debugger.py    | 2 +-
>   ArmPlatformPkg/Scripts/Makefile                | 2 +-
>   3 files changed, 4 insertions(+), 5 deletions(-)
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89095): https://edk2.groups.io/g/devel/message/89095
Mute This Topic: https://groups.io/mt/90385955/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile
Posted by Ard Biesheuvel 1 year, 12 months ago
On Wed, 20 Apr 2022 at 02:43, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> Could I get some reviews on this please?
>

Merged as #2849

Thanks,

>
> --
>
> Rebecca Cran
>
>
> On 4/10/22 19:16, Rebecca Cran wrote:
> > I ran into some problems debugging EDK2 code using Development Studio with
> > the files under ArmPlatformPkg/Scripts and these patches fix them.
> >
> > I'm using Arm Development Studio 2021.2 and not DS-5, so I'm not sure if
> > these changes would break things for people using the older environment.
> >
> > Rebecca Cran (3):
> >    ArmPlatformPkg: Fix error message in Scripts/Ds5/edk2_debugger.py
> >    ArmPlatformPkg: Fix target initialisation in cmd_load_symbols.py
> >    ArmPlatformPkg: Fix EDK2_DSC check in Scripts/Makefile
> >
> >   ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py | 5 ++---
> >   ArmPlatformPkg/Scripts/Ds5/edk2_debugger.py    | 2 +-
> >   ArmPlatformPkg/Scripts/Makefile                | 2 +-
> >   3 files changed, 4 insertions(+), 5 deletions(-)
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89481): https://edk2.groups.io/g/devel/message/89481
Mute This Topic: https://groups.io/mt/90385955/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile
Posted by Rebecca Cran 2 years ago
Also, I noticed Scripts/Makefile defaults to RVCT. Are people still using that, or has everyone moved to gcc or the newer Arm compilers?

-- 
Rebecca Cran


On 4/10/22 19:16, Rebecca Cran wrote:
> I ran into some problems debugging EDK2 code using Development Studio with
> the files under ArmPlatformPkg/Scripts and these patches fix them.
>
> I'm using Arm Development Studio 2021.2 and not DS-5, so I'm not sure if
> these changes would break things for people using the older environment.
>
> Rebecca Cran (3):
>    ArmPlatformPkg: Fix error message in Scripts/Ds5/edk2_debugger.py
>    ArmPlatformPkg: Fix target initialisation in cmd_load_symbols.py
>    ArmPlatformPkg: Fix EDK2_DSC check in Scripts/Makefile
>
>   ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py | 5 ++---
>   ArmPlatformPkg/Scripts/Ds5/edk2_debugger.py    | 2 +-
>   ArmPlatformPkg/Scripts/Makefile                | 2 +-
>   3 files changed, 4 insertions(+), 5 deletions(-)
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88674): https://edk2.groups.io/g/devel/message/88674
Mute This Topic: https://groups.io/mt/90385955/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile
Posted by Ard Biesheuvel 2 years ago
On Mon, 11 Apr 2022 at 03:18, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> Also, I noticed Scripts/Makefile defaults to RVCT. Are people still using that, or has everyone moved to gcc or the newer Arm compilers?
>

RVCT is 32-bit only, as far as I know, so I don't think anyone still
cares about it.

> --
> Rebecca Cran
>
>
> On 4/10/22 19:16, Rebecca Cran wrote:
>
> I ran into some problems debugging EDK2 code using Development Studio with
> the files under ArmPlatformPkg/Scripts and these patches fix them.
>
> I'm using Arm Development Studio 2021.2 and not DS-5, so I'm not sure if
> these changes would break things for people using the older environment.
>
> Rebecca Cran (3):
>   ArmPlatformPkg: Fix error message in Scripts/Ds5/edk2_debugger.py
>   ArmPlatformPkg: Fix target initialisation in cmd_load_symbols.py
>   ArmPlatformPkg: Fix EDK2_DSC check in Scripts/Makefile
>
>  ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py | 5 ++---
>  ArmPlatformPkg/Scripts/Ds5/edk2_debugger.py    | 2 +-
>  ArmPlatformPkg/Scripts/Makefile                | 2 +-
>  3 files changed, 4 insertions(+), 5 deletions(-)
>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88875): https://edk2.groups.io/g/devel/message/88875
Mute This Topic: https://groups.io/mt/90385955/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile
Posted by Rebecca Cran 2 years ago
On 4/13/22 10:51, Ard Biesheuvel wrote:
> On Mon, 11 Apr 2022 at 03:18, Rebecca Cran <rebecca@bsdio.com> wrote:
>> Also, I noticed Scripts/Makefile defaults to RVCT. Are people still using that, or has everyone moved to gcc or the newer Arm compilers?
>>
> RVCT is 32-bit only, as far as I know, so I don't think anyone still
> cares about it.

Thanks. If there's agreement I can put together a set of patches to 
remove support from the various places we have it in the tree (e.g. 
here, Conf/tools_def.txt etc.)

-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88876): https://edk2.groups.io/g/devel/message/88876
Mute This Topic: https://groups.io/mt/90385955/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-