Spell Check File Mask Leak into Sequential Package Checks

[edk2-devel] [PATCH v1 0/1] Spell Check File Mask Leak into Sequential Package Checks

Kun Qin posted 1 patch 2 years, 10 months ago

Download series mbox

Failed in applying to current master (apply log)

.pytool/Plugin/SpellCheck/SpellCheck.py | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

Expand all Fold all

[edk2-devel] [PATCH v1 0/1] Spell Check File Mask Leak into Sequential Package Checks

Posted by Kun Qin 2 years, 10 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3443

Current spell check routine on CI build pipelines is ignoring some files
incorrectly.

The issue is class variable, STANDARD_PLUGIN_DEFINED_PATHS from
SpellCheck.py, is a list. In a local function the list is assigned to a
local variable, which is then modified based on the package config. But
the modification of this local variable will change the class variable
and then leaks to the next package.

The proposed solution in this patch series is to convert class member to
tuple so that is read-only. Then copy into list in the local function
before package specific modifications.

Patch v1 branch: https://github.com/kuqin12/edk2/tree/spell_check_v1

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>

Sean Brogan (1):
  Pytool: SpellCheck: Fix incorrect file mask across package matrices

 .pytool/Plugin/SpellCheck/SpellCheck.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76309): https://edk2.groups.io/g/devel/message/76309
Mute This Topic: https://groups.io/mt/83435987/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-