From nobody Wed May 15 22:29:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+76310+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76310+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1623289667; cv=none; d=zohomail.com; s=zohoarc; b=mk2cmp1Q59vcp2f+XX09aUmyMQ5Z+PMEW8qJHn3KZ9s3CnZ/ZXQcCKk3+5WIH/Ue3/wGgY99YR31AkMpVHLg6dhrU92sx4gpwhyrPbXY7ncUO3rBPGJCySasIIcnuTvDxK+0B8ue7URAgS8KV08VkahFoiopHy+pFlq7Osy8I2c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623289667; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=qej1ndyurjO3/o4FXeFjr7NW0juNiK5CXLxypZ2nUg4=; b=R3zgwUZRFueDEjNgkS61zSVE4suVU2IDUhZJriJndDjygrdBqUDttM4eGt4QImmqrbxTl9WLNJMYetSy1MJMoeh34pnv4IYlHKKmSSJfSOde9RS5+RExs8TBhaJypLzIfg5HK+RG8KVQdN5TtGpHI3zdE33bShAbbpoIpI5IBUw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+76310+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1623289667860547.3034298499118; Wed, 9 Jun 2021 18:47:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id dMayYY1788612xN3y9MPr7J4; Wed, 09 Jun 2021 18:47:47 -0700 X-Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mx.groups.io with SMTP id smtpd.web08.4476.1623289666977827246 for ; Wed, 09 Jun 2021 18:47:47 -0700 X-Received: by mail-pl1-f178.google.com with SMTP id 69so126260plc.5 for ; Wed, 09 Jun 2021 18:47:46 -0700 (PDT) X-Gm-Message-State: Jq6QYD4zwyRbcCgwNsCquosbx1787277AA= X-Google-Smtp-Source: ABdhPJxukuzGQTO/ITusyJCaG14KjeVzfskpwx1gy/VkqXdqWLUdgiFay5gHgEpkUgIqhk64IivmDg== X-Received: by 2002:a17:902:c3d5:b029:100:742f:fce9 with SMTP id j21-20020a170902c3d5b0290100742ffce9mr2489592plj.46.1623289666324; Wed, 09 Jun 2021 18:47:46 -0700 (PDT) X-Received: from localhost.localdomain ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id o17sm6187492pjp.33.2021.06.09.18.47.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 18:47:45 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao Subject: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Fix incorrect file mask across package matrices Date: Wed, 9 Jun 2021 18:47:33 -0700 Message-Id: <20210610014733.1267-2-kuqin12@gmail.com> In-Reply-To: <20210610014733.1267-1-kuqin12@gmail.com> References: <20210610014733.1267-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1623289667; bh=gAFAyXehhKOjSZu6K42ggMxtU46zz5lLDRZumPX/WG4=; h=Cc:Date:From:Reply-To:Subject:To; b=BDEK9jASU2jMWRnCPsIpuhURAXMNEO/MbxI2k/E0JaNo9j3ld9BVf+mfGWCVAelMxFM dLlATTgdj69KtcYCh3er4Gr574E8jYXDBaWyMZmRQQp8nXUk1Ad39RI1LA4RJRcZ+zCLN eUhnC6n90yyvtGJbtufO3xnqd5EKjVkpHz4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3443 Existing implementation could modify class global data that causes potential incorrect file mask to be used for execution of plugin. This change switches class variable to be tuple so that it cannot be accidently modified. Local usage of STANDARD_PLUGIN_DEFINED_PATHS is also changed to copy to new list before modification. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Sean Brogan Reviewed-by: Liming Gao --- .pytool/Plugin/SpellCheck/SpellCheck.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py b/.pytool/Plugin/Spell= Check/SpellCheck.py index 43365441b91c..9ad57632a6e8 100644 --- a/.pytool/Plugin/SpellCheck/SpellCheck.py +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py @@ -37,12 +37,12 @@ class SpellCheck(ICiBuildPlugin): # # A package can remove any of these using IgnoreStandardPaths # - STANDARD_PLUGIN_DEFINED_PATHS =3D ["*.c", "*.h", + STANDARD_PLUGIN_DEFINED_PATHS =3D ("*.c", "*.h", "*.nasm", "*.asm", "*.masm", "*.s", "*.asl", "*.dsc", "*.dec", "*.fdf", "*.inf", "*.md", "*.txt" - ] + ) =20 def GetTestName(self, packagename: str, environment: VarDict) -> tuple: """ Provide the testcase name and classname for use in reporting @@ -107,7 +107,8 @@ class SpellCheck(ICiBuildPlugin): version_aggregator.GetVersionAggregator().ReportVersion( "CSpell", cspell_version, version_aggregator.VersionTypes.INFO) =20 - package_relative_paths_to_spell_check =3D SpellCheck.STANDARD_PLUG= IN_DEFINED_PATHS + # copy the default as a list + package_relative_paths_to_spell_check =3D list(SpellCheck.STANDARD= _PLUGIN_DEFINED_PATHS) =20 # # Allow the ci.yaml to remove any of the above standard paths --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76310): https://edk2.groups.io/g/devel/message/76310 Mute This Topic: https://groups.io/mt/83435989/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-