.../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 -------- .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++ .../LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 -- .../Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 ----- .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 -- 5 files changed, 2 insertions(+), 17 deletions(-)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224 Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5. These build errors occur only with DEBUG target because RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but DEBUG_GCC5_X64_CC_FLAGS doesn't. https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_unused-but-set-variable_v1 Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Heng Luo <heng.luo@intel.com> Takuto Naito (2): TigerlakeSiliconPkg: Fix build error with GCC5 TigerlakeOpenBoardPkg: Fix build error with GCC5 .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 -------- .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++ .../LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 -- .../Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 ----- .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 -- 5 files changed, 2 insertions(+), 17 deletions(-) -- 2.30.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72130): https://edk2.groups.io/g/devel/message/72130 Mute This Topic: https://groups.io/mt/80867658/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thank You Takuto! For the series... Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> > -----Original Message----- > From: Takuto Naito <naitaku@gmail.com> > Sent: Tuesday, February 23, 2021 5:38 PM > To: devel@edk2.groups.io > Cc: Takuto Naito <naitaku@gmail.com>; Chaganty, Rangasai V > <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com> > Subject: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build > error with GCC5 > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224 > > Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5. > These build errors occur only with DEBUG target because > RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but > DEBUG_GCC5_X64_CC_FLAGS doesn't. > > https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_unused-but- > set-variable_v1 > > Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Heng Luo <heng.luo@intel.com> > > Takuto Naito (2): > TigerlakeSiliconPkg: Fix build error with GCC5 > TigerlakeOpenBoardPkg: Fix build error with GCC5 > > .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 -------- > .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++ > .../LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 -- > .../Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 ----- > .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 -- > 5 files changed, 2 insertions(+), 17 deletions(-) > > -- > 2.30.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72139): https://edk2.groups.io/g/devel/message/72139 Mute This Topic: https://groups.io/mt/80867658/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thanks Takuto Naito! For the series.. Reviewed-by: Heng Luo <heng.luo@intel.com> > -----Original Message----- > From: Takuto Naito <naitaku@gmail.com> > Sent: Wednesday, February 24, 2021 9:38 AM > To: devel@edk2.groups.io > Cc: Takuto Naito <naitaku@gmail.com>; Chaganty, Rangasai V > <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com> > Subject: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build > error with GCC5 > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224 > > Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5. > These build errors occur only with DEBUG target because > RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but > DEBUG_GCC5_X64_CC_FLAGS doesn't. > > https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_unused-but- > set-variable_v1 > > Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Heng Luo <heng.luo@intel.com> > > Takuto Naito (2): > TigerlakeSiliconPkg: Fix build error with GCC5 > TigerlakeOpenBoardPkg: Fix build error with GCC5 > > .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 -------- > .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++ > .../LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 -- > .../Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 ----- > .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 -- > 5 files changed, 2 insertions(+), 17 deletions(-) > > -- > 2.30.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72143): https://edk2.groups.io/g/devel/message/72143 Mute This Topic: https://groups.io/mt/80867658/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
The series has been pushed as 33ba808~.. 9951457 Thanks, Nate > -----Original Message----- > From: Takuto Naito <naitaku@gmail.com> > Sent: Tuesday, February 23, 2021 5:38 PM > To: devel@edk2.groups.io > Cc: Takuto Naito <naitaku@gmail.com>; Chaganty, Rangasai V > <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com> > Subject: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build > error with GCC5 > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224 > > Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5. > These build errors occur only with DEBUG target because > RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but > DEBUG_GCC5_X64_CC_FLAGS doesn't. > > https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_unused-but- > set-variable_v1 > > Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Heng Luo <heng.luo@intel.com> > > Takuto Naito (2): > TigerlakeSiliconPkg: Fix build error with GCC5 > TigerlakeOpenBoardPkg: Fix build error with GCC5 > > .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 -------- > .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++ > .../LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 -- > .../Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 ----- > .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 -- > 5 files changed, 2 insertions(+), 17 deletions(-) > > -- > 2.30.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72166): https://edk2.groups.io/g/devel/message/72166 Mute This Topic: https://groups.io/mt/80867658/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi, Actually, I have created a github repository which provides nightly builds of some platforms in edk2-platoforms. https://github.com/naitaku/edk2-platforms-build Now that TigerlakeURvp is built successfully with GCC5, I have added it to the target of the nightly builds. Thank you for your support! Regards, Takuto Naito On Thu, Feb 25, 2021 at 11:19 AM Desimone, Nathaniel L < nathaniel.l.desimone@intel.com> wrote: > The series has been pushed as 33ba808~.. 9951457 > > Thanks, > Nate > > > -----Original Message----- > > From: Takuto Naito <naitaku@gmail.com> > > Sent: Tuesday, February 23, 2021 5:38 PM > > To: devel@edk2.groups.io > > Cc: Takuto Naito <naitaku@gmail.com>; Chaganty, Rangasai V > > <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L > > <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com> > > Subject: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build > > error with GCC5 > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224 > > > > Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5. > > These build errors occur only with DEBUG target because > > RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but > > DEBUG_GCC5_X64_CC_FLAGS doesn't. > > > > https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_unused-but- > > set-variable_v1 > > > > Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > > Cc: Heng Luo <heng.luo@intel.com> > > > > Takuto Naito (2): > > TigerlakeSiliconPkg: Fix build error with GCC5 > > TigerlakeOpenBoardPkg: Fix build error with GCC5 > > > > .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 -------- > > .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++ > > .../LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 -- > > .../Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 ----- > > .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 -- > > 5 files changed, 2 insertions(+), 17 deletions(-) > > > > -- > > 2.30.1 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72250): https://edk2.groups.io/g/devel/message/72250 Mute This Topic: https://groups.io/mt/80867658/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thank you Takuto, that is very helpful! From: Takuto Naito <naitaku@gmail.com> Sent: Saturday, February 27, 2021 6:41 AM To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> Cc: devel@edk2.groups.io; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Luo, Heng <heng.luo@intel.com> Subject: Re: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5 Hi, Actually, I have created a github repository which provides nightly builds of some platforms in edk2-platoforms. https://github.com/naitaku/edk2-platforms-build Now that TigerlakeURvp is built successfully with GCC5, I have added it to the target of the nightly builds. Thank you for your support! Regards, Takuto Naito On Thu, Feb 25, 2021 at 11:19 AM Desimone, Nathaniel L <mailto:nathaniel.l.desimone@intel.com> wrote: The series has been pushed as 33ba808~.. 9951457 Thanks, Nate > -----Original Message----- > From: Takuto Naito <mailto:naitaku@gmail.com> > Sent: Tuesday, February 23, 2021 5:38 PM > To: mailto:devel@edk2.groups.io > Cc: Takuto Naito <mailto:naitaku@gmail.com>; Chaganty, Rangasai V > <mailto:rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L > <mailto:nathaniel.l.desimone@intel.com>; Luo, Heng <mailto:heng.luo@intel.com> > Subject: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build > error with GCC5 > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224 > > Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5. > These build errors occur only with DEBUG target because > RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but > DEBUG_GCC5_X64_CC_FLAGS doesn't. > > https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_unused-but- > set-variable_v1 > > Cc: Sai Chaganty <mailto:rangasai.v.chaganty@intel.com> > Cc: Nate DeSimone <mailto:nathaniel.l.desimone@intel.com> > Cc: Heng Luo <mailto:heng.luo@intel.com> > > Takuto Naito (2): > TigerlakeSiliconPkg: Fix build error with GCC5 > TigerlakeOpenBoardPkg: Fix build error with GCC5 > > .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 -------- > .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++ > .../LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 -- > .../Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 ----- > .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 -- > 5 files changed, 2 insertions(+), 17 deletions(-) > > -- > 2.30.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72317): https://edk2.groups.io/g/devel/message/72317 Mute This Topic: https://groups.io/mt/80867658/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.