From nobody Fri May 3 13:40:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72131+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72131+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1614130745; cv=none; d=zohomail.com; s=zohoarc; b=UTSe95fvB+UTNbT2bhmYJulfWOAq02odNpM59ZJw0a1OhB6NVXg/SMbC107m7AyaW/qtamm8LTgTnMwEy2+LzY7EDtsIWdszKH3kkJ1OKoX/T0Klqd+U5QI+3RxyXjUf8uuB3cP/D96+a4nkYLGyTlh0Udc91W6J9blpOwJoGew= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614130745; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=7N33NIGuA0KlnokwtMyiNpxIbkvyf+xDM8N8P+aJzNQ=; b=V8qcN13BQPjpCDVlRnKVCEiTZ9pYcT5ttgIbu2H+VCiKLqwfkzsCEEakQrwM3ACzYE2063/onB20LdLIWKtbU94CLodVywyHIZHthtOhMNyDI2diMF41jDeX9FAwb8haTd7xQDpAAsRjsfbTQ35jaEA4ZG1k9ZdinG1LfWPjUIQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72131+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614130745307680.9931709067143; Tue, 23 Feb 2021 17:39:05 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id pwmvYY1788612xVl23FgDf9P; Tue, 23 Feb 2021 17:39:04 -0800 X-Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mx.groups.io with SMTP id smtpd.web11.1181.1614130744492915070 for ; Tue, 23 Feb 2021 17:39:04 -0800 X-Received: by mail-pg1-f170.google.com with SMTP id p21so381112pgl.12 for ; Tue, 23 Feb 2021 17:39:04 -0800 (PST) X-Gm-Message-State: SSPoaJl9tUyGcz8jmROWT4lYx1787277AA= X-Google-Smtp-Source: ABdhPJzGm78QXiyOTXEdQsgDimNC/nqueTsjOw8oaewvCQQJhr2yrnl3DHeBzpZbcYeU/4ch5mt+OQ== X-Received: by 2002:aa7:84cb:0:b029:1ed:9b6f:1b6f with SMTP id x11-20020aa784cb0000b02901ed9b6f1b6fmr4903890pfn.57.1614130743552; Tue, 23 Feb 2021 17:39:03 -0800 (PST) X-Received: from localhost.localdomain ([240d:1e:84:2c00:4c90:1fc7:fcf3:2538]) by smtp.googlemail.com with ESMTPSA id bj9sm340236pjb.49.2021.02.23.17.39.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Feb 2021 17:39:03 -0800 (PST) From: "Takuto Naito" To: devel@edk2.groups.io Cc: Takuto Naito , Sai Chaganty , Nate DeSimone , Heng Luo Subject: [edk2-devel] [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: Fix build error with GCC5 Date: Wed, 24 Feb 2021 10:37:35 +0900 Message-Id: <20210224013736.74815-2-naitaku@gmail.com> In-Reply-To: <20210224013736.74815-1-naitaku@gmail.com> References: <20210224013736.74815-1-naitaku@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,naitaku@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614130744; bh=i64IS211GNxzbTvG42wqagdekRIRLPL/6W9jAV26o4I=; h=Cc:Date:From:Reply-To:Subject:To; b=Xg0/tOt41e/qLR4YmIF05sg7uGeBs0hTlM4Sn8tQwPBaUOl5yfCLg/WHDeN+Xig2u4y LOWvY/HpqmQICIqI5EJGS1Xwo3mNZTyGHgMbNGT9PLkt//wAzqGaYMZFJWHBX809FPpCy B0AB38ZcZeeAIzkFP7DfbcAgMvOwrN6DPZQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3224 Fix build errors caused by "-Werror=3Dunused-but-set-variable" with GCC5. These build errors occur only with DEBUG target because RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but DEBUG_GCC5_X64_CC_FLAGS doesn't. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Takuto Naito Reviewed-by: Heng Luo --- .../PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 -- .../IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 ----- .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 -- 3 files changed, 9 deletions(-) diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivat= e/PcieClientRpLib/PcieClientRpLib.c b/Silicon/Intel/TigerlakeSiliconPkg/IpB= lock/PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c index 15d295a573..231cb367bc 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieC= lientRpLib/PcieClientRpLib.c +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieC= lientRpLib/PcieClientRpLib.c @@ -104,12 +104,10 @@ ConfigureRpLtrOverride ( UINT32 OvrEn; UINT32 OvrVal; BOOLEAN IsCpuPcie; - UINT32 LtrCfgLock; =20 IsCpuPcie =3D FALSE; OvrEn =3D 0; OvrVal =3D 0; - LtrCfgLock =3D 0; =20 if (DevNum =3D=3D SA_PEG0_DEV_NUM || DevNum =3D=3D SA_PEG3_DEV_NUM) { IsCpuPcie =3D TRUE; diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/D= xeVtdInitLib/DxeVtdInitLib.c b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vt= d/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c index faac07c45d..e88abe550f 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdIn= itLib/DxeVtdInitLib.c +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdIn= itLib/DxeVtdInitLib.c @@ -313,8 +313,6 @@ DmarTableUpdate ( UINTN Offset; UINTN StructureLen; UINT64 McD0BaseAddress; - UINT32 GttMmAdr; - UINT64 McD2BaseAddress; UINT16 IgdMode; UINT16 GttMode; UINT32 IgdMemSize; @@ -381,9 +379,6 @@ DmarTableUpdate ( GttMemSize =3D (1 << GttMode) * (1024) * (1024); } =20 - McD2BaseAddress =3D PCI_SEGMENT_LIB_ADDRESS (SA_SEG_NUM, IGD_BUS_NUM, IG= D_DEV_NUM, IGD_FUN_NUM, 0); - GttMmAdr =3D (PciSegmentRead32 (McD2BaseAddress + R_SA_IGD_GTTMMADR)) & = 0xFFFFFFF0; - DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress =3D (Pci= SegmentRead32 (McD0BaseAddress + R_SA_BGSM) & ~(0x01)); DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionLimitAddress =3D Dmar= Table->RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress + IgdMemSize + Gt= tMemSize - 1; DEBUG ((DEBUG_INFO, "RMRR Base address IGD %016lX\n", DmarTable->RmrrIg= d.RmrrHeader.ReservedMemoryRegionBaseAddress)); diff --git a/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/Pch= SmiHelperClient.c b/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/= Smm/PchSmiHelperClient.c index 7693e76683..3adc05ce89 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelp= erClient.c +++ b/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelp= erClient.c @@ -29,8 +29,6 @@ GetPcieRpNumber ( OUT UINTN *RpNumber ) { - UINT64 RpBase; - RpBase =3D PCI_SEGMENT_LIB_ADDRESS (SA_SEG_NUM, SA_MC_BUS, RpDev, RpFun,= 0); GetPchPcieRpNumber (RpDev, RpFun, RpNumber); } =20 --=20 2.30.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72131): https://edk2.groups.io/g/devel/message/72131 Mute This Topic: https://groups.io/mt/80867664/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:40:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+72132+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72132+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1614130754; cv=none; d=zohomail.com; s=zohoarc; b=niPa6QoNKpEurkEV1x+1dY9BXAQrnZLSnxUQCejdmpU2ICCN1D/ToYkczPu8Ri/oILCLG29k3hNR/dKdj6HWolFC31Nh1r4ivdw+f+yGWJjg9rfYeo1ZW0+KXxL2PCPac4WxIWWHZa3sIB9k6Mjer0f4J8+Eew74WM68Sb8sd6M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614130754; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ivtJvFL7Ae/mO06twvX3DOPza89wwFjtE+OwokX8xOo=; b=RhpZg6YY9IMHEFT7zvHzIiyTzjMV1QqsF4Vy+QFHuXielb9UVgXVgUKU/F3hut4fbNx7NZgm1PwdQZLJy2X+Zm8qw6skPRFCNXkp3JrQZQKfy9I/VwqfjFQJnyb0Zq/D1TLfn+hzAgx/Z1x2KGbbTeoc50HtvUjN8W5MfZziZNU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+72132+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1614130753984721.4289686704249; Tue, 23 Feb 2021 17:39:13 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id KnJBYY1788612xNHyzXrJ2s4; Tue, 23 Feb 2021 17:39:13 -0800 X-Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mx.groups.io with SMTP id smtpd.web11.1184.1614130748295588563 for ; Tue, 23 Feb 2021 17:39:08 -0800 X-Received: by mail-pj1-f43.google.com with SMTP id gm18so212492pjb.1 for ; Tue, 23 Feb 2021 17:39:08 -0800 (PST) X-Gm-Message-State: 1mZzwkj3XX6T5t2Y6JLtvEIUx1787277AA= X-Google-Smtp-Source: ABdhPJx1TJV2r9oM7tq4l4UjJFeOYyz026RGabWn8f+KlAQaY8gh7DEh/vFvj2s8a7p8aCaqh+Qt6Q== X-Received: by 2002:a17:90a:f493:: with SMTP id bx19mr1656536pjb.213.1614130747402; Tue, 23 Feb 2021 17:39:07 -0800 (PST) X-Received: from localhost.localdomain ([240d:1e:84:2c00:4c90:1fc7:fcf3:2538]) by smtp.googlemail.com with ESMTPSA id bj9sm340236pjb.49.2021.02.23.17.39.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Feb 2021 17:39:07 -0800 (PST) From: "Takuto Naito" To: devel@edk2.groups.io Cc: Takuto Naito , Sai Chaganty , Nate DeSimone , Heng Luo Subject: [edk2-devel] [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg: Fix build error with GCC5 Date: Wed, 24 Feb 2021 10:37:36 +0900 Message-Id: <20210224013736.74815-3-naitaku@gmail.com> In-Reply-To: <20210224013736.74815-1-naitaku@gmail.com> References: <20210224013736.74815-1-naitaku@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,naitaku@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1614130753; bh=QCVztFhr3TwC+xhvUIWcoxbb4D/j5+7m0TvnwWsKjzQ=; h=Cc:Date:From:Reply-To:Subject:To; b=liyv9hIS5c2+P8eiDCAmE6XdXPHXUbXfk3cEKl1FcPJ9K69KVkTMVoSZG4gjSGnj9rS WgaH15Ips6HrWJzzHtlSSRlKKU8kzXH/E9s/OufdjnBPlm92e5RB5TSz8rrPd0/ckUamw kuujnY3NsRTOFJoFVB+DklkDVDC8UXu1cQ4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3224 Fix build errors caused by "-Werror=3Dunused-but-set-variable" with GCC5. These build errors occur only with DEBUG target because RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but DEBUG_GCC5_X64_CC_FLAGS doesn't. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Takuto Naito Reviewed-by: Heng Luo --- .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 -------- .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookL= ib/BasePlatformHookLib.c b/Platform/Intel/TigerlakeOpenBoardPkg/Library/Bas= ePlatformHookLib/BasePlatformHookLib.c index cc5337698b..0baee8795d 100644 --- a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/Base= PlatformHookLib.c +++ b/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/Base= PlatformHookLib.c @@ -182,14 +182,6 @@ PlatformHookSerialPortInitialize ( VOID ) { - UINT16 IndexPort; - UINT16 DataPort; - UINT8 Index; - - IndexPort =3D 0; - DataPort =3D 0; - Index =3D 0; - // // Enable I/O decoding for COM1(3F8h-3FFh), COM2(2F8h-2FFh), I/O port 2E= h/2Fh, 4Eh/4Fh, 60h/64Fh and 62h/66h. // diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/Boa= rdInitLib/PeiTigerlakeURvpInitPreMemLib.c b/Platform/Intel/TigerlakeOpenBoa= rdPkg/TigerlakeURvp/Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c index 2ad229c1cd..0bba41e6d4 100644 --- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitL= ib/PeiTigerlakeURvpInitPreMemLib.c +++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitL= ib/PeiTigerlakeURvpInitPreMemLib.c @@ -393,6 +393,7 @@ TigerlakeURvpInitPreMem ( /// Performing PlatformInitPreMemCallBack after PeiReadOnlyVariable2 PPI= produced /// Status =3D PeiServicesNotifyPpi (&mPreMemNotifyList); + ASSERT_EFI_ERROR (Status); =20 /// /// After code reorangized, memorycallback will run because the PPI is a= lready @@ -400,6 +401,7 @@ TigerlakeURvpInitPreMem ( /// done before. /// Status =3D PeiServicesNotifyPpi (&mMemDiscoveredNotifyList); + ASSERT_EFI_ERROR (Status); =20 DEBUG ((DEBUG_INFO, "TigerlakeURvpInitPreMem End!\n")); =20 --=20 2.30.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72132): https://edk2.groups.io/g/devel/message/72132 Mute This Topic: https://groups.io/mt/80867667/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-