[edk2-devel] [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5

Takuto Naito posted 2 patches 3 years, 2 months ago
Failed in applying to current master (apply log)
.../PeiFspPolicyInitLib.inf                   |   2 +-
.../BasePlatformHookLib/BasePlatformHookLib.c | 188 ------------------
.../DxeSiliconPolicyUpdateLate.c              |   2 +-
.../DxePchPcieRpPolicyLib.c                   |   2 +-
4 files changed, 3 insertions(+), 191 deletions(-)
[edk2-devel] [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5
Posted by Takuto Naito 3 years, 2 months ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
TigerlakeOpenBoard: Fix build errors with GCC5

v2:
- Split the v1 patch into 2 patches.
  One is for Platform/Intel/TigerlakeOpenBoardPkg,
  another one is for edk2-platforms\Silicon\Intel\TigerlakeSiliconPkg.

https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_build_error_v2

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Heng Luo <heng.luo@intel.com>

Takuto Naito (2):
  TigerlakeOpenBoardPkg: Fix build errors with GCC5
  TigerlakeSiliconPkg/IpBlock: Fix build errors with GCC5

 .../PeiFspPolicyInitLib.inf                   |   2 +-
 .../BasePlatformHookLib/BasePlatformHookLib.c | 188 ------------------
 .../DxeSiliconPolicyUpdateLate.c              |   2 +-
 .../DxePchPcieRpPolicyLib.c                   |   2 +-
 4 files changed, 3 insertions(+), 191 deletions(-)

-- 
2.30.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71893): https://edk2.groups.io/g/devel/message/71893
Mute This Topic: https://groups.io/mt/80801576/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5
Posted by Nate DeSimone 3 years, 2 months ago
The series has been pushed as 12ef75d~.. 9fb5174

Thanks,
Nate

> -----Original Message-----
> From: Takuto Naito <naitaku@gmail.com>
> Sent: Sunday, February 21, 2021 7:10 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone,
> Nathaniel L <nathaniel.l.desimone@intel.com>; Luo, Heng
> <heng.luo@intel.com>
> Subject: [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
> TigerlakeOpenBoard: Fix build errors with GCC5
> 
> v2:
> - Split the v1 patch into 2 patches.
>   One is for Platform/Intel/TigerlakeOpenBoardPkg,
>   another one is for edk2-platforms\Silicon\Intel\TigerlakeSiliconPkg.
> 
> https://github.com/naitaku/edk2-
> platforms/tree/tigerlake_fix_build_error_v2
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> 
> Takuto Naito (2):
>   TigerlakeOpenBoardPkg: Fix build errors with GCC5
>   TigerlakeSiliconPkg/IpBlock: Fix build errors with GCC5
> 
>  .../PeiFspPolicyInitLib.inf                   |   2 +-
>  .../BasePlatformHookLib/BasePlatformHookLib.c | 188 ------------------
>  .../DxeSiliconPolicyUpdateLate.c              |   2 +-
>  .../DxePchPcieRpPolicyLib.c                   |   2 +-
>  4 files changed, 3 insertions(+), 191 deletions(-)
> 
> --
> 2.30.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72004): https://edk2.groups.io/g/devel/message/72004
Mute This Topic: https://groups.io/mt/80801576/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5
Posted by Takuto Naito 3 years, 1 month ago
Hi Nate and Heng,

The RELEASE build now succeeds, but I noticed that DEBUG build still fails.
I'm trying to fix it. Do you need me to submit another BZ ticket or use the
same ticket?

Best regards,
Takuto Naito

On Tue, Feb 23, 2021 at 7:27 AM Desimone, Nathaniel L <
nathaniel.l.desimone@intel.com> wrote:

> The series has been pushed as 12ef75d~.. 9fb5174
>
> Thanks,
> Nate
>
> > -----Original Message-----
> > From: Takuto Naito <naitaku@gmail.com>
> > Sent: Sunday, February 21, 2021 7:10 AM
> > To: devel@edk2.groups.io
> > Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone,
> > Nathaniel L <nathaniel.l.desimone@intel.com>; Luo, Heng
> > <heng.luo@intel.com>
> > Subject: [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
> > TigerlakeOpenBoard: Fix build errors with GCC5
> >
> > v2:
> > - Split the v1 patch into 2 patches.
> >   One is for Platform/Intel/TigerlakeOpenBoardPkg,
> >   another one is for edk2-platforms\Silicon\Intel\TigerlakeSiliconPkg.
> >
> > https://github.com/naitaku/edk2-
> > platforms/tree/tigerlake_fix_build_error_v2
> >
> > Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Heng Luo <heng.luo@intel.com>
> >
> > Takuto Naito (2):
> >   TigerlakeOpenBoardPkg: Fix build errors with GCC5
> >   TigerlakeSiliconPkg/IpBlock: Fix build errors with GCC5
> >
> >  .../PeiFspPolicyInitLib.inf                   |   2 +-
> >  .../BasePlatformHookLib/BasePlatformHookLib.c | 188 ------------------
> >  .../DxeSiliconPolicyUpdateLate.c              |   2 +-
> >  .../DxePchPcieRpPolicyLib.c                   |   2 +-
> >  4 files changed, 3 insertions(+), 191 deletions(-)
> >
> > --
> > 2.30.1
>
> --
内藤 卓人
Takuto Naito


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72092): https://edk2.groups.io/g/devel/message/72092
Mute This Topic: https://groups.io/mt/80801576/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5
Posted by Heng Luo 3 years, 1 month ago
Hi Takuto Naito,
I think you can add comments in the same BZ ticket and then use it.

Thanks,
Heng

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Takuto Naito
Sent: Wednesday, February 24, 2021 1:02 AM
To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5

Hi Nate and Heng,

The RELEASE build now succeeds, but I noticed that DEBUG build still fails.
I'm trying to fix it. Do you need me to submit another BZ ticket or use the same ticket?

Best regards,
Takuto Naito

On Tue, Feb 23, 2021 at 7:27 AM Desimone, Nathaniel L <nathaniel.l.desimone@intel.com<mailto:nathaniel.l.desimone@intel.com>> wrote:
The series has been pushed as 12ef75d~.. 9fb5174

Thanks,
Nate

> -----Original Message-----
> From: Takuto Naito <naitaku@gmail.com<mailto:naitaku@gmail.com>>
> Sent: Sunday, February 21, 2021 7:10 AM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com<mailto:rangasai.v.chaganty@intel.com>>; Desimone,
> Nathaniel L <nathaniel.l.desimone@intel.com<mailto:nathaniel.l.desimone@intel.com>>; Luo, Heng
> <heng.luo@intel.com<mailto:heng.luo@intel.com>>
> Subject: [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
> TigerlakeOpenBoard: Fix build errors with GCC5
>
> v2:
> - Split the v1 patch into 2 patches.
>   One is for Platform/Intel/TigerlakeOpenBoardPkg,
>   another one is for edk2-platforms\Silicon\Intel\TigerlakeSiliconPkg.
>
> https://github.com/naitaku/edk2-
> platforms/tree/tigerlake_fix_build_error_v2
>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com<mailto:rangasai.v.chaganty@intel.com>>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com<mailto:nathaniel.l.desimone@intel.com>>
> Cc: Heng Luo <heng.luo@intel.com<mailto:heng.luo@intel.com>>
>
> Takuto Naito (2):
>   TigerlakeOpenBoardPkg: Fix build errors with GCC5
>   TigerlakeSiliconPkg/IpBlock: Fix build errors with GCC5
>
>  .../PeiFspPolicyInitLib.inf                   |   2 +-
>  .../BasePlatformHookLib/BasePlatformHookLib.c | 188 ------------------
>  .../DxeSiliconPolicyUpdateLate.c              |   2 +-
>  .../DxePchPcieRpPolicyLib.c                   |   2 +-
>  4 files changed, 3 insertions(+), 191 deletions(-)
>
> --
> 2.30.1
--
内藤 卓人
Takuto Naito



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72122): https://edk2.groups.io/g/devel/message/72122
Mute This Topic: https://groups.io/mt/80801576/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5
Posted by Nate DeSimone 3 years, 2 months ago
Thank You Takuto!

For the series... Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: Takuto Naito <naitaku@gmail.com>
> Sent: Sunday, February 21, 2021 7:10 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone,
> Nathaniel L <nathaniel.l.desimone@intel.com>; Luo, Heng
> <heng.luo@intel.com>
> Subject: [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
> TigerlakeOpenBoard: Fix build errors with GCC5
> 
> v2:
> - Split the v1 patch into 2 patches.
>   One is for Platform/Intel/TigerlakeOpenBoardPkg,
>   another one is for edk2-platforms\Silicon\Intel\TigerlakeSiliconPkg.
> 
> https://github.com/naitaku/edk2-
> platforms/tree/tigerlake_fix_build_error_v2
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> 
> Takuto Naito (2):
>   TigerlakeOpenBoardPkg: Fix build errors with GCC5
>   TigerlakeSiliconPkg/IpBlock: Fix build errors with GCC5
> 
>  .../PeiFspPolicyInitLib.inf                   |   2 +-
>  .../BasePlatformHookLib/BasePlatformHookLib.c | 188 ------------------
>  .../DxeSiliconPolicyUpdateLate.c              |   2 +-
>  .../DxePchPcieRpPolicyLib.c                   |   2 +-
>  4 files changed, 3 insertions(+), 191 deletions(-)
> 
> --
> 2.30.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72001): https://edk2.groups.io/g/devel/message/72001
Mute This Topic: https://groups.io/mt/80801576/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5
Posted by Heng Luo 3 years, 2 months ago
Thanks Takuto Naito!

For the series..
Reviewed-by: Heng Luo <heng.luo@intel.com>

> -----Original Message-----
> From: Takuto Naito <naitaku@gmail.com>
> Sent: Sunday, February 21, 2021 11:10 PM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone,
> Nathaniel L <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com>
> Subject: [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
> TigerlakeOpenBoard: Fix build errors with GCC5
> 
> v2:
> - Split the v1 patch into 2 patches.
>   One is for Platform/Intel/TigerlakeOpenBoardPkg,
>   another one is for edk2-platforms\Silicon\Intel\TigerlakeSiliconPkg.
> 
> https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_build_error_v2
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> 
> Takuto Naito (2):
>   TigerlakeOpenBoardPkg: Fix build errors with GCC5
>   TigerlakeSiliconPkg/IpBlock: Fix build errors with GCC5
> 
>  .../PeiFspPolicyInitLib.inf                   |   2 +-
>  .../BasePlatformHookLib/BasePlatformHookLib.c | 188 ------------------
>  .../DxeSiliconPolicyUpdateLate.c              |   2 +-
>  .../DxePchPcieRpPolicyLib.c                   |   2 +-
>  4 files changed, 3 insertions(+), 191 deletions(-)
> 
> --
> 2.30.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71905): https://edk2.groups.io/g/devel/message/71905
Mute This Topic: https://groups.io/mt/80801576/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-