From nobody Sat May 4 05:27:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71894+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71894+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613920229; cv=none; d=zohomail.com; s=zohoarc; b=eOhXTQ4u2iEAS1njGHZr/h+8TVPuuvGiws/oNfLSYOVq9LGkjAdvMT278v+HK2n0cVMtTU6P7DrD+IcjwCDE9ZMmaqNz15c7aIwqg1P1e4Qxb4Ts7gpJCceJiPAdLnRWxVCPCVKqvbr+ky6T7nIDJJFhdKpNZT3TPePhl3WChVI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613920229; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=kmrTeNTJs59mb6z66KDV5kBo6XzCcc5TKgkgSoykPqU=; b=GmqRN7CjVbiypQ2VA1tZ9a2xXqsCFn/2zXmC80VqBYfbYh5iKa5YUq5dmSYmDAp9YsOxjPk2Q9aamNqWEXPM4HXnhTC4A/lARG1XPWADATl/x9eUsOZLhKVQi0f4wOjg6RnGDrnak9D9YwdQUpttHegpaKPtk3dWhx9dJ7Y4/ks= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71894+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1613920229273966.1588913570853; Sun, 21 Feb 2021 07:10:29 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id PoxgYY1788612xMKW8108e7s; Sun, 21 Feb 2021 07:10:28 -0800 X-Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mx.groups.io with SMTP id smtpd.web12.21024.1613920228010698849 for ; Sun, 21 Feb 2021 07:10:28 -0800 X-Received: by mail-pj1-f41.google.com with SMTP id l18so7096136pji.3 for ; Sun, 21 Feb 2021 07:10:27 -0800 (PST) X-Gm-Message-State: jRWuS2HNDnOx0gRVRUvjkccLx1787277AA= X-Google-Smtp-Source: ABdhPJwn5WELYf7b5ldIFjLD9l0BJKcYUQ61BO4iA+xkER7KXl7mlfQMIsgRJgayyyc1mhTC8Z5qSQ== X-Received: by 2002:a17:902:e886:b029:de:57b2:da69 with SMTP id w6-20020a170902e886b02900de57b2da69mr10786334plg.65.1613920227141; Sun, 21 Feb 2021 07:10:27 -0800 (PST) X-Received: from localhost.localdomain ([240d:1e:84:2c00:4c90:1fc7:fcf3:2538]) by smtp.googlemail.com with ESMTPSA id o62sm5073511pga.43.2021.02.21.07.10.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Feb 2021 07:10:26 -0800 (PST) From: "Takuto Naito" To: devel@edk2.groups.io Cc: Sai Chaganty , Nate DeSimone , Heng Luo Subject: [edk2-devel] [PATCH v2 1/2] TigerlakeOpenBoardPkg: Fix build errors with GCC5 Date: Mon, 22 Feb 2021 00:10:19 +0900 Message-Id: <20210221151020.40242-2-naitaku@gmail.com> In-Reply-To: <20210221151020.40242-1-naitaku@gmail.com> References: <20210221151020.40242-1-naitaku@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,naitaku@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1613920228; bh=XyoifHpctwj54o8gX9Zyaagx/0SrBrm6vvuyH74hyus=; h=Cc:Date:From:Reply-To:Subject:To; b=LX3j9JHoAE8NIddO4Gt0+qscMbeBFBqZ4kmaWTzGk0pIzmac0j02X+Y6wElcPyPMMqy o7GNFGHf/98YOWTga/xedgK7RbSbd+dwfNYvcr/Tr7CoSrDzgd2+auO9ViczvngG8vRv8 eFbcYFLY7PAk2mrorQZvW3TcmkRsnb4a/XU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3224 - Fix the path of TigerLakeFspBinPkg - Fix misuse of RETURN_ERROR - Remove unused function CheckNationalSio. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Takuto Naito Reviewed-by: Heng Luo --- Notes: v2: - Split the v1 patch into 2 patches, One is for Platform/Intel/TigerlakeOpenBoardPkg, another one is for edk2-platforms\Silicon\Intel\TigerlakeSiliconPkg. .../PeiFspPolicyInitLib.inf | 2 +- .../BasePlatformHookLib/BasePlatformHookLib.c | 188 ------------------ .../DxeSiliconPolicyUpdateLate.c | 2 +- 3 files changed, 2 insertions(+), 190 deletions(-) diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiFsp= PolicyInitLib/PeiFspPolicyInitLib.inf b/Platform/Intel/TigerlakeOpenBoardPk= g/FspWrapper/Library/PeiFspPolicyInitLib/PeiFspPolicyInitLib.inf index 9d85d855f5..708fbac08f 100644 --- a/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyI= nitLib/PeiFspPolicyInitLib.inf +++ b/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyI= nitLib/PeiFspPolicyInitLib.inf @@ -52,7 +52,7 @@ MdeModulePkg/MdeModulePkg.dec IntelFsp2Pkg/IntelFsp2Pkg.dec TigerlakeSiliconPkg/SiPkg.dec - TigerLakeFspBinPkg/TigerLakeFspBinPkg.dec + TigerLakeFspBinPkg/Client/TigerLakeFspBinPkg.dec TigerlakeOpenBoardPkg/OpenBoardPkg.dec UefiCpuPkg/UefiCpuPkg.dec IntelSiliconPkg/IntelSiliconPkg.dec diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookL= ib/BasePlatformHookLib.c b/Platform/Intel/TigerlakeOpenBoardPkg/Library/Bas= ePlatformHookLib/BasePlatformHookLib.c index 6209e50450..cc5337698b 100644 --- a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/Base= PlatformHookLib.c +++ b/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/Base= PlatformHookLib.c @@ -94,194 +94,6 @@ GLOBAL_REMOVE_IF_UNREFERENCED EFI_SIO_TABLE mSioTableWi= nbond_x374[] =3D { {0x30, 0x01} // Enable it with Activation bit }; =20 -/** - Detect if a National 393 SIO is docked. If yes, enable the docked SIO - and its serial port, and disable the onboard serial port. - - @retval EFI_SUCCESS Operations performed successfully. -**/ -STATIC -VOID -CheckNationalSio ( - VOID - ) -{ - UINT8 Data8; - - // - // Pc87393 access is through either (0x2e, 0x2f) or (0x4e, 0x4f). - // We use (0x2e, 0x2f) which is determined by BADD default strapping - // - - // - // Read the Pc87393 signature - // - IoWrite8 (0x2e, 0x20); - Data8 =3D IoRead8 (0x2f); - - if (Data8 =3D=3D 0xea) { - // - // Signature matches - National PC87393 SIO is docked - // - - // - // Enlarge the LPC decode scope to accommodate the Docking LPC Switch - // Register (SIO_DOCKING_LPC_SWITCH_REGISTER_ADDRESS is allocated at - // SIO_BASE_ADDRESS + 0x10) - // - PchLpcGenIoRangeSet ((FixedPcdGet16 (PcdSioBaseAddress) & (UINT16)~0x7= F), 0x20); - - // - // Enable port switch - // - IoWrite8 (SIO_DOCKING_LPC_SWITCH_REGISTER_ADDRESS, 0x06); - - // - // Turn on docking power - // - IoWrite8 (FixedPcdGet16 (PcdSioBaseAddress) + 0x0E, 0x8c); - - IoWrite8 (FixedPcdGet16 (PcdSioBaseAddress) + 0x0E, 0x9c); - - IoWrite8 (FixedPcdGet16 (PcdSioBaseAddress) + 0x0E, 0xBc); - - // - // Enable port switch - // - IoWrite8 (SIO_DOCKING_LPC_SWITCH_REGISTER_ADDRESS, 0x7); - - // - // GPIO setting - // - IoWrite8 (0x2e, 0x24); - IoWrite8 (0x2f, 0x29); - - // - // Enable chip clock - // - IoWrite8 (0x2e, 0x29); - IoWrite8 (0x2f, 0x1e); - - - // - // Enable serial port - // - - // - // Select com1 - // - IoWrite8 (0x2e, 0x7); - IoWrite8 (0x2f, 0x3); - - // - // Base address: 0x3f8 - // - IoWrite8 (0x2e, 0x60); - IoWrite8 (0x2f, 0x03); - IoWrite8 (0x2e, 0x61); - IoWrite8 (0x2f, 0xf8); - - // - // Interrupt: 4 - // - IoWrite8 (0x2e, 0x70); - IoWrite8 (0x2f, 0x04); - - // - // Enable bank selection - // - IoWrite8 (0x2e, 0xf0); - IoWrite8 (0x2f, 0x82); - - // - // Activate - // - IoWrite8 (0x2e, 0x30); - IoWrite8 (0x2f, 0x01); - - // - // Disable onboard serial port - // - IoWrite8 (FixedPcdGet16 (PcdLpcSioConfigDefaultPort), 0x55); - - // - // Power Down UARTs - // - IoWrite8 (PcdGet16 (PcdLpcSioIndexPort), 0x2); - IoWrite8 (PcdGet16 (PcdLpcSioDataPort), 0x00); - - // - // Dissable COM1 decode - // - IoWrite8 (PcdGet16 (PcdLpcSioIndexPort), 0x24); - IoWrite8 (PcdGet16 (PcdLpcSioDataPort), 0); - - // - // Disable COM2 decode - // - IoWrite8 (PcdGet16 (PcdLpcSioIndexPort), 0x25); - IoWrite8 (PcdGet16 (PcdLpcSioDataPort), 0); - - // - // Disable interrupt - // - IoWrite8 (PcdGet16 (PcdLpcSioIndexPort), 0x28); - IoWrite8 (PcdGet16 (PcdLpcSioDataPort), 0x0); - - IoWrite8 (FixedPcdGet16 (PcdLpcSioConfigDefaultPort), 0xAA); - - // - // Enable floppy - // - - // - // Select floppy - // - IoWrite8 (0x2e, 0x7); - IoWrite8 (0x2f, 0x0); - - // - // Base address: 0x3f0 - // - IoWrite8 (0x2e, 0x60); - IoWrite8 (0x2f, 0x03); - IoWrite8 (0x2e, 0x61); - IoWrite8 (0x2f, 0xf0); - - // - // Interrupt: 6 - // - IoWrite8 (0x2e, 0x70); - IoWrite8 (0x2f, 0x06); - - // - // DMA 2 - // - IoWrite8 (0x2e, 0x74); - IoWrite8 (0x2f, 0x02); - - // - // Activate - // - IoWrite8 (0x2e, 0x30); - IoWrite8 (0x2f, 0x01); - - } else { - - // - // No National pc87393 SIO is docked, turn off dock power and - // disable port switch - // - // IoWrite8 (SIO_BASE_ADDRESS + 0x0E, 0xbf); - // IoWrite8 (0x690, 0); - - // - // If no National pc87393, just return - // - return ; - } -} - /** Check whether the IT8628 SIO present on LPC. If yes, enable its serial por= ts =20 diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/Policy/Library/DxeSilicon= PolicyUpdateLib/DxeSiliconPolicyUpdateLate.c b/Platform/Intel/TigerlakeOpen= BoardPkg/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLat= e.c index 2eee9958be..410a8d1073 100644 --- a/Platform/Intel/TigerlakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyU= pdateLib/DxeSiliconPolicyUpdateLate.c +++ b/Platform/Intel/TigerlakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyU= pdateLib/DxeSiliconPolicyUpdateLate.c @@ -88,8 +88,8 @@ SiliconPolicyUpdateLate ( // GOP Dxe Policy Initialization // Status =3D GopPolicyInitDxe (gImageHandle); - RETURN_ERROR (Status); DEBUG ((DEBUG_INFO, "GOP Dxe Policy Initialization done\n")); + ASSERT_EFI_ERROR (Status); } =20 return Policy; --=20 2.30.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71894): https://edk2.groups.io/g/devel/message/71894 Mute This Topic: https://groups.io/mt/80801577/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 05:27:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+71895+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71895+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613920236; cv=none; d=zohomail.com; s=zohoarc; b=mJkYX0fUfPjEajwhqD+OdXorqlAJlOtcfMFW1ImWItVrvI6U4hImcw9SJjbwJSeT7UaZwDz9lgmOT04+uQryORf8GhQKhtDSqm6IMDkj5YTaRVdeGD07ZOtZEEA9xJDIQcVEN7VKHg0JzRUgVgo+EoIc9vvpdybZyybLSOcE8BA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613920236; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=aaMi7ZhVVJBwYeAXZetYVAKGtG/XBb8v4l7rM+dBKbA=; b=mGN0tz90jV7nwzbvyBS58AWlN0WzSa2OoXYcuIfoXM2j1DjUrqgnKCYLb3FawNgC/U02yFz+C75OnltoWIxfHWz40e51XGGvtcqEObBCqvTy5Hb4mwg9PkT7sPc+CNEpLqg4WLDXOHiie76mYyCZKlLnVD0509nPST6zc+3eK2M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+71895+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16139202364857.520229640971706; Sun, 21 Feb 2021 07:10:36 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id DRepYY1788612xPbUKoXtOAr; Sun, 21 Feb 2021 07:10:36 -0800 X-Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mx.groups.io with SMTP id smtpd.web09.21268.1613920230297626615 for ; Sun, 21 Feb 2021 07:10:30 -0800 X-Received: by mail-pf1-f170.google.com with SMTP id q20so4988490pfu.8 for ; Sun, 21 Feb 2021 07:10:30 -0800 (PST) X-Gm-Message-State: ApJyYLvpi4N6SBEqSMPw2Y0Hx1787277AA= X-Google-Smtp-Source: ABdhPJyAdKbihLAEwq3+ssRiJhYz8icYIrtgBU8GwppQQjlwzdxDYA0Zx+ytqpy5xOz/K2Hr2TgjpQ== X-Received: by 2002:a63:27c5:: with SMTP id n188mr16445020pgn.193.1613920229187; Sun, 21 Feb 2021 07:10:29 -0800 (PST) X-Received: from localhost.localdomain ([240d:1e:84:2c00:4c90:1fc7:fcf3:2538]) by smtp.googlemail.com with ESMTPSA id o62sm5073511pga.43.2021.02.21.07.10.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Feb 2021 07:10:28 -0800 (PST) From: "Takuto Naito" To: devel@edk2.groups.io Cc: Sai Chaganty , Nate DeSimone , Heng Luo Subject: [edk2-devel] [PATCH v2 2/2] TigerlakeSiliconPkg/IpBlock: Fix build errors with GCC5 Date: Mon, 22 Feb 2021 00:10:20 +0900 Message-Id: <20210221151020.40242-3-naitaku@gmail.com> In-Reply-To: <20210221151020.40242-1-naitaku@gmail.com> References: <20210221151020.40242-1-naitaku@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,naitaku@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1613920236; bh=pLZhOh2jRFeXxA8pnC4aYUN4Cd401acFgTRl+vgHH2w=; h=Cc:Date:From:Reply-To:Subject:To; b=mvok8Dt60gfjJiiLMv1Hs+46LBUXtEUshOPYHsqyuEpvLcHtKN73D2XODiq/3oS2YMu uNf7BUv1yZ7FSeC1xEDkIytzS+3iSSgnpHn21afB6wwB/9HrByUm2LWKgwFadM6JGksAk 7V5Avr2Cn0cNAOusIu5fjS9pRYbOcapPsOs= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3224 - Fix the Teton Glacier Endpoint entry in mPciDeviceTable Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Takuto Naito Reviewed-by: Heng Luo --- Notes: v2: - Split the v1 patch into 2 patches, One is for Platform/Intel/TigerlakeOpenBoardPkg, another one is for edk2-platforms\Silicon\Intel\TigerlakeSiliconPkg. .../DxePchPcieRpPolicyLib/DxePchPcieRpPolicyLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivat= e/DxePchPcieRpPolicyLib/DxePchPcieRpPolicyLib.c b/Silicon/Intel/TigerlakeSi= liconPkg/IpBlock/PcieRp/LibraryPrivate/DxePchPcieRpPolicyLib/DxePchPcieRpPo= licyLib.c index 577e436e32..1553d2e2aa 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/DxePc= hPcieRpPolicyLib/DxePchPcieRpPolicyLib.c +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/DxePc= hPcieRpPolicyLib/DxePchPcieRpPolicyLib.c @@ -98,7 +98,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED PCH_PCIE_DEVICE_OVERRIDE mP= cieDeviceTable[] =3D { // // Teton Glacier Endpoint // - { 0x8086, 0x0975, 0xff, 0, 0, 0, PchPcieL1SubstatesOverride, 0, 0xff, 0x= 3C, 0, 5, 0, 0, 0, 0 }, + { 0x8086, 0x0975, 0xff, 0, 0, 0, PchPcieL1SubstatesOverride, 0, 0xff, 0x= 3C, 0, 5, 0, 0 }, =20 // // End of Table --=20 2.30.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71895): https://edk2.groups.io/g/devel/message/71895 Mute This Topic: https://groups.io/mt/80801580/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-