[edk2-devel] [edk2-platforms PATCH v3 0/3] Platform/Qemu/SbsaQemu: Add SMBIOS tables

Rebecca Cran posted 3 patches 3 years, 9 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c                    | 242 ++++++++++++++++++++
Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf                  |  53 +++++
Platform/Qemu/SbsaQemu/SbsaQemu.dsc                               |  50 +++-
Platform/Qemu/SbsaQemu/SbsaQemu.fdf                               |   7 +
Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c   |  50 +---
Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf |   1 +
Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h              |  24 ++
Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c         |  69 ++++++
Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf       |  28 +++
Silicon/Qemu/SbsaQemu/SbsaQemu.dec                                |  18 ++
10 files changed, 492 insertions(+), 50 deletions(-)
create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c
create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf
create mode 100644 Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h
create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c
create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf
[edk2-devel] [edk2-platforms PATCH v3 0/3] Platform/Qemu/SbsaQemu: Add SMBIOS tables
Posted by Rebecca Cran 3 years, 9 months ago
o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios.
o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support
  for SMBIOS 3.4.0, as is required by SBBR.
o Add an implementation of OemMiscLib that provides the system
  information. The serial numbers, asset tags etc. are currently all
  fixed strings, to allow fwts to pass without errors.
o Add SMBIOS PCDs to identify the platform. The processor serial
  number, asset tag and part number are populated because otherwise
  fwts reports errors.

Changes between v1 and v2:

o Renamed OemMiscLib 'socket' functions to 'processor'.
o Added PCDs for the various strings (SN, SKU etc.).
o Added FdtHelperLib.
o Updated SBSA ACPI Dxe to use FdtHelperLib.
o Changed SBSA SMBIOS Processor information to create multiple CPUs,
  instead of a single multi-core CPU.
o Updated cache level to be 1-based.
o Fixed/moved/added EFIAPI specifiers.

Changes between v2 and v3:

o Fixed ordering of FdtHelperLib and FdtLib in
  Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf
o Fixed the subject line of the series to include the word "PATCH"
  (i.e. [edk2-platforms PATCH v3 0/3]).

This series requires associated changes to the edk2 repo, so will
need some coordination to reduce the amount of time the build is
broken.


Rebecca Cran (3):
  SbsaQemu: Add FdtHelperLib
  SbsaQemu: Update SbsaQemuAcpiDxe to use FdtHelperLib
  Platform/Qemu/SbsaQemu: Add SMBIOS tables

 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c                    | 242 ++++++++++++++++++++
 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf                  |  53 +++++
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc                               |  50 +++-
 Platform/Qemu/SbsaQemu/SbsaQemu.fdf                               |   7 +
 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c   |  50 +---
 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf |   1 +
 Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h              |  24 ++
 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c         |  69 ++++++
 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf       |  28 +++
 Silicon/Qemu/SbsaQemu/SbsaQemu.dec                                |  18 ++
 10 files changed, 492 insertions(+), 50 deletions(-)
 create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c
 create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf
 create mode 100644 Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h
 create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c
 create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf

-- 
2.26.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71803): https://edk2.groups.io/g/devel/message/71803
Mute This Topic: https://groups.io/mt/80748479/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms PATCH v3 0/3] Platform/Qemu/SbsaQemu: Add SMBIOS tables
Posted by Rebecca Cran 3 years, 9 months ago
On 2/18/21 8:57 PM, Rebecca Cran wrote:

> Changes between v1 and v2:
> 
> o Renamed OemMiscLib 'socket' functions to 'processor'.
> o Added PCDs for the various strings (SN, SKU etc.).
> o Added FdtHelperLib.
> o Updated SBSA ACPI Dxe to use FdtHelperLib.
> o Changed SBSA SMBIOS Processor information to create multiple CPUs,
>    instead of a single multi-core CPU.
> o Updated cache level to be 1-based.
> o Fixed/moved/added EFIAPI specifiers.

I also changed the OemGetChassisType function so it returns 
MISC_CHASSIS_TYPE instead of EFI_STATUS, which matches with the other 
functions in OemMiscLib.

-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71807): https://edk2.groups.io/g/devel/message/71807
Mute This Topic: https://groups.io/mt/80748479/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-