[edk2-devel] [edk2-platforms PATCH v5 0/4] Platform/Qemu/SbsaQemu: Add SMBIOS tables

Rebecca Cran posted 4 patches 3 years, 1 month ago
Failed in applying to current master (apply log)
Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c                    | 242 ++++++++++++++++++++
Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf                  |  53 +++++
Platform/Qemu/SbsaQemu/SbsaQemu.dsc                               |  50 +++-
Platform/Qemu/SbsaQemu/SbsaQemu.fdf                               |   7 +
Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c   |  62 +----
Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf |   1 +
Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h              |  24 ++
Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c         |  62 +++++
Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf       |  28 +++
Silicon/Qemu/SbsaQemu/SbsaQemu.dec                                |  18 ++
10 files changed, 493 insertions(+), 54 deletions(-)
create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c
create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf
create mode 100644 Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h
create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c
create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf
[edk2-devel] [edk2-platforms PATCH v5 0/4] Platform/Qemu/SbsaQemu: Add SMBIOS tables
Posted by Rebecca Cran 3 years, 1 month ago
o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios.
o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support
  for SMBIOS 3.4.0, as is required by SBBR.
o Add an implementation of OemMiscLib that provides the system
  information. The serial numbers, asset tags etc. are currently all
  fixed strings, to allow fwts to pass without errors.
o Add SMBIOS PCDs to identify the platform. The processor serial
  number, asset tag and part number are populated because otherwise
  fwts reports errors.

Changes between v4 and v5

o Moved calling FdtHelperCountCpus in SbsaQemuAcpiDxe from 1/4 into 2/4.


Rebecca Cran (4):
  SbsaQemu: Add FdtHelperLib
  SbsaQemu: Update SbsaQemuAcpiDxe to use FdtHelperLib
  Platform/Qemu/SbsaQemu: Add SMBIOS tables
  Silicon/Qemu: Don't re-use NumCores as loop index in AddMadtTable

 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c                    | 242 ++++++++++++++++++++
 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf                  |  53 +++++
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc                               |  50 +++-
 Platform/Qemu/SbsaQemu/SbsaQemu.fdf                               |   7 +
 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c   |  62 +----
 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf |   1 +
 Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h              |  24 ++
 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c         |  62 +++++
 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf       |  28 +++
 Silicon/Qemu/SbsaQemu/SbsaQemu.dec                                |  18 ++
 10 files changed, 493 insertions(+), 54 deletions(-)
 create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c
 create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf
 create mode 100644 Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h
 create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c
 create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf

-- 
2.26.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72101): https://edk2.groups.io/g/devel/message/72101
Mute This Topic: https://groups.io/mt/80857020/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms PATCH v5 0/4] Platform/Qemu/SbsaQemu: Add SMBIOS tables
Posted by Leif Lindholm 3 years, 1 month ago
On Tue, Feb 23, 2021 at 10:43:38 -0700, Rebecca Cran wrote:
> o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios.
> o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support
>   for SMBIOS 3.4.0, as is required by SBBR.
> o Add an implementation of OemMiscLib that provides the system
>   information. The serial numbers, asset tags etc. are currently all
>   fixed strings, to allow fwts to pass without errors.
> o Add SMBIOS PCDs to identify the platform. The processor serial
>   number, asset tag and part number are populated because otherwise
>   fwts reports errors.
> 
> Changes between v4 and v5
> 
> o Moved calling FdtHelperCountCpus in SbsaQemuAcpiDxe from 1/4 into 2/4.

For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 9fb5174e0a16..71d92a044db0.

(I did trim a couple of trailing blank lines at end of file in 3/4
before pushing.)

> 
> Rebecca Cran (4):
>   SbsaQemu: Add FdtHelperLib
>   SbsaQemu: Update SbsaQemuAcpiDxe to use FdtHelperLib
>   Platform/Qemu/SbsaQemu: Add SMBIOS tables
>   Silicon/Qemu: Don't re-use NumCores as loop index in AddMadtTable
> 
>  Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c                    | 242 ++++++++++++++++++++
>  Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf                  |  53 +++++
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc                               |  50 +++-
>  Platform/Qemu/SbsaQemu/SbsaQemu.fdf                               |   7 +
>  Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c   |  62 +----
>  Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf |   1 +
>  Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h              |  24 ++
>  Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c         |  62 +++++
>  Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf       |  28 +++
>  Silicon/Qemu/SbsaQemu/SbsaQemu.dec                                |  18 ++
>  10 files changed, 493 insertions(+), 54 deletions(-)
>  create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c
>  create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf
>  create mode 100644 Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h
>  create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c
>  create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf
> 
> -- 
> 2.26.2
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72111): https://edk2.groups.io/g/devel/message/72111
Mute This Topic: https://groups.io/mt/80857020/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-