[edk2-devel] [PATCH v2 00/26] Enable Core CI support for StandaloneMmPkg

Sami Mujawar posted 26 patches 3 years, 4 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
.azurepipelines/templates/pr-gate-build-job.yml                                                     |  2 +-
.pytool/CISettings.py                                                                               |  1 +
.pytool/Readme.md                                                                                   |  2 +-
StandaloneMmPkg/Core/Dependency.c                                                                   |  6 +-
StandaloneMmPkg/Core/Dispatcher.c                                                                   | 49 ++++++------
StandaloneMmPkg/Core/FwVol.c                                                                        | 36 +++++----
StandaloneMmPkg/Core/Locate.c                                                                       |  6 +-
StandaloneMmPkg/Core/Mmi.c                                                                          |  4 +-
StandaloneMmPkg/Core/Pool.c                                                                         |  6 +-
StandaloneMmPkg/Core/StandaloneMmCore.c                                                             | 37 ++++++---
StandaloneMmPkg/Core/StandaloneMmCore.h                                                             | 12 +--
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c                                       | 56 ++++++++++---
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c                                   | 34 ++++++--
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h                                   | 31 +++++++-
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf                                 |  9 +--
StandaloneMmPkg/Include/Guid/MmCoreData.h                                                           |  6 +-
StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h                                | 47 ++++++-----
StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h                                      |  4 +-
StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h                                                |  6 +-
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c                          |  6 +-
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c                         | 53 +++++++++++-
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c             | 32 +++++---
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf                   |  3 +-
StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c   |  6 +-
StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf |  4 +-
StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c                                     | 10 +--
StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.c                                 |  4 +-
StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf                               |  4 +-
StandaloneMmPkg/StandaloneMmPkg.ci.yaml                                                             | 84 ++++++++++++++++++++
StandaloneMmPkg/StandaloneMmPkg.dec                                                                 | 20 ++++-
StandaloneMmPkg/StandaloneMmPkg.dsc                                                                 | 15 +++-
31 files changed, 439 insertions(+), 156 deletions(-)
create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml
[edk2-devel] [PATCH v2 00/26] Enable Core CI support for StandaloneMmPkg
Posted by Sami Mujawar 3 years, 4 months ago
The EDKII Core CI runs the ECC tool that checks for good coding
practices and the coding standard. This patch series fixes the
ECC errors reported in the StandaloneMmPkg and enables support
for EDKII Core CI.

This v2 series:
 - addresses the feedback for the following patches:
   PATCH 24: StandaloneMmPkg: Add EDK2 Core CI support
      Ref: https://edk2.groups.io/g/devel/topic/78838418
   PATCH 25:. .azurepipelines: Add StandaloneMmPkg to CI matrix
      Ref: https://edk2.groups.io/g/devel/message/68603
 - Introduces a new PATCH 23:
     'StandaloneMmPkg: Remove dependency on ArmPlatformPkg.dec'
 - There is no code change for Patches 1 to 22 and 26 since the
   v1 series.

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/1516_standalonemmpkg_ci_v2

Sami Mujawar (26):
  StandaloneMmPkg: Add library header files to DEC
  StandaloneMmPkg: Add library files to DSC
  StandaloneMmPkg: Fix spell check reported errors
  StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher
  StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management
  StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 4002 in FwVol helper
  StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore
  StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore
  StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib
  StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Fix ECC error 9003 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 9001 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core
  StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib
  StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Remove dependency on ArmPlatformPkg.dec
  StandaloneMmPkg: Add EDK2 Core CI support
  .azurepipelines: Add StandaloneMmPkg to CI matrix
  .pytool: CI Settings to support StandaloneMmPkg

 .azurepipelines/templates/pr-gate-build-job.yml                                                     |  2 +-
 .pytool/CISettings.py                                                                               |  1 +
 .pytool/Readme.md                                                                                   |  2 +-
 StandaloneMmPkg/Core/Dependency.c                                                                   |  6 +-
 StandaloneMmPkg/Core/Dispatcher.c                                                                   | 49 ++++++------
 StandaloneMmPkg/Core/FwVol.c                                                                        | 36 +++++----
 StandaloneMmPkg/Core/Locate.c                                                                       |  6 +-
 StandaloneMmPkg/Core/Mmi.c                                                                          |  4 +-
 StandaloneMmPkg/Core/Pool.c                                                                         |  6 +-
 StandaloneMmPkg/Core/StandaloneMmCore.c                                                             | 37 ++++++---
 StandaloneMmPkg/Core/StandaloneMmCore.h                                                             | 12 +--
 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c                                       | 56 ++++++++++---
 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c                                   | 34 ++++++--
 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h                                   | 31 +++++++-
 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf                                 |  9 +--
 StandaloneMmPkg/Include/Guid/MmCoreData.h                                                           |  6 +-
 StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h                                | 47 ++++++-----
 StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h                                      |  4 +-
 StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h                                                |  6 +-
 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c                          |  6 +-
 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c                         | 53 +++++++++++-
 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c             | 32 +++++---
 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf                   |  3 +-
 StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c   |  6 +-
 StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf |  4 +-
 StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c                                     | 10 +--
 StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.c                                 |  4 +-
 StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf                               |  4 +-
 StandaloneMmPkg/StandaloneMmPkg.ci.yaml                                                             | 84 ++++++++++++++++++++
 StandaloneMmPkg/StandaloneMmPkg.dec                                                                 | 20 ++++-
 StandaloneMmPkg/StandaloneMmPkg.dsc                                                                 | 15 +++-
 31 files changed, 439 insertions(+), 156 deletions(-)
 create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69106): https://edk2.groups.io/g/devel/message/69106
Mute This Topic: https://groups.io/mt/79035549/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


回复: [edk2-devel] [PATCH v2 00/26] Enable Core CI support for StandaloneMmPkg
Posted by gaoliming 3 years, 4 months ago
Sami:
  Is there BZ for this feature? If no, please submit it to catch it. 

  CI runs in Windows and Linux both. So, readme.md needs to list the check
in Windows column. 

| StandaloneMmPkg      |                    | :heavy_check_mark: |
==>
| StandaloneMmPkg      | :heavy_check_mark: | :heavy_check_mark: |

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+69106+4905953+8761045@groups.io
> <bounce+27952+69106+4905953+8761045@groups.io> 代表 Sami
> Mujawar
> 发送时间: 2020年12月17日 21:05
> 收件人: devel@edk2.groups.io
> 抄送: Sami Mujawar <sami.mujawar@arm.com>; ard.biesheuvel@arm.com;
> jiewen.yao@intel.com; thomas.abraham@arm.com;
> Sughosh.Ganu@arm.com; Matteo.Carlini@arm.com;
> Ben.Adderson@arm.com; nd@arm.com
> 主题: [edk2-devel] [PATCH v2 00/26] Enable Core CI support for
> StandaloneMmPkg
> 
> The EDKII Core CI runs the ECC tool that checks for good coding
> practices and the coding standard. This patch series fixes the
> ECC errors reported in the StandaloneMmPkg and enables support
> for EDKII Core CI.
> 
> This v2 series:
>  - addresses the feedback for the following patches:
>    PATCH 24: StandaloneMmPkg: Add EDK2 Core CI support
>       Ref: https://edk2.groups.io/g/devel/topic/78838418
>    PATCH 25:. .azurepipelines: Add StandaloneMmPkg to CI matrix
>       Ref: https://edk2.groups.io/g/devel/message/68603
>  - Introduces a new PATCH 23:
>      'StandaloneMmPkg: Remove dependency on ArmPlatformPkg.dec'
>  - There is no code change for Patches 1 to 22 and 26 since the
>    v1 series.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/1516_standalonemmpkg_ci_v2
> 
> Sami Mujawar (26):
>   StandaloneMmPkg: Add library header files to DEC
>   StandaloneMmPkg: Add library files to DSC
>   StandaloneMmPkg: Fix spell check reported errors
>   StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher
>   StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management
>   StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 4002 in FwVol helper
>   StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore
>   StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore
>   StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib
>   StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 9003 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 9001 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core
>   StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib
>   StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Remove dependency on ArmPlatformPkg.dec
>   StandaloneMmPkg: Add EDK2 Core CI support
>   .azurepipelines: Add StandaloneMmPkg to CI matrix
>   .pytool: CI Settings to support StandaloneMmPkg
> 
>  .azurepipelines/templates/pr-gate-build-job.yml
> |  2 +-
>  .pytool/CISettings.py
> |  1 +
>  .pytool/Readme.md
> |  2 +-
>  StandaloneMmPkg/Core/Dependency.c
> |  6 +-
>  StandaloneMmPkg/Core/Dispatcher.c
> | 49 ++++++------
>  StandaloneMmPkg/Core/FwVol.c
> | 36 +++++----
>  StandaloneMmPkg/Core/Locate.c
> |  6 +-
>  StandaloneMmPkg/Core/Mmi.c
> |  4 +-
>  StandaloneMmPkg/Core/Pool.c
> |  6 +-
>  StandaloneMmPkg/Core/StandaloneMmCore.c
> | 37 ++++++---
>  StandaloneMmPkg/Core/StandaloneMmCore.h
> | 12 +--
>  StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
> | 56 ++++++++++---
> 
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.
> c                                   | 34 ++++++--
> 
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.
> h                                   | 31 +++++++-
> 
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i
> nf                                 |  9 +--
>  StandaloneMmPkg/Include/Guid/MmCoreData.h
> |  6 +-
> 
> StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h
> | 47 ++++++-----
>  StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
> |  4 +-
>  StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h
> |  6 +-
> 
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHo
> bList.c                          |  6 +-
> 
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermi
> ssions.c                         | 53 +++++++++++-
> 
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/Standalo
> neMmCoreEntryPoint.c             | 32 +++++---
> 
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCor
> eEntryPoint.inf                   |  3 +-
> 
> StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Standal
> oneMmCoreMemoryAllocationLib.c   |  6 +-
> 
> StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Standal
> oneMmCoreMemoryAllocationLib.inf |  4 +-
> 
> StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c
> | 10 +--
> 
> StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependenc
> y.c                                 |  4 +-
> 
> StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependenc
> y.inf                               |  4 +-
>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml
> | 84 ++++++++++++++++++++
>  StandaloneMmPkg/StandaloneMmPkg.dec
> | 20 ++++-
>  StandaloneMmPkg/StandaloneMmPkg.dsc
> | 15 +++-
>  31 files changed, 439 insertions(+), 156 deletions(-)
>  create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69438): https://edk2.groups.io/g/devel/message/69438
Mute This Topic: https://groups.io/mt/79194663/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] 回复: [edk2-devel] [PATCH v2 00/26] Enable Core CI support for StandaloneMmPkg
Posted by Sami Mujawar 3 years, 3 months ago
Hi Liming,

I have created Bugzilla: 3150 (https://bugzilla.tianocore.org/show_bug.cgi?id=3150)
and would be submitting a v3 series with the fix you have suggested.

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69554): https://edk2.groups.io/g/devel/message/69554
Mute This Topic: https://groups.io/mt/79194663/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-