[edk2-devel] [PATCH v3 00/26] Enable Core CI support for StandaloneMmPkg

Sami Mujawar posted 26 patches 4 months ago
Failed in applying to current master (apply log)
.azurepipelines/templates/pr-gate-build-job.yml                                                     |  2 +-
.pytool/CISettings.py                                                                               |  1 +
.pytool/Readme.md                                                                                   |  2 +-
StandaloneMmPkg/Core/Dependency.c                                                                   |  6 +-
StandaloneMmPkg/Core/Dispatcher.c                                                                   | 49 ++++++------
StandaloneMmPkg/Core/FwVol.c                                                                        | 36 +++++----
StandaloneMmPkg/Core/Locate.c                                                                       |  6 +-
StandaloneMmPkg/Core/Mmi.c                                                                          |  4 +-
StandaloneMmPkg/Core/Pool.c                                                                         |  6 +-
StandaloneMmPkg/Core/StandaloneMmCore.c                                                             | 37 ++++++---
StandaloneMmPkg/Core/StandaloneMmCore.h                                                             | 12 +--
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c                                       | 56 ++++++++++---
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c                                   | 34 ++++++--
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h                                   | 31 +++++++-
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf                                 |  9 +--
StandaloneMmPkg/Include/Guid/MmCoreData.h                                                           |  6 +-
StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h                                | 47 ++++++-----
StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h                                      |  4 +-
StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h                                                |  6 +-
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c                          |  6 +-
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c                         | 53 +++++++++++-
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c             | 32 +++++---
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf                   |  3 +-
StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c   |  6 +-
StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf |  4 +-
StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c                                     | 10 +--
StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.c                                 |  4 +-
StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf                               |  4 +-
StandaloneMmPkg/StandaloneMmPkg.ci.yaml                                                             | 84 ++++++++++++++++++++
StandaloneMmPkg/StandaloneMmPkg.dec                                                                 | 20 ++++-
StandaloneMmPkg/StandaloneMmPkg.dsc                                                                 | 15 +++-
31 files changed, 439 insertions(+), 156 deletions(-)
create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml

[edk2-devel] [PATCH v3 00/26] Enable Core CI support for StandaloneMmPkg

Posted by Sami Mujawar 4 months ago
Bugzilla: 3150 (https://bugzilla.tianocore.org/show_bug.cgi?id=3150)

The EDKII Core CI runs the ECC tool that checks for good coding
practices and the coding standard. This patch series fixes the
ECC errors reported in the StandaloneMmPkg and enables support
for EDKII Core CI.

This v3 series:
 - PATCH 26: Updated readme.md file to add check mark to the
   windows column.
 - Added bugzilla ID to the commit messages for the patches in
   the series.
   Ref: https://edk2.groups.io/g/devel/topic/edk2_devel_patch/79194663
 - There is no code change for Patches 1 to 25 since the v2 series.

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/1516_standalonemmpkg_ci_v3

Sami Mujawar (26):
  StandaloneMmPkg: Add library header files to DEC
  StandaloneMmPkg: Add library files to DSC
  StandaloneMmPkg: Fix spell check reported errors
  StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher
  StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management
  StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 4002 in FwVol helper
  StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore
  StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore
  StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib
  StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Fix ECC error 9003 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 9001 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core
  StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib
  StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Remove dependency on ArmPlatformPkg.dec
  StandaloneMmPkg: Add EDK2 Core CI support
  .azurepipelines: Add StandaloneMmPkg to CI matrix
  .pytool: CI Settings to support StandaloneMmPkg

 .azurepipelines/templates/pr-gate-build-job.yml                                                     |  2 +-
 .pytool/CISettings.py                                                                               |  1 +
 .pytool/Readme.md                                                                                   |  2 +-
 StandaloneMmPkg/Core/Dependency.c                                                                   |  6 +-
 StandaloneMmPkg/Core/Dispatcher.c                                                                   | 49 ++++++------
 StandaloneMmPkg/Core/FwVol.c                                                                        | 36 +++++----
 StandaloneMmPkg/Core/Locate.c                                                                       |  6 +-
 StandaloneMmPkg/Core/Mmi.c                                                                          |  4 +-
 StandaloneMmPkg/Core/Pool.c                                                                         |  6 +-
 StandaloneMmPkg/Core/StandaloneMmCore.c                                                             | 37 ++++++---
 StandaloneMmPkg/Core/StandaloneMmCore.h                                                             | 12 +--
 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c                                       | 56 ++++++++++---
 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c                                   | 34 ++++++--
 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h                                   | 31 +++++++-
 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf                                 |  9 +--
 StandaloneMmPkg/Include/Guid/MmCoreData.h                                                           |  6 +-
 StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h                                | 47 ++++++-----
 StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h                                      |  4 +-
 StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h                                                |  6 +-
 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c                          |  6 +-
 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c                         | 53 +++++++++++-
 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c             | 32 +++++---
 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf                   |  3 +-
 StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c   |  6 +-
 StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf |  4 +-
 StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c                                     | 10 +--
 StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.c                                 |  4 +-
 StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf                               |  4 +-
 StandaloneMmPkg/StandaloneMmPkg.ci.yaml                                                             | 84 ++++++++++++++++++++
 StandaloneMmPkg/StandaloneMmPkg.dec                                                                 | 20 ++++-
 StandaloneMmPkg/StandaloneMmPkg.dsc                                                                 | 15 +++-
 31 files changed, 439 insertions(+), 156 deletions(-)
 create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69555): https://edk2.groups.io/g/devel/message/69555
Mute This Topic: https://groups.io/mt/79423256/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v3 00/26] Enable Core CI support for StandaloneMmPkg

Posted by Ard Biesheuvel 4 months ago
On 1/4/21 2:21 PM, Sami Mujawar wrote:
> Bugzilla: 3150 (https://bugzilla.tianocore.org/show_bug.cgi?id=3150)
> 
> The EDKII Core CI runs the ECC tool that checks for good coding
> practices and the coding standard. This patch series fixes the
> ECC errors reported in the StandaloneMmPkg and enables support
> for EDKII Core CI.
> 
> This v3 series:
>  - PATCH 26: Updated readme.md file to add check mark to the
>    windows column.
>  - Added bugzilla ID to the commit messages for the patches in
>    the series.
>    Ref: https://edk2.groups.io/g/devel/topic/edk2_devel_patch/79194663
>  - There is no code change for Patches 1 to 25 since the v2 series.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/1516_standalonemmpkg_ci_v3
> 
> Sami Mujawar (26):
>   StandaloneMmPkg: Add library header files to DEC
>   StandaloneMmPkg: Add library files to DSC
>   StandaloneMmPkg: Fix spell check reported errors
>   StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher
>   StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management
>   StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 4002 in FwVol helper
>   StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore
>   StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore
>   StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib
>   StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 9003 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 9001 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core
>   StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib
>   StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Remove dependency on ArmPlatformPkg.dec
>   StandaloneMmPkg: Add EDK2 Core CI support
>   .azurepipelines: Add StandaloneMmPkg to CI matrix
>   .pytool: CI Settings to support StandaloneMmPkg
> 

This all looks fine to me.

Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

but you might want to update the copyright years to 2021 instead of 2020
before pushing.


>  .azurepipelines/templates/pr-gate-build-job.yml                                                     |  2 +-
>  .pytool/CISettings.py                                                                               |  1 +
>  .pytool/Readme.md                                                                                   |  2 +-
>  StandaloneMmPkg/Core/Dependency.c                                                                   |  6 +-
>  StandaloneMmPkg/Core/Dispatcher.c                                                                   | 49 ++++++------
>  StandaloneMmPkg/Core/FwVol.c                                                                        | 36 +++++----
>  StandaloneMmPkg/Core/Locate.c                                                                       |  6 +-
>  StandaloneMmPkg/Core/Mmi.c                                                                          |  4 +-
>  StandaloneMmPkg/Core/Pool.c                                                                         |  6 +-
>  StandaloneMmPkg/Core/StandaloneMmCore.c                                                             | 37 ++++++---
>  StandaloneMmPkg/Core/StandaloneMmCore.h                                                             | 12 +--
>  StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c                                       | 56 ++++++++++---
>  StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c                                   | 34 ++++++--
>  StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h                                   | 31 +++++++-
>  StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf                                 |  9 +--
>  StandaloneMmPkg/Include/Guid/MmCoreData.h                                                           |  6 +-
>  StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h                                | 47 ++++++-----
>  StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h                                      |  4 +-
>  StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h                                                |  6 +-
>  StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c                          |  6 +-
>  StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c                         | 53 +++++++++++-
>  StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c             | 32 +++++---
>  StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf                   |  3 +-
>  StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c   |  6 +-
>  StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf |  4 +-
>  StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c                                     | 10 +--
>  StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.c                                 |  4 +-
>  StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf                               |  4 +-
>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml                                                             | 84 ++++++++++++++++++++
>  StandaloneMmPkg/StandaloneMmPkg.dec                                                                 | 20 ++++-
>  StandaloneMmPkg/StandaloneMmPkg.dsc                                                                 | 15 +++-
>  31 files changed, 439 insertions(+), 156 deletions(-)
>  create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69823): https://edk2.groups.io/g/devel/message/69823
Mute This Topic: https://groups.io/mt/79423256/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-