[edk2-devel] [PATCH v1 00/25] Enable Core CI support for StandaloneMmPkg

Sami Mujawar posted 25 patches 3 years, 4 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
.azurepipelines/templates/pr-gate-build-job.yml                                                     |  2 +-
.pytool/CISettings.py                                                                               |  1 +
.pytool/Readme.md                                                                                   |  2 +-
StandaloneMmPkg/Core/Dependency.c                                                                   |  6 +-
StandaloneMmPkg/Core/Dispatcher.c                                                                   | 49 ++++++-----
StandaloneMmPkg/Core/FwVol.c                                                                        | 36 +++++----
StandaloneMmPkg/Core/Locate.c                                                                       |  6 +-
StandaloneMmPkg/Core/Mmi.c                                                                          |  4 +-
StandaloneMmPkg/Core/Pool.c                                                                         |  6 +-
StandaloneMmPkg/Core/StandaloneMmCore.c                                                             | 37 ++++++---
StandaloneMmPkg/Core/StandaloneMmCore.h                                                             | 12 +--
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c                                       | 56 ++++++++++---
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c                                   | 34 ++++++--
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h                                   | 31 ++++++-
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf                                 |  9 +--
StandaloneMmPkg/Include/Guid/MmCoreData.h                                                           |  6 +-
StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h                                | 47 ++++++-----
StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h                                      |  4 +-
StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h                                                |  6 +-
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c                          |  6 +-
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c                         | 53 +++++++++++-
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c             | 32 +++++---
StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c   |  6 +-
StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf |  4 +-
StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c                                     | 10 +--
StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.c                                 |  4 +-
StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf                               |  4 +-
StandaloneMmPkg/StandaloneMmPkg.ci.yaml                                                             | 85 ++++++++++++++++++++
StandaloneMmPkg/StandaloneMmPkg.dec                                                                 | 20 ++++-
StandaloneMmPkg/StandaloneMmPkg.dsc                                                                 | 15 +++-
30 files changed, 439 insertions(+), 154 deletions(-)
create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml
[edk2-devel] [PATCH v1 00/25] Enable Core CI support for StandaloneMmPkg
Posted by Sami Mujawar 3 years, 4 months ago
The EDKII Core CI runs the ECC tool that checks for good coding
practices and the coding standard. This patch series fixes the
ECC errors reported in the StandaloneMmPkg and enables support
for EDKII Core CI.

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/1516_standalonemmpkg_ci_v1

Sami Mujawar (25):
  StandaloneMmPkg: Add library header files to DEC
  StandaloneMmPkg: Add library files to DSC
  StandaloneMmPkg: Fix spell check reported errors
  StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher
  StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management
  StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 4002 in FwVol helper
  StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore
  StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore
  StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib
  StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Fix ECC error 9003 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 9001 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core
  StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib
  StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
  StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint
  StandaloneMmPkg: Add EDK2 Core CI support
  .azurepipelines: Add StandaloneMmPkg to CI matrix
  .pytool: CI Settings to support StandaloneMmPkg

 .azurepipelines/templates/pr-gate-build-job.yml                                                     |  2 +-
 .pytool/CISettings.py                                                                               |  1 +
 .pytool/Readme.md                                                                                   |  2 +-
 StandaloneMmPkg/Core/Dependency.c                                                                   |  6 +-
 StandaloneMmPkg/Core/Dispatcher.c                                                                   | 49 ++++++-----
 StandaloneMmPkg/Core/FwVol.c                                                                        | 36 +++++----
 StandaloneMmPkg/Core/Locate.c                                                                       |  6 +-
 StandaloneMmPkg/Core/Mmi.c                                                                          |  4 +-
 StandaloneMmPkg/Core/Pool.c                                                                         |  6 +-
 StandaloneMmPkg/Core/StandaloneMmCore.c                                                             | 37 ++++++---
 StandaloneMmPkg/Core/StandaloneMmCore.h                                                             | 12 +--
 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c                                       | 56 ++++++++++---
 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c                                   | 34 ++++++--
 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h                                   | 31 ++++++-
 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf                                 |  9 +--
 StandaloneMmPkg/Include/Guid/MmCoreData.h                                                           |  6 +-
 StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h                                | 47 ++++++-----
 StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h                                      |  4 +-
 StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h                                                |  6 +-
 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c                          |  6 +-
 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c                         | 53 +++++++++++-
 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c             | 32 +++++---
 StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c   |  6 +-
 StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf |  4 +-
 StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c                                     | 10 +--
 StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.c                                 |  4 +-
 StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf                               |  4 +-
 StandaloneMmPkg/StandaloneMmPkg.ci.yaml                                                             | 85 ++++++++++++++++++++
 StandaloneMmPkg/StandaloneMmPkg.dec                                                                 | 20 ++++-
 StandaloneMmPkg/StandaloneMmPkg.dsc                                                                 | 15 +++-
 30 files changed, 439 insertions(+), 154 deletions(-)
 create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68579): https://edk2.groups.io/g/devel/message/68579
Mute This Topic: https://groups.io/mt/78836547/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v1 00/25] Enable Core CI support for StandaloneMmPkg
Posted by Laszlo Ersek 3 years, 4 months ago
Hi Sami,

On 12/09/20 19:46, Sami Mujawar wrote:
> The EDKII Core CI runs the ECC tool that checks for good coding
> practices and the coding standard. This patch series fixes the
> ECC errors reported in the StandaloneMmPkg and enables support
> for EDKII Core CI.

thanks for the CC. I totally don't have brain capacity for reviewing
this series. I'm really sorry. (I just thought it's better to be honest
about it.)

Thanks
Laszlo

> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/1516_standalonemmpkg_ci_v1
> 
> Sami Mujawar (25):
>   StandaloneMmPkg: Add library header files to DEC
>   StandaloneMmPkg: Add library files to DSC
>   StandaloneMmPkg: Fix spell check reported errors
>   StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher
>   StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management
>   StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 4002 in FwVol helper
>   StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore
>   StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore
>   StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib
>   StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 9003 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 9001 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core
>   StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib
>   StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Add EDK2 Core CI support
>   .azurepipelines: Add StandaloneMmPkg to CI matrix
>   .pytool: CI Settings to support StandaloneMmPkg
> 
>  .azurepipelines/templates/pr-gate-build-job.yml                                                     |  2 +-
>  .pytool/CISettings.py                                                                               |  1 +
>  .pytool/Readme.md                                                                                   |  2 +-
>  StandaloneMmPkg/Core/Dependency.c                                                                   |  6 +-
>  StandaloneMmPkg/Core/Dispatcher.c                                                                   | 49 ++++++-----
>  StandaloneMmPkg/Core/FwVol.c                                                                        | 36 +++++----
>  StandaloneMmPkg/Core/Locate.c                                                                       |  6 +-
>  StandaloneMmPkg/Core/Mmi.c                                                                          |  4 +-
>  StandaloneMmPkg/Core/Pool.c                                                                         |  6 +-
>  StandaloneMmPkg/Core/StandaloneMmCore.c                                                             | 37 ++++++---
>  StandaloneMmPkg/Core/StandaloneMmCore.h                                                             | 12 +--
>  StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c                                       | 56 ++++++++++---
>  StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c                                   | 34 ++++++--
>  StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h                                   | 31 ++++++-
>  StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf                                 |  9 +--
>  StandaloneMmPkg/Include/Guid/MmCoreData.h                                                           |  6 +-
>  StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h                                | 47 ++++++-----
>  StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h                                      |  4 +-
>  StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h                                                |  6 +-
>  StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c                          |  6 +-
>  StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c                         | 53 +++++++++++-
>  StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c             | 32 +++++---
>  StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c   |  6 +-
>  StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf |  4 +-
>  StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c                                     | 10 +--
>  StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.c                                 |  4 +-
>  StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf                               |  4 +-
>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml                                                             | 85 ++++++++++++++++++++
>  StandaloneMmPkg/StandaloneMmPkg.dec                                                                 | 20 ++++-
>  StandaloneMmPkg/StandaloneMmPkg.dsc                                                                 | 15 +++-
>  30 files changed, 439 insertions(+), 154 deletions(-)
>  create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68648): https://edk2.groups.io/g/devel/message/68648
Mute This Topic: https://groups.io/mt/78836547/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v1 00/25] Enable Core CI support for StandaloneMmPkg
Posted by Yao, Jiewen 3 years, 4 months ago
Acked-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com>
> Sent: Thursday, December 10, 2020 2:47 AM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <sami.mujawar@arm.com>; ard.biesheuvel@arm.com; Yao,
> Jiewen <jiewen.yao@intel.com>; lersek@redhat.com;
> thomas.abraham@arm.com; Sughosh.Ganu@arm.com;
> Matteo.Carlini@arm.com; Ben.Adderson@arm.com; nd@arm.com
> Subject: [PATCH v1 00/25] Enable Core CI support for StandaloneMmPkg
> 
> The EDKII Core CI runs the ECC tool that checks for good coding
> practices and the coding standard. This patch series fixes the
> ECC errors reported in the StandaloneMmPkg and enables support
> for EDKII Core CI.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/1516_standalonemmpkg_ci_v1
> 
> Sami Mujawar (25):
>   StandaloneMmPkg: Add library header files to DEC
>   StandaloneMmPkg: Add library files to DSC
>   StandaloneMmPkg: Fix spell check reported errors
>   StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher
>   StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management
>   StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 4002 in FwVol helper
>   StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore
>   StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore
>   StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib
>   StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 9003 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 9001 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core
>   StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib
>   StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
>   StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint
>   StandaloneMmPkg: Add EDK2 Core CI support
>   .azurepipelines: Add StandaloneMmPkg to CI matrix
>   .pytool: CI Settings to support StandaloneMmPkg
> 
>  .azurepipelines/templates/pr-gate-build-job.yml
> |  2 +-
>  .pytool/CISettings.py                                                                               |  1 +
>  .pytool/Readme.md                                                                                   |  2 +-
>  StandaloneMmPkg/Core/Dependency.c
> |  6 +-
>  StandaloneMmPkg/Core/Dispatcher.c
> | 49 ++++++-----
>  StandaloneMmPkg/Core/FwVol.c
> | 36 +++++----
>  StandaloneMmPkg/Core/Locate.c
> |  6 +-
>  StandaloneMmPkg/Core/Mmi.c                                                                          |
> 4 +-
>  StandaloneMmPkg/Core/Pool.c                                                                         |
> 6 +-
>  StandaloneMmPkg/Core/StandaloneMmCore.c
> | 37 ++++++---
>  StandaloneMmPkg/Core/StandaloneMmCore.h
> | 12 +--
>  StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
> | 56 ++++++++++---
> 
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.
> c                                   | 34 ++++++--
> 
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.
> h                                   | 31 ++++++-
> 
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.
> inf                                 |  9 +--
>  StandaloneMmPkg/Include/Guid/MmCoreData.h
> |  6 +-
> 
> StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.
> h                                | 47 ++++++-----
>  StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
> |  4 +-
>  StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h
> |  6 +-
> 
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateH
> obList.c                          |  6 +-
> 
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermi
> ssions.c                         | 53 +++++++++++-
> 
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/Standalo
> neMmCoreEntryPoint.c             | 32 +++++---
> 
> StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Standal
> oneMmCoreMemoryAllocationLib.c   |  6 +-
> 
> StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Standal
> oneMmCoreMemoryAllocationLib.inf |  4 +-
>  StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c
> | 10 +--
> 
> StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependenc
> y.c                                 |  4 +-
> 
> StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependenc
> y.inf                               |  4 +-
>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml
> | 85 ++++++++++++++++++++
>  StandaloneMmPkg/StandaloneMmPkg.dec
> | 20 ++++-
>  StandaloneMmPkg/StandaloneMmPkg.dsc
> | 15 +++-
>  30 files changed, 439 insertions(+), 154 deletions(-)
>  create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68607): https://edk2.groups.io/g/devel/message/68607
Mute This Topic: https://groups.io/mt/78836547/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-